GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test_runner: add jsdocs to MockFunctionContext and MockTracker by ocodista · Pull Request #49555 · nodejs/node

Conversation

@ocodista

@ocodista ocodista commented Sep 8, 2023

Copy link
Copy Markdown
Contributor

Add JSDocs for all public functions of MockFunctionContext

cc @nodejs/test_runner

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Kecbm reacted with rocket emoji
All reactions
  • 🚀 1 reaction
@nodejs-github-bot

nodejs-github-bot commented Sep 8, 2023 •
edited by ErickWendel
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Sep 8, 2023
@ocodista ocodista changed the title test_runner: add jsdocs to MockFunctionContext test_runner: add jsdocs to MockFunctionContext and MockTracker Sep 8, 2023
ErickWendel
ErickWendel requested changes Sep 8, 2023
View reviewed changes
Comment thread lib/internal/test_runner/mock/mock.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread lib/internal/test_runner/mock/mock.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread lib/internal/test_runner/mock/mock.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread lib/internal/test_runner/mock/mock.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread lib/internal/test_runner/mock/mock.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread lib/internal/test_runner/mock/mock.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread lib/internal/test_runner/mock/mock.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread lib/internal/test_runner/mock/mock.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread lib/internal/test_runner/mock/mock.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread lib/internal/test_runner/mock/mock.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ErickWendel

ErickWendel commented Sep 8, 2023

Copy link
Copy Markdown
Member

@ocodista Also, don't forget to add jsdocs for constructors, getters, and setters and everything that would be accessible on the public API
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ocodista

ocodista commented Sep 8, 2023

Copy link
Copy Markdown
Contributor Author

@ErickWendel Thank you for the notes and reviews, I applied all the naming suggestions and included jsdocs for the getter/setter and get times function. Please take a new look whenever you have some time.
ErickWendel reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ocodista
ocodista force-pushed the main branch from 9193686 to 38c379c Compare September 10, 2023 12:50
@benjamingr

benjamingr commented Sep 10, 2023

Copy link
Copy Markdown
Member

Hey thanks for your contribution 🙇 please revert all the unrelated style changes and keep the JSDoc stuff?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ocodista

ocodista commented Sep 10, 2023

Copy link
Copy Markdown
Contributor Author

Hey thanks for your contribution 🙇 please revert all the unrelated style changes and keep the JSDoc stuff?

Thank you!

Just did it 😁
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ocodista
ocodista requested a review from ErickWendel September 10, 2023 23:28
ErickWendel
ErickWendel requested changes Sep 12, 2023
View reviewed changes
Comment thread lib/internal/test_runner/mock/mock.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
ErickWendel
ErickWendel requested changes Sep 12, 2023
View reviewed changes
Comment thread lib/internal/test_runner/mock/mock.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ocodista
test_runner: add jsdocs to mock.js
2769f7c
@ocodista
ocodista force-pushed the main branch from 50d5315 to 2769f7c Compare September 13, 2023 09:46
@ocodista
ocodista requested a review from ErickWendel September 13, 2023 09:46
ErickWendel
ErickWendel approved these changes Sep 13, 2023
View reviewed changes

@ErickWendel ErickWendel left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ocodista reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@ErickWendel ErickWendel added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 13, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 13, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 13, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53925/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
atlowChemi
atlowChemi approved these changes Sep 13, 2023
View reviewed changes

@atlowChemi atlowChemi left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, thanks for this contribution 🙂

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ocodista reacted with laugh emoji
All reactions
  • 😄 1 reaction
Comment thread lib/internal/test_runner/mock/mock.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ocodista @atlowChemi
Update lib/internal/test_runner/mock/mock.js
794a162 
Co-authored-by: Chemi Atlow <[email protected]>
atlowChemi
atlowChemi approved these changes Sep 13, 2023
View reviewed changes
@atlowChemi atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 13, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 13, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 13, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53929/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Sep 13, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53935/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Sep 14, 2023
CI Reliability 2023-09-14 nodejs/reliability#665
Open
15 tasks
@ocodista

ocodista commented Sep 14, 2023

Copy link
Copy Markdown
Contributor Author

Overall LGTM, thanks for this contribution 🙂

Thank you!!!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@atlowChemi atlowChemi added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 14, 2023
@atlowChemi atlowChemi added the commit-queue-squash PRs the Commit Queue should land as one squashed commit. label Sep 14, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 14, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 4efa374 into nodejs:main Sep 14, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 14, 2023

Copy link
Copy Markdown
Collaborator

Landed in 4efa374
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Sep 15, 2023
CI Reliability 2023-09-15 nodejs/reliability#666
Open
CI Reliability 2023-09-16 nodejs/reliability#667
Open
CI Reliability 2023-09-17 nodejs/reliability#668
Open
CI Reliability 2023-09-18 nodejs/reliability#669
Open
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@ocodista @ruyadorno
test_runner: add jsdocs to mock.js
5672e38 
PR-URL: #49555
Reviewed-By: Erick Wendel <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
This was referenced Sep 28, 2023
v20.7.1 proposal #49917
Closed
v20.8.0 proposal #49932
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
@ocodista @targos
test_runner: add jsdocs to mock.js
76a3563 
PR-URL: #49555
Reviewed-By: Erick Wendel <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
v18.19.0 release proposal #50953
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test_runner: add jsdocs to mock.js
47b5f21 
PR-URL: nodejs/node#49555
Reviewed-By: Erick Wendel <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test_runner: add jsdocs to mock.js
5efedab 
PR-URL: nodejs/node#49555
Reviewed-By: Erick Wendel <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ErickWendel ErickWendel ErickWendel approved these changes
@atlowChemi atlowChemi atlowChemi approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

commit-queue-squash PRs the Commit Queue should land as one squashed commit. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@ocodista @nodejs-github-bot @ErickWendel @benjamingr @atlowChemi
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.