GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — deps: update undici to 5.25.2 by nodejs-github-bot · Pull Request #49559 · nodejs/node

Conversation

@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot commented Sep 8, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

This is an automated update of undici to 5.25.2.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot
deps: update undici to 5.24.0
ffa24a2
@nodejs-github-bot nodejs-github-bot added dependencies PRs that add, update, or configure Node.js dependencies. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Sep 8, 2023
@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 8, 2023
@mcollina
mcollina requested review from KhafraDev and ronag September 8, 2023 15:20
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 8, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 8, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/53819/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95

aduh95 commented Sep 8, 2023

Copy link
Copy Markdown
Contributor

Quite a few seemingly related test failures
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@KhafraDev

KhafraDev commented Sep 8, 2023

Copy link
Copy Markdown
Member

is it only builds without ssl?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Sep 9, 2023
CI Reliability 2023-09-09 nodejs/reliability#660
Open
CI Reliability 2023-09-10 nodejs/reliability#661
Open
CI Reliability 2023-09-11 nodejs/reliability#662
Open
@joyeecheung joyeecheung mentioned this pull request Sep 11, 2023
test-runner-watch-mode is flaky #49605
Closed
@github-actions github-actions Bot mentioned this pull request Sep 12, 2023
CI Reliability 2023-09-12 nodejs/reliability#663
Open
19 tasks
@atlowChemi atlowChemi mentioned this pull request Sep 13, 2023
Unexpected error when using signal with reason in fetch #49557
Closed
@atlowChemi atlowChemi linked an issue Sep 13, 2023 that may be closed by this pull request
Unexpected error when using signal with reason in fetch #49557
Closed
@KhafraDev KhafraDev mentioned this pull request Sep 19, 2023
fix undici when node is built with --without-ssl nodejs/undici#2272
Merged
@nodejs-github-bot
deps: update undici to 5.25.0
bcff4b7
@nodejs-github-bot nodejs-github-bot changed the title deps: update undici to 5.24.0 deps: update undici to 5.25.0 Sep 20, 2023
@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 21, 2023
mcollina
mcollina approved these changes Sep 21, 2023
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 21, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 21, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/54106/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Sep 22, 2023
CI Reliability 2023-09-22 nodejs/reliability#673
Open
17 tasks
@nodejs-github-bot
deps: update undici to 5.25.2
1859ab0
@nodejs-github-bot nodejs-github-bot changed the title deps: update undici to 5.25.0 deps: update undici to 5.25.2 Sep 22, 2023
@mcollina

mcollina commented Sep 22, 2023

Copy link
Copy Markdown
Member

@KhafraDev let's see if WebSocket runs :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@KhafraDev

KhafraDev commented Sep 22, 2023

Copy link
Copy Markdown
Member

I tested it locally, there is something very strange going on if it doesn't work lol
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
KhafraDev
KhafraDev approved these changes Sep 22, 2023
View reviewed changes
@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 23, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 23, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 23, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/54170/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Sep 23, 2023
CI Reliability 2023-09-23 nodejs/reliability#674
Open
16 tasks
@nodejs-github-bot

nodejs-github-bot commented Sep 23, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/54175/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mcollina mcollina added commit-queue-squash PRs the Commit Queue should land as one squashed commit. commit-queue PRs queued for automated landing through the Commit Queue. and removed needs-ci PRs that need a full CI run. labels Sep 23, 2023
mcollina
mcollina approved these changes Sep 23, 2023
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 23, 2023
@nodejs-github-bot
nodejs-github-bot merged commit ef062b9 into main Sep 23, 2023
@nodejs-github-bot
nodejs-github-bot deleted the actions/tools-update-undici branch September 23, 2023 11:40
@nodejs-github-bot

nodejs-github-bot commented Sep 23, 2023

Copy link
Copy Markdown
Collaborator Author

Landed in ef062b9
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Sep 24, 2023
CI Reliability 2023-09-24 nodejs/reliability#675
Open
20 tasks
@joyeecheung joyeecheung mentioned this pull request Sep 25, 2023
wpt/test-structured-clone is flaky #49852
Closed
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@nodejs-github-bot @ruyadorno
deps: update undici to 5.24.0
61d18d6 
PR-URL: #49559
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Matthew Aitken <[email protected]>
This was referenced Sep 28, 2023
v20.7.1 proposal #49917
Closed
v20.8.0 proposal #49932
Merged
@targos targos added the backported-to-v18.x label Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
@KhafraDev KhafraDev KhafraDev approved these changes
@ronag ronag Awaiting requested review from ronag

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

commit-queue-squash PRs the Commit Queue should land as one squashed commit. dependencies PRs that add, update, or configure Node.js dependencies. lib / src Issues and PRs involving general changes in the lib/ or src/ directories.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unexpected error when using signal with reason in fetch

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@nodejs-github-bot @aduh95 @KhafraDev @mcollina @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.