GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: skip test-child-process-pipe-dataflow.js on Windows by joyeecheung · Pull Request #49563 · nodejs/node

Conversation

@joyeecheung

@joyeecheung joyeecheung commented Sep 8, 2023

Copy link
Copy Markdown
Member

This is constantly failing on Windows now that the CI is never green there. To give CI at least some green space, mark it as SKIP, because we've been practically ignoring the failure for months anyway, and will probably just continue doing that.

Refs: #48300

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@joyeecheung
test: skip test-child-process-pipe-dataflow.js on Windows
f9bb3d3 
This is constantly failing on Windows now that the CI is never green
there. To give CI at least some green space, mark it as SKIP, because
we've been practically ignoring the failure for months anyway, and
will probably just continue doing that.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Sep 8, 2023
@joyeecheung

joyeecheung commented Sep 8, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

As #48300 mentioned the issue comes from cygwin, my guess is if we really want to fix it, the test needs to be re-written to stop relying on that, but it's probably not a bug that needs to be fixed in core as it worked with older versions of cygwin. In case like this, if no one takes the test up, I think we should just skip it (I don't really know how to/want to deal with cygwin quirks, so I propose we just skip it on Windows, IMO a test was just not written with Windows in mind if it counts on how cat grep wc buffer data to work...). If someone wants to rewrite it, they can fix it later and remove the SKIP mark. But I don't see that happening soon.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Sep 8, 2023
View reviewed changes
@lpinca

lpinca commented Sep 8, 2023

Copy link
Copy Markdown
Member

See git-for-windows/git#4464 (comment).
bricss reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
MoLow
MoLow approved these changes Sep 9, 2023
View reviewed changes
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 9, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 9, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 9, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53845/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Sep 9, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53849/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Sep 10, 2023
CI Reliability 2023-09-10 nodejs/reliability#661
Open
CI Reliability 2023-09-11 nodejs/reliability#662
Open
targos
targos approved these changes Sep 11, 2023
View reviewed changes
@joyeecheung joyeecheung added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 11, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 11, 2023
@nodejs-github-bot
nodejs-github-bot merged commit b0edb28 into nodejs:main Sep 11, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 11, 2023

Copy link
Copy Markdown
Collaborator

Landed in b0edb28
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Sep 12, 2023
CI Reliability 2023-09-12 nodejs/reliability#663
Open
CI Reliability 2023-09-13 nodejs/reliability#664
Open
CI Reliability 2023-09-14 nodejs/reliability#665
Open
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@joyeecheung @ruyadorno
test: skip test-child-process-pipe-dataflow.js on Windows
667a924 
This is constantly failing on Windows now that the CI is never green
there. To give CI at least some green space, mark it as SKIP, because
we've been practically ignoring the failure for months anyway, and
will probably just continue doing that.

PR-URL: #49563
Refs: #48300
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
This was referenced Sep 28, 2023
v20.7.1 proposal #49917
Closed
v20.8.0 proposal #49932
Merged
@lpinca lpinca mentioned this pull request Sep 23, 2024
flaky: test-child-process-pipe-dataflow #25988
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@MoLow MoLow MoLow approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@joyeecheung @lpinca @nodejs-github-bot @targos @MoLow
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.