GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — typings: fix missing property in `ExportedHooks` by aduh95 · Pull Request #49567 · nodejs/node

Conversation

@aduh95

@aduh95 aduh95 commented Sep 8, 2023

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji jlenon7 reacted with rocket emoji
All reactions
  • 👍 1 reaction
  • 🚀 1 reaction
@aduh95
typings: fix missing property in ExportedHooks
88b2cb6
@aduh95 aduh95 added fast-track PRs proposed for a shorter-than-standard waiting period before landing. typings Issues and PRs related to internal TypeScript declarations. labels Sep 8, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 8, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Sep 8, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.
GeoffreyBooth, VoltrexKeyva, and MoLow reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Sep 8, 2023
GeoffreyBooth
GeoffreyBooth approved these changes Sep 8, 2023
View reviewed changes
JakobJingleheimer
JakobJingleheimer approved these changes Sep 9, 2023
View reviewed changes
UlisesGascon
UlisesGascon approved these changes Sep 9, 2023
View reviewed changes
VoltrexKeyva
VoltrexKeyva approved these changes Sep 9, 2023
View reviewed changes
@GeoffreyBooth GeoffreyBooth added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Sep 9, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 9, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 9, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/49567
✔  Done loading data for nodejs/node/pull/49567
----------------------------------- PR info ------------------------------------
Title      typings: fix missing property in `ExportedHooks` (#49567)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:exported-hooks-initialize -> nodejs:main
Labels     esm, fast-track, needs-ci, typings, commit-queue-squash
Commits    1
 - typings: fix missing property in `ExportedHooks`
Committers 1
 - Antoine du Hamel 
PR-URL: https://github.com/nodejs/node/pull/49567
Reviewed-By: Geoffrey Booth 
Reviewed-By: Jacob Smith 
Reviewed-By: Mohammed Keyvanzadeh 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49567
Reviewed-By: Geoffrey Booth 
Reviewed-By: Jacob Smith 
Reviewed-By: Mohammed Keyvanzadeh 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 08 Sep 2023 21:20:31 GMT
   ✔  Approvals: 3
   ✔  - Geoffrey Booth (@GeoffreyBooth) (TSC): https://github.com/nodejs/node/pull/49567#pullrequestreview-1618318659
   ✔  - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/49567#pullrequestreview-1618614867
   ✔  - Mohammed Keyvanzadeh (@VoltrexKeyva): https://github.com/nodejs/node/pull/49567#pullrequestreview-1618632222
   ℹ  This PR is being fast-tracked
   ✔  Last GitHub CI successful
   ✘  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6131683938
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label Sep 9, 2023
@GeoffreyBooth GeoffreyBooth added commit-queue PRs queued for automated landing through the Commit Queue. and removed needs-ci PRs that need a full CI run. commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Sep 9, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Sep 9, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 9, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/49567
✔  Done loading data for nodejs/node/pull/49567
----------------------------------- PR info ------------------------------------
Title      typings: fix missing property in `ExportedHooks` (#49567)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:exported-hooks-initialize -> nodejs:main
Labels     esm, fast-track, typings, commit-queue-squash
Commits    1
 - typings: fix missing property in `ExportedHooks`
Committers 1
 - Antoine du Hamel 
PR-URL: https://github.com/nodejs/node/pull/49567
Reviewed-By: Geoffrey Booth 
Reviewed-By: Jacob Smith 
Reviewed-By: Mohammed Keyvanzadeh 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49567
Reviewed-By: Geoffrey Booth 
Reviewed-By: Jacob Smith 
Reviewed-By: Mohammed Keyvanzadeh 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 08 Sep 2023 21:20:31 GMT
   ✔  Approvals: 3
   ✔  - Geoffrey Booth (@GeoffreyBooth) (TSC): https://github.com/nodejs/node/pull/49567#pullrequestreview-1618318659
   ✔  - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/49567#pullrequestreview-1618614867
   ✔  - Mohammed Keyvanzadeh (@VoltrexKeyva): https://github.com/nodejs/node/pull/49567#pullrequestreview-1618632222
   ℹ  This PR is being fast-tracked
   ✔  Last GitHub CI successful
   ✘  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6131826631
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@GeoffreyBooth GeoffreyBooth added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 9, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 9, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 9, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53843/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@GeoffreyBooth GeoffreyBooth added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Sep 9, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Sep 9, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 9, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/49567
✔  Done loading data for nodejs/node/pull/49567
----------------------------------- PR info ------------------------------------
Title      typings: fix missing property in `ExportedHooks` (#49567)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:exported-hooks-initialize -> nodejs:main
Labels     esm, fast-track, typings, commit-queue-squash
Commits    1
 - typings: fix missing property in `ExportedHooks`
Committers 1
 - Antoine du Hamel 
PR-URL: https://github.com/nodejs/node/pull/49567
Reviewed-By: Geoffrey Booth 
Reviewed-By: Jacob Smith 
Reviewed-By: Mohammed Keyvanzadeh 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49567
Reviewed-By: Geoffrey Booth 
Reviewed-By: Jacob Smith 
Reviewed-By: Mohammed Keyvanzadeh 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 08 Sep 2023 21:20:31 GMT
   ✔  Approvals: 3
   ✔  - Geoffrey Booth (@GeoffreyBooth) (TSC): https://github.com/nodejs/node/pull/49567#pullrequestreview-1618318659
   ✔  - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/49567#pullrequestreview-1618614867
   ✔  - Mohammed Keyvanzadeh (@VoltrexKeyva): https://github.com/nodejs/node/pull/49567#pullrequestreview-1618632222
   ℹ  This PR is being fast-tracked
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2023-09-09T17:55:08Z: https://ci.nodejs.org/job/node-test-pull-request/53843/
- Querying data for job/node-test-pull-request/53843/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6132755646
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Sep 9, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53844/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
MoLow
MoLow approved these changes Sep 9, 2023
View reviewed changes
@MoLow MoLow added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Sep 9, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 9, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 5bb0cb2 into nodejs:main Sep 9, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 9, 2023

Copy link
Copy Markdown
Collaborator

Landed in 5bb0cb2
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 deleted the exported-hooks-initialize branch September 9, 2023 22:07
This was referenced Sep 10, 2023
CI Reliability 2023-09-10 nodejs/reliability#661
Open
CI Reliability 2023-09-11 nodejs/reliability#662
Open
CI Reliability 2023-09-12 nodejs/reliability#663
Open
@joyeecheung joyeecheung mentioned this pull request Sep 12, 2023
parallel/test-tls-socket-close is flaky #49628
Closed
This was referenced Sep 13, 2023
CI Reliability 2023-09-13 nodejs/reliability#664
Open
CI Reliability 2023-09-14 nodejs/reliability#665
Open
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@aduh95 @ruyadorno
typings: fix missing property in ExportedHooks
ac06607 
PR-URL: #49567
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
This was referenced Sep 28, 2023
v20.7.1 proposal #49917
Closed
v20.8.0 proposal #49932
Merged
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
@aduh95 @targos
typings: fix missing property in ExportedHooks
71c4ae3 
PR-URL: nodejs#49567
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
@targos targos mentioned this pull request Nov 11, 2023
[v18.x] Backport most ESM and customization hook changes #50669
Closed
@targos targos added the backported-to-v18.x label Nov 23, 2023
targos pushed a commit that referenced this pull request Nov 23, 2023
@aduh95 @targos
typings: fix missing property in ExportedHooks
9456094 
PR-URL: #49567
Backport-PR-URL: #50669
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
v18.19.0 release proposal #50953
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
typings: fix missing property in ExportedHooks
5622da9 
PR-URL: nodejs/node#49567
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
typings: fix missing property in ExportedHooks
1353fe7 
PR-URL: nodejs/node#49567
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes
@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes
@UlisesGascon UlisesGascon UlisesGascon approved these changes
@MoLow MoLow MoLow approved these changes
+1 more reviewer
@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

esm Issues and PRs related to the ECMAScript Modules implementation. fast-track PRs proposed for a shorter-than-standard waiting period before landing. typings Issues and PRs related to internal TypeScript declarations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@aduh95 @nodejs-github-bot @GeoffreyBooth @JakobJingleheimer @UlisesGascon @MoLow @VoltrexKeyva @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.