GeezerVison

- Loading data for nodejs/node/pull/49574
✔  Done loading data for nodejs/node/pull/49574
----------------------------------- PR info ------------------------------------
Title      test: deflake test-http-regr-gh-2928 (#49574)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     lpinca:deflake/test-http-regr-gh-2928 -> nodejs:main
Labels     test, needs-ci
Commits    1
 - test: deflake test-http-regr-gh-2928
Committers 1
 - Luigi Pinca 
PR-URL: https://github.com/nodejs/node/pull/49574
Fixes: https://github.com/nodejs/node/pull/49565
Fixes: https://github.com/nodejs/node/issues/49564
Reviewed-By: Yagiz Nizipli 
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49574
Fixes: https://github.com/nodejs/node/pull/49565
Fixes: https://github.com/nodejs/node/issues/49564
Reviewed-By: Yagiz Nizipli 
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 09 Sep 2023 12:59:22 GMT
   ✔  Approvals: 2
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/49574#pullrequestreview-1618710274
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/49574#pullrequestreview-1629983759
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-09-10T19:40:28Z: https://ci.nodejs.org/job/node-test-pull-request/53872/
- Querying data for job/node-test-pull-request/53872/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
   5c39ee6f87..b651e37d2e  main       -> origin/main
✔  origin/main is now up-to-date
main is out of sync with origin/main. Mismatched commits:
 - b651e37d2e 2023-09-18, Version 20.7.0 (Current)
--------------------------------------------------------------------------------
HEAD is now at b651e37d2e 2023-09-18, Version 20.7.0 (Current)
   ✔  Reset to origin/main
- Downloading patch for 49574
From https://github.com/nodejs/node
 * branch                  refs/pull/49574/merge -> FETCH_HEAD
✔  Fetched commits as b651e37d2e36..6db17f7c5518
--------------------------------------------------------------------------------
[main 26c4258a63] test: deflake test-http-regr-gh-2928
 Author: Luigi Pinca 
 Date: Sat Sep 9 14:44:31 2023 +0200
 1 file changed, 2 insertions(+), 2 deletions(-)
   ✔  Patches applied
--------------------------------------------------------------------------------
   ⚠  Found Fixes: https://github.com/nodejs/node/issues/49564, skipping..
--------------------------------- New Message ----------------------------------
test: deflake test-http-regr-gh-2928
Hard code the value of the host parameter to common.localhostIPv4 in

server.listen() and net.connect(). This

ensures that the client socket._handle is not reinitialized during

connection due to the family autodetection algorithm, preventing

parser.consume() from being called with an invalid socket._handle

parameter.
works around an issue in the FreeBSD 12 machine where the stress test

is run where some sockets get stuck after connection.

Closes: #49565

Fixes: #49564

PR-URL: #49574

Fixes: #49565

Reviewed-By: Yagiz Nizipli [email protected]

Reviewed-By: James M Snell [email protected]
[main 9756b0d684] test: deflake test-http-regr-gh-2928

Author: Luigi Pinca [email protected]

Date: Sat Sep 9 14:44:31 2023 +0200

1 file changed, 2 insertions(+), 2 deletions(-)

✖  9756b0d68462303f0e35346e6df4bb695fcbf022

✔  0:0      no Co-authored-by metadata                co-authored-by-is-trailer

✔  12:7     Valid fixes URL.                          fixes-url

✖  14:7     Pull request URL must reference a comment or discussion. fixes-url

✔  0:0      blank line after title                    line-after-title

✔  0:0      line-lengths are valid                    line-length

✔  0:0      metadata is at end of message             metadata-end

✔  13:8     PR-URL is valid.                          pr-url

✔  0:0      reviewers are valid                       reviewers

✔  0:0      valid subsystems                          subsystem

✔  0:0      Title is formatted correctly.             title-format

✔  0:0      Title is <= 50 columns.                   title-length
ℹ  Please fix the commit message and try again.

Please manually ammend the commit message, by running

git commit --amend

Once commit message is fixed, finish the landing command running

git node land --continue