GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test_runner: fix test runner watch mode when no positional arguments by MoLow · Pull Request #49578 · nodejs/node

Conversation

@MoLow

@MoLow MoLow commented Sep 9, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fixes: #49617
I cannot reproduce the original error reported in #49544
but this fixes the issue in the comment

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot

nodejs-github-bot commented Sep 9, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Sep 9, 2023
atlowChemi
atlowChemi approved these changes Sep 9, 2023
View reviewed changes
@MoLow
MoLow requested a review from benjamingr September 11, 2023 17:47
@Gabriel-Tapes

Gabriel-Tapes commented Sep 11, 2023

Copy link
Copy Markdown

I cannot reproduce the original error reported in #49544

The issue I reported in #49544 is probably related to the compilation done by Arch Linux, so I'm closing it.
MoLow reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
benjamingr
benjamingr approved these changes Sep 11, 2023
View reviewed changes
@atlowChemi atlowChemi added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. test_runner Issues and PRs related to the test runner subsystem. watch-mode Issues and PRs related to watch mode. labels Sep 11, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 11, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 11, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53896/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Sep 11, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53899/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Sep 12, 2023
CI Reliability 2023-09-12 nodejs/reliability#663
Open
19 tasks
@Linkgoron Linkgoron mentioned this pull request Sep 12, 2023
'node --test --watch' fails: node: --watch requires specifying a file #49617
Closed
UlisesGascon
UlisesGascon approved these changes Sep 12, 2023
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Sep 12, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53916/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Sep 12, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53918/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Sep 13, 2023
CI Reliability 2023-09-13 nodejs/reliability#664
Open
CI Reliability 2023-09-14 nodejs/reliability#665
Open
@MoLow
test_runner: fix test runner watch mode when no positional arguments
faa2eff
@MoLow
MoLow force-pushed the watch-mode-with-test branch from f0d3675 to faa2eff Compare September 14, 2023 05:49
@MoLow
MoLow requested a review from atlowChemi September 14, 2023 05:50
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 14, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 14, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 14, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53947/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
atlowChemi
atlowChemi approved these changes Sep 14, 2023
View reviewed changes
@MoLow MoLow added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 14, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 14, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 1a4ae46 into nodejs:main Sep 14, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 14, 2023

Copy link
Copy Markdown
Collaborator

Landed in 1a4ae46
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MoLow
MoLow deleted the watch-mode-with-test branch September 14, 2023 11:48
This was referenced Sep 15, 2023
CI Reliability 2023-09-15 nodejs/reliability#666
Open
CI Reliability 2023-09-16 nodejs/reliability#667
Open
CI Reliability 2023-09-17 nodejs/reliability#668
Open
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@MoLow @ruyadorno
test_runner: fix test runner watch mode when no positional arguments
7686551 
PR-URL: #49578
Fixes: #49617
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
This was referenced Sep 28, 2023
v20.7.1 proposal #49917
Closed
v20.8.0 proposal #49932
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
@MoLow @targos
test_runner: fix test runner watch mode when no positional arguments
e459598 
PR-URL: #49578
Fixes: #49617
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
v18.19.0 release proposal #50953
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test_runner: fix test runner watch mode when no positional
751e807 
PR-URL: nodejs/node#49578
Fixes: nodejs/node#49617
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test_runner: fix test runner watch mode when no positional
be1211d 
PR-URL: nodejs/node#49578
Fixes: nodejs/node#49617
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingr benjamingr benjamingr approved these changes
@UlisesGascon UlisesGascon UlisesGascon approved these changes
@atlowChemi atlowChemi atlowChemi approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. watch-mode Issues and PRs related to watch mode.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

'node --test --watch' fails: node: --watch requires specifying a file

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@MoLow @nodejs-github-bot @Gabriel-Tapes @benjamingr @UlisesGascon @atlowChemi
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.