GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — benchmark: add a benchmark for read() of ReadableStreams by debadree25 · Pull Request #49622 · nodejs/node

Conversation

@debadree25

@debadree25 debadree25 commented Sep 12, 2023

Copy link
Copy Markdown
Contributor

While looking at nodejs/performance#82 and trying to find a way to optimise read() realised that there is no specific benchmark for the read() function and the byob variant of read too

Refs: nodejs/performance#82

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@debadree25
benchmark: add a benchmark for read() of ReadableStreams
ace6c05 
Refs: nodejs/performance#82
@debadree25
debadree25 requested a review from anonrig September 12, 2023 10:42
@nodejs-github-bot nodejs-github-bot added the benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. label Sep 12, 2023
@debadree25
fixup! lint
2f0c075
H4ad
H4ad reviewed Sep 12, 2023
View reviewed changes
Comment thread benchmark/webstreams/readable-read.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
H4ad
H4ad reviewed Sep 12, 2023
View reviewed changes
Comment thread benchmark/webstreams/readable-read.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
anonrig
anonrig approved these changes Sep 13, 2023
View reviewed changes
@debadree25 debadree25 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Sep 13, 2023
H4ad
H4ad approved these changes Sep 13, 2023
View reviewed changes
@anonrig anonrig added the performance Issues and PRs related to the performance of Node.js. label Sep 13, 2023
@debadree25 debadree25 added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 18, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Sep 18, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 18, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/49622
✔  Done loading data for nodejs/node/pull/49622
----------------------------------- PR info ------------------------------------
Title      benchmark: add a benchmark for read() of ReadableStreams (#49622)
Author     Debadree Chatterjee  (@debadree25)
Branch     debadree25:ft/bench-readable-read -> nodejs:main
Labels     benchmark, performance, author ready
Commits    2
 - benchmark: add a benchmark for read() of ReadableStreams
 - fixup! lint
Committers 1
 - Debadree Chatterjee 
PR-URL: https://github.com/nodejs/node/pull/49622
Refs: https://github.com/nodejs/performance/issues/82
Reviewed-By: Yagiz Nizipli 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49622
Refs: https://github.com/nodejs/performance/issues/82
Reviewed-By: Yagiz Nizipli 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 12 Sep 2023 10:42:20 GMT
   ✔  Approvals: 1
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/49622#pullrequestreview-1623539599
   ✘  This PR needs to wait 29 more hours to land (or 0 hours if there is one more approval)
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6218493460
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@debadree25

debadree25 commented Sep 18, 2023

Copy link
Copy Markdown
Contributor Author

ah needs another approval
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@debadree25 debadree25 added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Sep 19, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Sep 19, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 19, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/49622
✔  Done loading data for nodejs/node/pull/49622
----------------------------------- PR info ------------------------------------
Title      benchmark: add a benchmark for read() of ReadableStreams (#49622)
Author     Debadree Chatterjee  (@debadree25)
Branch     debadree25:ft/bench-readable-read -> nodejs:main
Labels     benchmark, performance, author ready
Commits    2
 - benchmark: add a benchmark for read() of ReadableStreams
 - fixup! lint
Committers 1
 - Debadree Chatterjee 
PR-URL: https://github.com/nodejs/node/pull/49622
Refs: https://github.com/nodejs/performance/issues/82
Reviewed-By: Yagiz Nizipli 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49622
Refs: https://github.com/nodejs/performance/issues/82
Reviewed-By: Yagiz Nizipli 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 12 Sep 2023 10:42:20 GMT
   ✔  Approvals: 1
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/49622#pullrequestreview-1623539599
   ✘  This PR needs to wait 4 more hours to land (or 0 hours if there is one more approval)
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6231626698
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@debadree25 debadree25 added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Sep 19, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 19, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 19, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/49622
✔  Done loading data for nodejs/node/pull/49622
----------------------------------- PR info ------------------------------------
Title      benchmark: add a benchmark for read() of ReadableStreams (#49622)
Author     Debadree Chatterjee  (@debadree25)
Branch     debadree25:ft/bench-readable-read -> nodejs:main
Labels     benchmark, performance, author ready
Commits    2
 - benchmark: add a benchmark for read() of ReadableStreams
 - fixup! lint
Committers 1
 - Debadree Chatterjee 
PR-URL: https://github.com/nodejs/node/pull/49622
Refs: https://github.com/nodejs/performance/issues/82
Reviewed-By: Yagiz Nizipli 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49622
Refs: https://github.com/nodejs/performance/issues/82
Reviewed-By: Yagiz Nizipli 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 12 Sep 2023 10:42:20 GMT
   ✔  Approvals: 1
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/49622#pullrequestreview-1623539599
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 49622
From https://github.com/nodejs/node
 * branch                  refs/pull/49622/merge -> FETCH_HEAD
✔  Fetched commits as 2ccfb23b7fc8..2f0c075a78da
--------------------------------------------------------------------------------
[main de7b9357a5] benchmark: add a benchmark for read() of ReadableStreams
 Author: Debadree Chatterjee 
 Date: Tue Sep 12 16:09:45 2023 +0530
 1 file changed, 49 insertions(+)
 create mode 100644 benchmark/webstreams/readable-read.js
[main b2a9f7b33f] fixup! lint
 Author: Debadree Chatterjee 
 Date: Tue Sep 12 16:32:19 2023 +0530
 1 file changed, 2 insertions(+), 2 deletions(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)

Executing: git node land --amend --yes

⚠  Found Refs: nodejs/performance#82, skipping..

--------------------------------- New Message ----------------------------------

benchmark: add a benchmark for read() of ReadableStreams


Refs: nodejs/performance#82

PR-URL: #49622

Reviewed-By: Yagiz Nizipli [email protected]


[detached HEAD 1a9db4e005] benchmark: add a benchmark for read() of ReadableStreams

Author: Debadree Chatterjee [email protected]

Date: Tue Sep 12 16:09:45 2023 +0530

1 file changed, 49 insertions(+)

create mode 100644 benchmark/webstreams/readable-read.js

Rebasing (3/4)

Rebasing (4/4)


Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

fixup! lint


PR-URL: #49622

Refs: nodejs/performance#82

Reviewed-By: Yagiz Nizipli [email protected]


[detached HEAD 1a71ac33d2] fixup! lint

Author: Debadree Chatterjee [email protected]

Date: Tue Sep 12 16:32:19 2023 +0530

1 file changed, 2 insertions(+), 2 deletions(-)


Successfully rebased and updated refs/heads/main.


ℹ  Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.
https://github.com/nodejs/node/actions/runs/6234511673
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label Sep 19, 2023
@debadree25 debadree25 added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Sep 19, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 19, 2023
@nodejs-github-bot
nodejs-github-bot merged commit cd97e28 into nodejs:main Sep 19, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 19, 2023

Copy link
Copy Markdown
Collaborator

Landed in cd97e28
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@debadree25 @ruyadorno
benchmark: add a benchmark for read() of ReadableStreams
4879e3f 
Refs: nodejs/performance#82
PR-URL: #49622
Reviewed-By: Yagiz Nizipli <[email protected]>
This was referenced Sep 28, 2023
v20.7.1 proposal #49917
Closed
v20.8.0 proposal #49932
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes
@H4ad H4ad H4ad approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. commit-queue-squash PRs the Commit Queue should land as one squashed commit. performance Issues and PRs related to the performance of Node.js.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@debadree25 @nodejs-github-bot @anonrig @H4ad
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.