GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — errors: improve performance of classRegExp in errors.js by Uzlopak · Pull Request #49643 · nodejs/node

Conversation

@Uzlopak

@Uzlopak Uzlopak commented Sep 14, 2023

Copy link
Copy Markdown
Contributor

This PR simplifies the RegExp for detecting class names

Main:
error/error-class-reg-exp.js n=100000: 9,114.045930023383

PR:
error/error-class-reg-exp.js n=100000: 11,002.079862772853

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss and Fdawgs reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@Uzlopak
errors: improve classRegExp in errors.js
d40ea57
@nodejs-github-bot nodejs-github-bot added errors Issues and PRs related to JavaScript errors originating in Node.js core. needs-ci PRs that need a full CI run. labels Sep 14, 2023
@Uzlopak Uzlopak changed the title errors: improve classRegExp in errors.js errors: improve performance of classRegExp in errors.js Sep 14, 2023
@Uzlopak
fix linting issue
8a9e34c
anonrig
anonrig approved these changes Sep 14, 2023
View reviewed changes
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 14, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 14, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 14, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53941/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

LiviaMedeiros
LiviaMedeiros approved these changes Sep 14, 2023
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Sep 14, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53951/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

aduh95
aduh95 approved these changes Sep 14, 2023
View reviewed changes
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Sep 14, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Sep 16, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 16, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/49643
✔  Done loading data for nodejs/node/pull/49643
----------------------------------- PR info ------------------------------------
Title      errors: improve performance of classRegExp in errors.js (#49643)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     Uzlopak:improve-classRegExp -> nodejs:main
Labels     errors, author ready, needs-ci
Commits    2
 - errors: improve classRegExp in errors.js
 - fix linting issue
Committers 1
 - uzlopak 
PR-URL: https://github.com/nodejs/node/pull/49643
Reviewed-By: Yagiz Nizipli 
Reviewed-By: LiviaMedeiros 
Reviewed-By: Antoine du Hamel 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49643
Reviewed-By: Yagiz Nizipli 
Reviewed-By: LiviaMedeiros 
Reviewed-By: Antoine du Hamel 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 14 Sep 2023 01:06:38 GMT
   ✔  Approvals: 3
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/49643#pullrequestreview-1625778455
   ✔  - LiviaMedeiros (@LiviaMedeiros): https://github.com/nodejs/node/pull/49643#pullrequestreview-1627548542
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/49643#pullrequestreview-1627640362
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-09-14T18:44:30Z: https://ci.nodejs.org/job/node-test-pull-request/53951/
- Querying data for job/node-test-pull-request/53951/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 49643
From https://github.com/nodejs/node
 * branch                  refs/pull/49643/merge -> FETCH_HEAD
✔  Fetched commits as f42a1039917a..8a9e34c3f276
--------------------------------------------------------------------------------
Auto-merging lib/internal/errors.js
[main 115c123fdb] errors: improve classRegExp in errors.js
 Author: uzlopak 
 Date: Thu Sep 14 03:04:46 2023 +0200
 2 files changed, 25 insertions(+), 1 deletion(-)
 create mode 100644 benchmark/error/error-class-reg-exp.js
[main e70bc66291] fix linting issue
 Author: uzlopak 
 Date: Thu Sep 14 03:32:14 2023 +0200
 1 file changed, 3 insertions(+), 3 deletions(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
errors: improve classRegExp in errors.js

PR-URL: #49643
Reviewed-By: Yagiz Nizipli [email protected]
Reviewed-By: LiviaMedeiros [email protected]
Reviewed-By: Antoine du Hamel [email protected]

[detached HEAD 0e95b8f4c0] errors: improve classRegExp in errors.js
Author: uzlopak [email protected]
Date: Thu Sep 14 03:04:46 2023 +0200
2 files changed, 25 insertions(+), 1 deletion(-)
create mode 100644 benchmark/error/error-class-reg-exp.js
Rebasing (3/4)
Rebasing (4/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
fix linting issue

PR-URL: #49643
Reviewed-By: Yagiz Nizipli [email protected]
Reviewed-By: LiviaMedeiros [email protected]
Reviewed-By: Antoine du Hamel [email protected]

[detached HEAD d2443d7ea2] fix linting issue
Author: uzlopak [email protected]
Date: Thu Sep 14 03:32:14 2023 +0200
1 file changed, 3 insertions(+), 3 deletions(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/6204361859

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@LiviaMedeiros LiviaMedeiros added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Sep 16, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 16, 2023
@nodejs-github-bot
nodejs-github-bot merged commit db8217b into nodejs:main Sep 16, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 16, 2023

Copy link
Copy Markdown
Collaborator

Landed in db8217b

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Fdawgs Fdawgs mentioned this pull request Sep 16, 2023
refactor(vary): use word character inside regex character class fastify/fastify-cors#270
Merged
2 tasks done
@Uzlopak
Uzlopak deleted the improve-classRegExp branch September 16, 2023 11:40
@github-actions github-actions Bot mentioned this pull request Sep 18, 2023
CI Reliability 2023-09-18 nodejs/reliability#669
Open
33 tasks
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@Uzlopak @ruyadorno
errors: improve classRegExp in errors.js
142e256
PR-URL: #49643
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
This was referenced Sep 28, 2023
v20.7.1 proposal #49917
Closed
v20.8.0 proposal #49932
Merged
@H4ad H4ad mentioned this pull request Sep 29, 2023
Node errors are very slow to create nodejs/performance#40
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes
@aduh95 aduh95 aduh95 approved these changes
@LiviaMedeiros LiviaMedeiros LiviaMedeiros approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. commit-queue-squash PRs the Commit Queue should land as one squashed commit. errors Issues and PRs related to JavaScript errors originating in Node.js core. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Uzlopak @nodejs-github-bot @anonrig @aduh95 @LiviaMedeiros
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.