GeezerVison

- Loading data for nodejs/node/pull/49662
✔  Done loading data for nodejs/node/pull/49662
----------------------------------- PR info ------------------------------------
Title      stream: improve webstream readable async iterator performance (#49662)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     rluvaton:improve-readable-stream-async-iterator -> nodejs:main
Labels     performance, author ready, needs-ci, needs-benchmark-ci, web streams
Commits    5
 - stream: improve webstream readable async iterator performance
 - stream: rename, fix lint issues and cleanup
 - stream: add proto
 - stream: inline var
 - stream: remove `__proto__: null` due to performance hit
Committers 2
 - Raz Luvaton <[email protected]>
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/49662
Reviewed-By: Matteo Collina 
Reviewed-By: Luigi Pinca 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: James M Snell 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Moshe Atlow 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49662
Reviewed-By: Matteo Collina 
Reviewed-By: Luigi Pinca 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: James M Snell 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Moshe Atlow 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 15 Sep 2023 11:32:53 GMT
   ✔  Approvals: 6
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/49662#pullrequestreview-1629143084
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/49662#pullrequestreview-1629556395
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/49662#pullrequestreview-1629701561
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/49662#pullrequestreview-1629983394
   ✔  - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/49662#pullrequestreview-1630072844
   ✔  - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/49662#pullrequestreview-1631104311
   ✔  Last GitHub CI successful
   ℹ  Last Benchmark CI on 2023-09-18T13:22:25Z: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1388/
   ℹ  Last Full PR CI on 2023-09-18T13:22:25Z: https://ci.nodejs.org/job/node-test-pull-request/54033/
- Querying data for job/node-test-pull-request/1388/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 49662
From https://github.com/nodejs/node
 * branch                  refs/pull/49662/merge -> FETCH_HEAD
✔  Fetched commits as b03a757619db..824abd622d65
--------------------------------------------------------------------------------
[main 9e5b3a7ed2] stream: improve webstream readable async iterator performance
 Author: Raz Luvaton <[email protected]>
 Date: Fri Sep 15 14:32:31 2023 +0300
 1 file changed, 46 insertions(+), 29 deletions(-)
[main 2419b69e63] stream: rename, fix lint issues and cleanup
 Author: Raz Luvaton <[email protected]>
 Date: Fri Sep 15 14:39:30 2023 +0300
 1 file changed, 32 insertions(+), 33 deletions(-)
[main bb9ba7cb76] stream: add proto
 Author: Raz Luvaton <[email protected]>
 Date: Sun Sep 17 19:38:11 2023 +0300
 1 file changed, 1 insertion(+)
[main a31438954c] stream: inline var
 Author: Raz Luvaton <[email protected]>
 Date: Sun Sep 17 22:58:17 2023 +0300
 1 file changed, 1 insertion(+), 3 deletions(-)
[main cf191602a9] stream: remove `__proto__: null` due to performance hit
 Author: Raz Luvaton <[email protected]>
 Date: Mon Sep 18 10:20:13 2023 +0300
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✔  Patches applied
There are 5 commits in the PR. Attempting autorebase.
Rebasing (2/10)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

stream: improve webstream readable async iterator performance
PR-URL: #49662

Reviewed-By: Matteo Collina [email protected]

Reviewed-By: Luigi Pinca [email protected]

Reviewed-By: Yagiz Nizipli [email protected]

Reviewed-By: James M Snell [email protected]

Reviewed-By: Benjamin Gruenbaum [email protected]

Reviewed-By: Moshe Atlow [email protected]
[detached HEAD 1c9a3f84a2] stream: improve webstream readable async iterator performance

Author: Raz Luvaton [email protected]

Date: Fri Sep 15 14:32:31 2023 +0300

1 file changed, 46 insertions(+), 29 deletions(-)

Rebasing (3/10)

Rebasing (4/10)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

stream: rename, fix lint issues and cleanup
PR-URL: #49662

Reviewed-By: Matteo Collina [email protected]

Reviewed-By: Luigi Pinca [email protected]

Reviewed-By: Yagiz Nizipli [email protected]

Reviewed-By: James M Snell [email protected]

Reviewed-By: Benjamin Gruenbaum [email protected]

Reviewed-By: Moshe Atlow [email protected]
[detached HEAD fb2af515cb] stream: rename, fix lint issues and cleanup

Author: Raz Luvaton [email protected]

Date: Fri Sep 15 14:39:30 2023 +0300

1 file changed, 32 insertions(+), 33 deletions(-)

Rebasing (5/10)

Rebasing (6/10)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

stream: add proto
Co-authored-by: Benjamin Gruenbaum [email protected]

PR-URL: #49662

Reviewed-By: Matteo Collina [email protected]

Reviewed-By: Luigi Pinca [email protected]

Reviewed-By: Yagiz Nizipli [email protected]

Reviewed-By: James M Snell [email protected]

Reviewed-By: Benjamin Gruenbaum [email protected]

Reviewed-By: Moshe Atlow [email protected]
[detached HEAD 4b57b45213] stream: add proto

Author: Raz Luvaton [email protected]

Date: Sun Sep 17 19:38:11 2023 +0300

1 file changed, 1 insertion(+)

Rebasing (7/10)

Rebasing (8/10)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

stream: inline var
PR-URL: #49662

Reviewed-By: Matteo Collina [email protected]

Reviewed-By: Luigi Pinca [email protected]

Reviewed-By: Yagiz Nizipli [email protected]

Reviewed-By: James M Snell [email protected]

Reviewed-By: Benjamin Gruenbaum [email protected]

Reviewed-By: Moshe Atlow [email protected]
[detached HEAD 9123089652] stream: inline var

Author: Raz Luvaton [email protected]

Date: Sun Sep 17 22:58:17 2023 +0300

1 file changed, 1 insertion(+), 3 deletions(-)

Rebasing (9/10)

Rebasing (10/10)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

stream: remove __proto__: null due to performance hit
from 140% improvement to 120%
PR-URL: #49662

Reviewed-By: Matteo Collina [email protected]

Reviewed-By: Luigi Pinca [email protected]

Reviewed-By: Yagiz Nizipli [email protected]

Reviewed-By: James M Snell [email protected]

Reviewed-By: Benjamin Gruenbaum [email protected]

Reviewed-By: Moshe Atlow [email protected]
[detached HEAD d515c67265] stream: remove __proto__: null due to performance hit

Author: Raz Luvaton [email protected]

Date: Mon Sep 18 10:20:13 2023 +0300

1 file changed, 1 insertion(+), 1 deletion(-)
Successfully rebased and updated refs/heads/main.
ℹ  Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.