GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — meta: add primordials strategic initiative by benjamingr · Pull Request #49706 · nodejs/node

Conversation

@benjamingr

@benjamingr benjamingr commented Sep 18, 2023

Copy link
Copy Markdown
Member

This is a pull request to add the strategic initiative outlined in nodejs/TSC#1439 there is a list of tasks here nodejs/TSC#1439 (comment)

Please do not fast-track this as I'd like to give nodejs/TSC#1439 (comment) a week to make sure everyone had time to see it for lazy consensus

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
atlowChemi and bricss reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@benjamingr
Update strategic-initiatives.md
47f31b6
@nodejs-github-bot

nodejs-github-bot commented Sep 18, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Sep 18, 2023
@benjamingr benjamingr changed the title Update strategic-initiatives.md meta: add primordials strategic initiative Sep 18, 2023
@benjamingr benjamingr mentioned this pull request Sep 18, 2023
New Strategic Initiative on Primordials nodejs/TSC#1439
Open
anonrig
anonrig approved these changes Sep 18, 2023
View reviewed changes
mcollina
mcollina approved these changes Sep 18, 2023
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
MoLow
MoLow approved these changes Sep 18, 2023
View reviewed changes
fhinkel
fhinkel approved these changes Sep 19, 2023
View reviewed changes
targos
targos reviewed Sep 19, 2023
View reviewed changes
Comment thread doc/contributing/strategic-initiatives.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
targos
targos approved these changes Sep 19, 2023
View reviewed changes
tniessen
tniessen approved these changes Sep 19, 2023
View reviewed changes
Comment thread doc/contributing/strategic-initiatives.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
@benjamingr
fixup: update link
73ad74b
@benjamingr benjamingr added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 20, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Sep 20, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 20, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/49706
✔  Done loading data for nodejs/node/pull/49706
----------------------------------- PR info ------------------------------------
Title      meta: add primordials strategic initiative  (#49706)
Author     Benjamin Gruenbaum  (@benjamingr)
Branch     benjamingr:add-primordials-strategic-initiatiive -> nodejs:main
Labels     doc
Commits    2
 - Update strategic-initiatives.md
 - fixup: update link
Committers 1
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/49706
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Matteo Collina 
Reviewed-By: Moshe Atlow 
Reviewed-By: Franziska Hinkelmann 
Reviewed-By: Michaël Zasso 
Reviewed-By: Tobias Nießen 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49706
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Matteo Collina 
Reviewed-By: Moshe Atlow 
Reviewed-By: Franziska Hinkelmann 
Reviewed-By: Michaël Zasso 
Reviewed-By: Tobias Nießen 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - fixup: update link
   ℹ  This PR was created on Mon, 18 Sep 2023 17:56:58 GMT
   ✔  Approvals: 6
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/49706#pullrequestreview-1631839626
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/49706#pullrequestreview-1631852567
   ✔  - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/49706#pullrequestreview-1631881734
   ✔  - Franziska Hinkelmann (@fhinkel) (TSC): https://github.com/nodejs/node/pull/49706#pullrequestreview-1632218574
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/49706#pullrequestreview-1632662147
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/49706#pullrequestreview-1632747668
   ✘  Last GitHub CI failed
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6254106051
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RafaelGSS
RafaelGSS approved these changes Sep 21, 2023
View reviewed changes
@benjamingr benjamingr added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Sep 21, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Sep 21, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 21, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/49706
✔  Done loading data for nodejs/node/pull/49706
----------------------------------- PR info ------------------------------------
Title      meta: add primordials strategic initiative  (#49706)
Author     Benjamin Gruenbaum  (@benjamingr)
Branch     benjamingr:add-primordials-strategic-initiatiive -> nodejs:main
Labels     doc, commit-queue-squash
Commits    2
 - Update strategic-initiatives.md
 - fixup: update link
Committers 1
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/49706
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Matteo Collina 
Reviewed-By: Moshe Atlow 
Reviewed-By: Franziska Hinkelmann 
Reviewed-By: Michaël Zasso 
Reviewed-By: Tobias Nießen 
Reviewed-By: Rafael Gonzaga 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49706
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Matteo Collina 
Reviewed-By: Moshe Atlow 
Reviewed-By: Franziska Hinkelmann 
Reviewed-By: Michaël Zasso 
Reviewed-By: Tobias Nießen 
Reviewed-By: Rafael Gonzaga 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 18 Sep 2023 17:56:58 GMT
   ✔  Approvals: 7
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/49706#pullrequestreview-1631839626
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/49706#pullrequestreview-1631852567
   ✔  - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/49706#pullrequestreview-1631881734
   ✔  - Franziska Hinkelmann (@fhinkel) (TSC): https://github.com/nodejs/node/pull/49706#pullrequestreview-1632218574
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/49706#pullrequestreview-1632662147
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/49706#pullrequestreview-1632747668
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/49706#pullrequestreview-1638400077
   ✘  Last GitHub CI failed
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6265913467
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 merged commit 2e4e1e1 into main Sep 21, 2023
@aduh95
aduh95 deleted the add-primordials-strategic-initiatiive branch September 21, 2023 19:19
@aduh95

aduh95 commented Sep 21, 2023

Copy link
Copy Markdown
Contributor

Landed in 2e4e1e1
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig

anonrig commented Sep 21, 2023

Copy link
Copy Markdown
Member

This broke main

Running JS linter...
Running Markdown linter...
Using release list from env...
doc/contributing/strategic-initiatives.md is not formatted. Please run 'make format-md'.
doc/contributing/strategic-initiatives.md
19:60      warning Cell should be padded                                        table-cell-padding remark-lint
49:1-49:44 warning Unordered reference ("benjamingr" should be before "targos") nodejs-links       remark-lint

⚠ 2 warnings
make: *** [Makefile:1333: tools/.mdlintstamp] Error 1
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@benjamingr @ruyadorno
meta: add primordials strategic initiative
58f7a9e 
PR-URL: #49706
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Sep 28, 2023
v20.7.1 proposal #49917
Closed
@ruyadorno ruyadorno mentioned this pull request Sep 28, 2023
v20.8.0 proposal #49932
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
@benjamingr @targos
meta: add primordials strategic initiative
dc70c44 
PR-URL: #49706
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
v18.19.0 release proposal #50953
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
meta: add primordials strategic initiative
a13036d 
PR-URL: nodejs/node#49706
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
meta: add primordials strategic initiative
9e0d629 
PR-URL: nodejs/node#49706
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joyeecheung joyeecheung joyeecheung left review comments
@mcollina mcollina mcollina approved these changes
@anonrig anonrig anonrig approved these changes
@tniessen tniessen tniessen approved these changes
@MoLow MoLow MoLow approved these changes
@RafaelGSS RafaelGSS RafaelGSS approved these changes
+2 more reviewers
@fhinkel fhinkel fhinkel approved these changes
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. commit-queue-squash PRs the Commit Queue should land as one squashed commit. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

11 participants

@benjamingr @nodejs-github-bot @aduh95 @anonrig @mcollina @fhinkel @targos @tniessen @joyeecheung @MoLow @RafaelGSS
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.