GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: update output of example in `mimeParams.set()` by deokjinkim · Pull Request #49718 · nodejs/node

Conversation

@deokjinkim

@deokjinkim deokjinkim commented Sep 19, 2023

Copy link
Copy Markdown
Contributor

Actual output of example in mimeParams.set() is mismatched.
So update output of example in mimeParams.set().

Expected output:

foo=def&bar=1&baz=xyz

Actual output:

foo=def;bar=1;baz=xyz

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@deokjinkim
doc: update output of example in mimeParams.set()
68b81c9 
Actual output of example in `mimeParams.set()` is mismatched.
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. util Issues and PRs related to the built-in util module. labels Sep 19, 2023
KhafraDev
KhafraDev approved these changes Sep 20, 2023
View reviewed changes
@deokjinkim deokjinkim added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Sep 20, 2023
aymen94
aymen94 approved these changes Sep 20, 2023
View reviewed changes
lpinca
lpinca approved these changes Sep 20, 2023
View reviewed changes
@deokjinkim deokjinkim added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 21, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 21, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 05ebb8e into nodejs:main Sep 21, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 21, 2023

Copy link
Copy Markdown
Collaborator

Landed in 05ebb8e
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@deokjinkim @ruyadorno
doc: update output of example in mimeParams.set()
fe78a34 
Actual output of example in `mimeParams.set()` is mismatched.

PR-URL: #49718
Reviewed-By: Matthew Aitken <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
This was referenced Sep 28, 2023
v20.7.1 proposal #49917
Closed
v20.8.0 proposal #49932
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@KhafraDev KhafraDev KhafraDev approved these changes
+1 more reviewer
@aymen94 aymen94 aymen94 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@deokjinkim @nodejs-github-bot @lpinca @aymen94 @KhafraDev
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.