GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: add missing function call to example for `util.promisify` by pluris · Pull Request #49719 · nodejs/node

Conversation

@pluris

@pluris pluris commented Sep 19, 2023

Copy link
Copy Markdown
Contributor

The function call was missed from the example of the async function in util.promisify, so it was added.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
pluris
doc: add missing function call to example for util.promisify
7c4f1fd
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. util Issues and PRs related to the built-in util module. labels Sep 19, 2023
MoLow
MoLow approved these changes Sep 19, 2023
View reviewed changes
deokjinkim
deokjinkim approved these changes Sep 20, 2023
View reviewed changes
@deokjinkim deokjinkim added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Sep 20, 2023
aymen94
aymen94 approved these changes Sep 20, 2023
View reviewed changes
lpinca
lpinca approved these changes Sep 20, 2023
View reviewed changes
trivikr
trivikr approved these changes Sep 20, 2023
View reviewed changes
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 21, 2023
@nodejs-github-bot
nodejs-github-bot merged commit fa74158 into nodejs:main Sep 21, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 21, 2023

Copy link
Copy Markdown
Collaborator

Landed in fa74158
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
Jungku Lee @ruyadorno
doc: add missing function call to example for util.promisify
774c1cf 
PR-URL: #49719
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Deokjin Kim <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
This was referenced Sep 28, 2023
v20.7.1 proposal #49917
Closed
v20.8.0 proposal #49932
Merged
@pluris
pluris deleted the fix/missing_call_doc branch November 8, 2023 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@deokjinkim deokjinkim deokjinkim approved these changes
@MoLow MoLow MoLow approved these changes
@trivikr trivikr trivikr approved these changes
+1 more reviewer
@aymen94 aymen94 aymen94 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@pluris @nodejs-github-bot @lpinca @deokjinkim @MoLow @aymen94 @trivikr
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.