GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||
GeezerVison is showing github.com — lib: faster internal createBlob by H4ad · Pull Request #49730 · nodejs/node Conversation
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
I'm happy to see my PR inspired this 😀 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Benchmark CI https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1402/ |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
It looks like the benchmark CI was stuck (nothing changed for 8 hours) https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1406/ |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@rluvaton Can you cancel and start again? I lowered the values of the benchmark for |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Done https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1407/ |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
This piece of code: const buff = Buffer.allocUnsafe(1024 ** 2); const source = new File(buff, 'dummy.txt', options); const now = performance.now(); source.text().then(() => console.log(`diff: ${performance.now() - now}`)); Takes 3s to run, and running 1e3 will take a looong time, I will update the benchmark again, sorry for that. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Landed in 328bdac...1a839f3 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
PR-URL: #49730 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Stephen Belanger <[email protected]>
PR-URL: #49730 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Stephen Belanger <[email protected]>
PR-URL: #49730 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Stephen Belanger <[email protected]>
|
@anonrig FWIW, none of the three commits that were merged here adhere to our commit message guidelines. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Is this a bug with node-core-utils? It seems we shouldn't even land commit that adhere. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Reviewing the commit message is the burden of the PR author and the reviewers, NCU can only catch a subset of commit message "violation" – in this case, it would be very hard for NCU to guess that |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
The problem is that the length of the first commit message was reported to be too long. So something should have errored like when you dont prefix the First commit message with |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
PR-URL: #49730 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Stephen Belanger <[email protected]>
PR-URL: #49730 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Stephen Belanger <[email protected]>
PR-URL: nodejs#49730 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Stephen Belanger <[email protected]>
PR-URL: nodejs#49730 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Stephen Belanger <[email protected]>
PR-URL: nodejs#49730 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Zeyu "Alex" Yang <[email protected]> Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Stephen Belanger <[email protected]>
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.