GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — deps: remove pthread-fixes.c from uv.gyp by bnoordhuis · Pull Request #49744 · nodejs/node

Conversation

@bnoordhuis

@bnoordhuis bnoordhuis commented Sep 21, 2023

Copy link
Copy Markdown
Member

The file was removed in the latest libuv upgrade. Remove it from the build recipe as well.

Fixes: #49739

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bnoordhuis
deps: remove pthread-fixes.c from uv.gyp
56c8dfb 
The file was removed in the latest libuv upgrade. Remove it from the
build recipe as well.

Fixes: nodejs#49739
@nodejs-github-bot

nodejs-github-bot commented Sep 21, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added libuv Issues and PRs related to the libuv dependency or the uv binding. needs-ci PRs that need a full CI run. labels Sep 21, 2023
@bnoordhuis bnoordhuis mentioned this pull request Sep 21, 2023
Android build failed #49739
Closed
RaisinTen
RaisinTen approved these changes Sep 21, 2023
View reviewed changes
debadree25
debadree25 approved these changes Sep 21, 2023
View reviewed changes
@debadree25 debadree25 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Sep 21, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 21, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54113/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cjihrig
cjihrig approved these changes Sep 21, 2023
View reviewed changes
richardlau
richardlau approved these changes Sep 21, 2023
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Sep 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54122/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richardlau richardlau added the lts-watch-v18.x label Sep 21, 2023
gengjiawen
gengjiawen approved these changes Sep 21, 2023
View reviewed changes
tniessen
tniessen approved these changes Sep 21, 2023
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Sep 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54126/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Sep 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54131/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Sep 21, 2023
View reviewed changes
santigimeno
santigimeno approved these changes Sep 21, 2023
View reviewed changes

@santigimeno santigimeno left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. Thanks for fixing this

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@richardlau richardlau added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 21, 2023
This was referenced Sep 22, 2023
CI Reliability 2023-09-22 nodejs/reliability#673
Open
CI Reliability 2023-09-23 nodejs/reliability#674
Open
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 23, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 914ad2f into nodejs:main Sep 23, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 23, 2023

Copy link
Copy Markdown
Collaborator

Landed in 914ad2f
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Sep 24, 2023
CI Reliability 2023-09-24 nodejs/reliability#675
Open
20 tasks
ruyadorno pushed a commit that referenced this pull request Sep 28, 2023
@bnoordhuis @ruyadorno
deps: remove pthread-fixes.c from uv.gyp
b8a4fef 
The file was removed in the latest libuv upgrade. Remove it from the
build recipe as well.

Fixes: #49739
PR-URL: #49744
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Sep 28, 2023
v20.7.1 proposal #49917
Closed
@ruyadorno ruyadorno mentioned this pull request Sep 28, 2023
v20.8.0 proposal #49932
Merged
@richardlau richardlau removed the lts-watch-v18.x label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@santigimeno santigimeno santigimeno approved these changes
@lpinca lpinca lpinca approved these changes
@cjihrig cjihrig cjihrig approved these changes
@tniessen tniessen tniessen approved these changes
@gengjiawen gengjiawen gengjiawen approved these changes
@richardlau richardlau richardlau approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes
+1 more reviewer
@debadree25 debadree25 debadree25 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. libuv Issues and PRs related to the libuv dependency or the uv binding. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Android build failed

Uh oh!

There was an error while loading. Please reload this page.

10 participants

@bnoordhuis @nodejs-github-bot @santigimeno @lpinca @cjihrig @tniessen @gengjiawen @richardlau @debadree25 @RaisinTen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.