GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — doc: updated building docs for windows by ovflowd · Pull Request #49767 · nodejs/node

Conversation

ovflowd commented Sep 22, 2023

Copy link

Copy Markdown

Member

This PR updates the Windows Building Instructions and the Boxstarter Automated Installation Script due to the following:

The vcbuild.bat will require Python3 to be installed, but on Windows, if Python 2 is installed, it will take precedence over the $PATH; also, Python2 is not needed for Node.js builds anymore.
If installed on ARM64, the recommended packages are incompatible. ARM64 compatibility was added with Visual Studio 2022 (17.4.0 or higher)
- Updated the scripts to use VS2022 Chocolatey Packages
- Updated the Building docs to use the newest Visual Studio Packages (which are compatible with Windows 10 and Windows 11)
Updated Docs to clarify that folks should first clone the repository and head to the cloned directory. A bunch of newcomers on Grace Hopper were confused about this.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

benjamingr reacted with thumbs up emoji

All reactions

👍 1 reaction

Claudio Wunder added 2 commits

September 22, 2023 20:22


          doc: updated building docs for windows

677236e


          tools: updated boxstarter script

4b9f5c8

nodejs-github-bot added build

Issues and PRs related to Node.js builds or CI infrastructure.

doc

Issues and PRs related to Node.js documentation.

tools Issues and PRs related to the tools directory. labels

Sep 22, 2023

This comment was marked as outdated.

Claudio Wunder added 2 commits

September 22, 2023 20:43


          doc: fix building.md style

be9c947


          doc: max 80 chars per line

5fe9f42

Trott commented Sep 22, 2023

Copy link

Copy Markdown

Member

@nodejs/platform-windows @nodejs/build

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JakobJingleheimer approved these changes

Sep 22, 2023

View reviewed changes

Comment thread

BUILDING.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

lpinca approved these changes

Sep 23, 2023

View reviewed changes

RafaelGSS reviewed

Sep 24, 2023

View reviewed changes

Comment thread

BUILDING.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

richardlau approved these changes

Sep 25, 2023

View reviewed changes

richardlau commented Sep 25, 2023

Copy link

Copy Markdown

Member

This PR updates the Windows Building Instructions and the Boxstarter Automated Installation Script due to the following:
* If installed on ARM64, the recommended packages are incompatible. ARM64 compatibility was added with Visual Studio 2022 (17.4.0 or higher)

FYI @nodejs/platform-windows-arm Do these changes look good to you?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

RafaelGSS approved these changes

Sep 26, 2023

View reviewed changes

targos reviewed

Sep 26, 2023

View reviewed changes

targos left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestions based on https://github.com/nodejs/node/pull/49051/files

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

BUILDING.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

BUILDING.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

BUILDING.md Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

tools/bootstrap/windows_boxstarter Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Apply suggestions from code review

524159a

Co-authored-by: Michaël Zasso <[email protected]>

aymen94 approved these changes

Sep 29, 2023

View reviewed changes

ovflowd added commit-queue

PRs queued for automated landing through the Commit Queue.

commit-queue-squash

PRs the Commit Queue should land as one squashed commit.

commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. labels

Sep 29, 2023

nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels

Sep 29, 2023

This comment was marked as resolved.

ovflowd added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-rebase

PRs the Commit Queue should land as multiple self-contained commits.

commit-queue-squash

PRs the Commit Queue should land as one squashed commit.

commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels

Sep 29, 2023

This comment was marked as resolved.

This comment was marked as outdated.

This comment was marked as resolved.

ovflowd force-pushed the doc-updates-windows-install branch from 775caf0 to 524159a Compare

October 1, 2023 09:22

ovflowd added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels

Oct 1, 2023

This comment has been minimized.

ovflowd commented Oct 1, 2023

Copy link

Copy Markdown

Member Author

Can someone reapprove the PR? Apparently node land is failing due last commit not having an approval

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ovflowd removed the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label

Oct 1, 2023

ovflowd requested a review from targos

October 1, 2023 13:55

MoLow approved these changes

Oct 1, 2023

View reviewed changes

MoLow added the commit-queue PRs queued for automated landing through the Commit Queue. label

Oct 1, 2023

ovflowd added the commit-queue-squash PRs the Commit Queue should land as one squashed commit. label

Oct 1, 2023

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label

Oct 1, 2023

nodejs-github-bot merged commit 47b2883 into nodejs:main

Oct 1, 2023

nodejs-github-bot commented Oct 1, 2023

Copy link

Copy Markdown

Collaborator

Landed in 47b2883

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ovflowd deleted the doc-updates-windows-install branch

October 1, 2023 14:46

RafaelGSS mentioned this pull request

Oct 9, 2023

2023-10-17, Version 21.0.0 (Current) #49870

Merged

targos pushed a commit that referenced this pull request

Nov 11, 2023


          doc: updated building docs for windows

f63a92b

PR-URL: #49767
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>

targos mentioned this pull request

Nov 12, 2023

v20.10.0 release proposal #50682

Merged

juanarbol mentioned this pull request

Dec 6, 2023

2023-12-06, N|Solid v5.0.1 Iron Release nodesource/nsolid#41

Merged

debadree25 pushed a commit to debadree25/node that referenced this pull request

Apr 15, 2024


          doc: updated building docs for windows

PR-URL: nodejs#49767
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>

Reviewers

lpinca

lpinca approved these changes

JakobJingleheimer

JakobJingleheimer approved these changes

richardlau

richardlau approved these changes

MoLow

MoLow approved these changes

RafaelGSS

RafaelGSS approved these changes

targos

Awaiting requested review from targos

+1 more reviewer

aymen94

aymen94 approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

build

Issues and PRs related to Node.js builds or CI infrastructure.

commit-queue-squash

PRs the Commit Queue should land as one squashed commit.

doc

Issues and PRs related to Node.js documentation.

tools

Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

10 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.