GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: replace forEach() with for ... of loop in test-global.js for enhanced… by shizuka1308 · Pull Request #49772 · nodejs/node

Conversation

@shizuka1308

@shizuka1308 shizuka1308 commented Sep 22, 2023

Copy link
Copy Markdown
Contributor

Replace forEach() with for ... of in test-global.js

Grace Hopper Day - pull request to replace forEach.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Sep 22, 2023
RafaelGSS
RafaelGSS reviewed Sep 22, 2023
View reviewed changes

@RafaelGSS RafaelGSS left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, could you please adjust the commit message? It must contain the namespace, in your case, test. Therefore, the new message should be:

test: replace forEach() with for .. loop in test-global.js

you can do this by running:

git commit --amend -> adjust your message
git push -f origin kajol-ghc

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
shizuka1308
test: replace forEach() with for ... of loop in test-global.js
c5bb83f
@shizuka1308
shizuka1308 force-pushed the kajol-ghc branch from f23a7cc to c5bb83f Compare September 22, 2023 19:06
@RafaelGSS RafaelGSS changed the title replace forEach() with for ... of loop in test-global.js for enhanced… test: replace forEach() with for ... of loop in test-global.js for enhanced… Sep 22, 2023
@tniessen tniessen added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Sep 22, 2023
@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 24, 2023
RafaelGSS
RafaelGSS approved these changes Sep 24, 2023
View reviewed changes
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 24, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 24, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54196/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
trivikr
trivikr approved these changes Sep 25, 2023
View reviewed changes
@github-actions github-actions Bot mentioned this pull request Sep 27, 2023
CI Reliability 2023-09-27 nodejs/reliability#676
Open
21 tasks
@nodejs-github-bot

nodejs-github-bot commented Oct 9, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54628/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Oct 23, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55141/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Oct 24, 2023
CI Reliability 2023-10-24 nodejs/reliability#696
Open
CI Reliability 2023-10-25 nodejs/reliability#697
Open
@nodejs-github-bot

nodejs-github-bot commented Oct 25, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55212/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Oct 28, 2023
View reviewed changes
@RafaelGSS RafaelGSS added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 7, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 7, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 5e3217c into nodejs:main Nov 7, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 7, 2023

Copy link
Copy Markdown
Collaborator

Landed in 5e3217c
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request Nov 11, 2023
@shizuka1308 @targos
test: replace forEach() with for ... of loop in test-global.js
cbeda55 
PR-URL: #49772
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
v21.2.0 release proposal #50681
Merged
targos pushed a commit that referenced this pull request Nov 14, 2023
@shizuka1308 @targos
test: replace forEach() with for ... of loop in test-global.js
7c7be51 
PR-URL: #49772
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@shizuka1308 @UlisesGascon
test: replace forEach() with for ... of loop in test-global.js
7cacddf 
PR-URL: #49772
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
v20.11.0 proposal #51124
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@trivikr trivikr trivikr approved these changes
@RafaelGSS RafaelGSS RafaelGSS approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@shizuka1308 @nodejs-github-bot @jasnell @trivikr @RafaelGSS @tniessen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.