GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: change forEach to for...of by tifflastimosa · Pull Request #49799 · nodejs/node

Conversation

@tifflastimosa

@tifflastimosa tifflastimosa commented Sep 22, 2023

Copy link
Copy Markdown
Contributor

Changed for each loop to for of loop in test-assert.js

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@tifflastimosa
test: change forEach to for...of
e6123a1
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Sep 22, 2023
@tniessen tniessen added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Sep 23, 2023
tniessen
tniessen approved these changes Sep 23, 2023
View reviewed changes
Comment thread test/parallel/test-assert.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

@tniessen
Update test/parallel/test-assert.js
e097d4a
tniessen
tniessen approved these changes Sep 24, 2023
View reviewed changes
lpinca
lpinca approved these changes Sep 24, 2023
View reviewed changes
trivikr
trivikr approved these changes Sep 25, 2023
View reviewed changes
@tniessen tniessen added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 25, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 25, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 25, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54213/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tniessen tniessen added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Sep 25, 2023
This was referenced Sep 27, 2023
CI Reliability 2023-09-27 nodejs/reliability#676
Open
CI Reliability 2023-09-28 nodejs/reliability#677
Open
@nodejs-github-bot

nodejs-github-bot commented Sep 29, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54364/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 30, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Sep 30, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 30, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/49799
✔  Done loading data for nodejs/node/pull/49799
----------------------------------- PR info ------------------------------------
Title      test: change forEach to for...of (#49799)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     tifflastimosa:tl-branch -> nodejs:main
Labels     test, code-and-learn, author ready, needs-ci
Commits    2
 - test: change forEach to for...of
 - Update test/parallel/test-assert.js
Committers 2
 - tifflastimosa 
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/49799
Reviewed-By: Tobias Nießen 
Reviewed-By: Luigi Pinca 
Reviewed-By: Trivikram Kamat 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49799
Reviewed-By: Tobias Nießen 
Reviewed-By: Luigi Pinca 
Reviewed-By: Trivikram Kamat 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 22 Sep 2023 23:56:00 GMT
   ✔  Approvals: 3
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/49799#pullrequestreview-1641043958
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/49799#pullrequestreview-1641117127
   ✔  - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/49799#pullrequestreview-1641217111
   ℹ  This PR is being fast-tracked because it is from a Code and Learn event
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-09-29T11:15:32Z: https://ci.nodejs.org/job/node-test-pull-request/54364/
- Querying data for job/node-test-pull-request/54364/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
   b903a710f4..0ee9c83ffc  main       -> origin/main
✔  origin/main is now up-to-date
main is out of sync with origin/main. Mismatched commits:
 - b5aacf8028 errors: improve performance of determine-specific-type
 - 0ee9c83ffc errors: improve performance of determine-specific-type
--------------------------------------------------------------------------------
HEAD is now at 0ee9c83ffc errors: improve performance of determine-specific-type
   ✔  Reset to origin/main
- Downloading patch for 49799
From https://github.com/nodejs/node
 * branch                  refs/pull/49799/merge -> FETCH_HEAD
✔  Fetched commits as 0ee9c83ffcce..e097d4a79e3c
--------------------------------------------------------------------------------
[main 41665b5b90] test: change forEach to for...of
 Author: tifflastimosa 
 Date: Fri Sep 22 16:08:12 2023 -0700
 1 file changed, 6 insertions(+), 9 deletions(-)
[main 7e8934c17f] Update test/parallel/test-assert.js
 Author: Tobias Nießen 
 Date: Sun Sep 24 14:14:16 2023 +0200
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
test: change forEach to for...of

PR-URL: #49799
Reviewed-By: Tobias Nießen [email protected]
Reviewed-By: Luigi Pinca [email protected]
Reviewed-By: Trivikram Kamat [email protected]

[detached HEAD c0f88eb608] test: change forEach to for...of
Author: tifflastimosa [email protected]
Date: Fri Sep 22 16:08:12 2023 -0700
1 file changed, 6 insertions(+), 9 deletions(-)
Rebasing (3/4)
Rebasing (4/4)

Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update test/parallel/test-assert.js

PR-URL: #49799
Reviewed-By: Tobias Nießen [email protected]
Reviewed-By: Luigi Pinca [email protected]
Reviewed-By: Trivikram Kamat [email protected]

[detached HEAD 0d2fcbd12b] Update test/parallel/test-assert.js
Author: Tobias Nießen [email protected]
Date: Sun Sep 24 14:14:16 2023 +0200
1 file changed, 1 insertion(+), 1 deletion(-)

Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/6365784738

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@aduh95 aduh95 added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Oct 6, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 6, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 42c37f2 into nodejs:main Oct 6, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 6, 2023

Copy link
Copy Markdown
Collaborator

Landed in 42c37f2

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@RafaelGSS RafaelGSS mentioned this pull request Oct 9, 2023
2023-10-17, Version 21.0.0 (Current) #49870
Merged
targos pushed a commit that referenced this pull request Nov 11, 2023
@tifflastimosa @targos
test: change forEach to for...of
4c58b92
PR-URL: #49799
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
v20.10.0 release proposal #50682
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
2023-12-06, N|Solid v5.0.1 Iron Release nodesource/nsolid#41
Merged
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
@tifflastimosa @debadree25
test: change forEach to for...of
cb854ac
PR-URL: nodejs#49799
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@tniessen tniessen tniessen approved these changes
@trivikr trivikr trivikr approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. commit-queue-squash PRs the Commit Queue should land as one squashed commit. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@tifflastimosa @nodejs-github-bot @lpinca @tniessen @trivikr @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.