GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: replace forEach with for..of in test-fs-realpath-buffer-encoding by niyashiyas · Pull Request #49804 · nodejs/node

Conversation

@niyashiyas

@niyashiyas niyashiyas commented Sep 23, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Replaced forEach with for..of in test-fs-realpath-buffer-encoding.js

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Sep 23, 2023
@niyashiyas

niyashiyas commented Sep 23, 2023

Copy link
Copy Markdown
Contributor Author

Changed file test-fs-realpath-buffer-encoding.js
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tniessen tniessen added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Sep 23, 2023
tniessen
tniessen reviewed Sep 23, 2023
View reviewed changes
Comment thread test/parallel/test-fs-realpath-buffer-encoding.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@niyashiyas

niyashiyas commented Sep 24, 2023

Copy link
Copy Markdown
Contributor Author

I've made the required changes. Please review again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
trivikr
trivikr approved these changes Sep 25, 2023
View reviewed changes
tniessen
tniessen approved these changes Sep 25, 2023
View reviewed changes
@tniessen tniessen added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 25, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 25, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 25, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54212/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Sep 27, 2023
CI Reliability 2023-09-27 nodejs/reliability#676
Open
CI Reliability 2023-09-28 nodejs/reliability#677
Open
@niyashiyas
test: replace forEach with for..of in test-fs-realpath-buffer-encoding
19d6568
@niyashiyas
niyashiyas force-pushed the test-fs-realpath branch from 11ee8cc to 13fb7dc Compare September 30, 2023 10:57
niyashiyas added 2 commits September 30, 2023 17:54
@niyashiyas
test: replace forEach with for..of in test-fs-readv.js
0c58e20
@niyashiyas
test: replace forEach with for..of in test-fs-realpath-buffer-encoding
af311e7
@niyashiyas
niyashiyas force-pushed the test-fs-realpath branch from 13fb7dc to af311e7 Compare September 30, 2023 12:24
@lpinca lpinca added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Oct 21, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 21, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55081/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lpinca lpinca added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 21, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 21, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 21, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/49804
✔  Done loading data for nodejs/node/pull/49804
----------------------------------- PR info ------------------------------------
Title      test: replace forEach with  for..of in test-fs-realpath-buffer-encoding (#49804)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     niyashiyas:test-fs-realpath -> nodejs:main
Labels     test, code-and-learn, needs-ci, commit-queue-squash
Commits    3
 - test: replace forEach with for..of in test-fs-realpath-buffer-encoding
 - test: replace forEach with for..of in test-fs-readv.js
 - test: replace forEach with for..of in test-fs-realpath-buffer-encoding
Committers 1
 - Niya Shiyas 
PR-URL: https://github.com/nodejs/node/pull/49804
Reviewed-By: Trivikram Kamat 
Reviewed-By: Tobias Nießen 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49804
Reviewed-By: Trivikram Kamat 
Reviewed-By: Tobias Nießen 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - test: replace forEach with for..of in test-fs-realpath-buffer-encoding
   ⚠  - test: replace forEach with for..of in test-fs-readv.js
   ⚠  - test: replace forEach with for..of in test-fs-realpath-buffer-encoding
   ℹ  This PR was created on Sat, 23 Sep 2023 06:14:31 GMT
   ✔  Approvals: 2
   ✔  - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/49804#pullrequestreview-1641281338
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/49804#pullrequestreview-1642000311
   ℹ  This PR is being fast-tracked because it is from a Code and Learn event
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2023-10-21T04:56:27Z: https://ci.nodejs.org/job/node-test-pull-request/55081/
- Querying data for job/node-test-pull-request/55081/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6597965086
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ZYSzys
ZYSzys approved these changes Oct 22, 2023
View reviewed changes
jasnell
jasnell approved these changes Oct 28, 2023
View reviewed changes
lpinca pushed a commit that referenced this pull request Nov 2, 2023
@niyashiyas @lpinca
test: replace forEach with for...of in test-fs-realpath-buffer-encoding
a1693c6 
PR-URL: #49804
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@lpinca

lpinca commented Nov 2, 2023

Copy link
Copy Markdown
Member

Landed in a1693c6.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lpinca lpinca closed this Nov 2, 2023
targos pushed a commit that referenced this pull request Nov 11, 2023
@niyashiyas @targos
test: replace forEach with for...of in test-fs-realpath-buffer-encoding
6868d4e 
PR-URL: #49804
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
v21.2.0 release proposal #50681
Merged
targos pushed a commit that referenced this pull request Nov 14, 2023
@niyashiyas @targos
test: replace forEach with for...of in test-fs-realpath-buffer-encoding
d24de12 
PR-URL: #49804
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@niyashiyas @UlisesGascon
test: replace forEach with for...of in test-fs-realpath-buffer-encoding
9dc63c5 
PR-URL: #49804
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
v20.11.0 proposal #51124
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@tniessen tniessen tniessen approved these changes
@trivikr trivikr trivikr approved these changes
@ZYSzys ZYSzys ZYSzys approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. commit-queue-squash PRs the Commit Queue should land as one squashed commit. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@niyashiyas @nodejs-github-bot @lpinca @jasnell @tniessen @trivikr @ZYSzys
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.