GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: replace forEach with for..of in test-net-isipv6.js by niyashiyas · Pull Request #49823 · nodejs/node

Conversation

@niyashiyas

@niyashiyas niyashiyas commented Sep 23, 2023

Copy link
Copy Markdown
Contributor

Replaced forEach with for..of in test-net-isipv6.js

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Sep 23, 2023
@tniessen tniessen added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Sep 23, 2023
tniessen
tniessen reviewed Sep 23, 2023
View reviewed changes
Comment thread test/parallel/test-net-isipv6.js Outdated

@tniessen tniessen Sep 23, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
};
}

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@niyashiyas niyashiyas Sep 24, 2023

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made required changes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread test/parallel/test-net-isipv6.js Outdated

@tniessen tniessen Sep 23, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
};
}

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@niyashiyas niyashiyas Sep 24, 2023

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made required changes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@niyashiyas

niyashiyas commented Sep 24, 2023

Copy link
Copy Markdown
Contributor Author

Please review this again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
niyashiyas added 2 commits September 30, 2023 17:28
@niyashiyas
test: replace forEach with for..of in test-net-isipv6.js
86bdd2a
@niyashiyas
test: replace forEach with for..of in test-net-isipv6.js
2458e27
@niyashiyas niyashiyas changed the title test: Replaced forEach with for..of in test-net-isipv6.js test: replace forEach with for..of in test-net-isipv6.js Sep 30, 2023
@niyashiyas
niyashiyas force-pushed the test-7 branch from 5b6409f to 2458e27 Compare September 30, 2023 12:00
lpinca
lpinca approved these changes Oct 7, 2023
View reviewed changes
Comment thread test/parallel/test-net-isipv6.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/parallel/test-net-isipv6.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
lpinca added 2 commits October 7, 2023 11:52
@lpinca
Update test/parallel/test-net-isipv6.js
51fd40e
@lpinca
Update test/parallel/test-net-isipv6.js
704b321
@lpinca lpinca added commit-queue-squash PRs the Commit Queue should land as one squashed commit. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Oct 7, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 7, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
This was referenced Oct 8, 2023
CI Reliability 2023-10-08 nodejs/reliability#687
Open
CI Reliability 2023-10-09 nodejs/reliability#688
Open
@nodejs-github-bot

nodejs-github-bot commented Oct 9, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54630/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Oct 10, 2023
CI Reliability 2023-10-10 nodejs/reliability#689
Open
CI Reliability 2023-10-11 nodejs/reliability#690
Open
@lpinca lpinca added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 13, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 13, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 13, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/49823
✔  Done loading data for nodejs/node/pull/49823
----------------------------------- PR info ------------------------------------
Title      test: replace forEach with for..of in test-net-isipv6.js (#49823)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     niyashiyas:test-7 -> nodejs:main
Labels     test, code-and-learn, needs-ci, commit-queue-squash
Commits    4
 - test: replace forEach with for..of in test-net-isipv6.js
 - test: replace forEach with for..of in test-net-isipv6.js
 - Update test/parallel/test-net-isipv6.js
 - Update test/parallel/test-net-isipv6.js
Committers 2
 - Niya Shiyas 
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/49823
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49823
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - Update test/parallel/test-net-isipv6.js
   ⚠  - Update test/parallel/test-net-isipv6.js
   ℹ  This PR was created on Sat, 23 Sep 2023 08:56:26 GMT
   ✔  Approvals: 1
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/49823#pullrequestreview-1663033007
   ℹ  This PR is being fast-tracked because it is from a Code and Learn event
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-10-09T13:17:19Z: https://ci.nodejs.org/job/node-test-pull-request/54630/
- Querying data for job/node-test-pull-request/54630/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6509223254
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca pushed a commit that referenced this pull request Oct 13, 2023
@niyashiyas @lpinca
test: replace forEach with for..of in test-net-isipv6.js
41e4174 
PR-URL: #49823
Reviewed-By: Luigi Pinca <[email protected]>
@lpinca

lpinca commented Oct 13, 2023

Copy link
Copy Markdown
Member

Landed in 41e4174.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lpinca lpinca closed this Oct 13, 2023
@RafaelGSS RafaelGSS mentioned this pull request Oct 15, 2023
2023-10-17, Version 21.0.0 (Current) #49870
Merged
targos pushed a commit that referenced this pull request Nov 11, 2023
@niyashiyas @targos
test: replace forEach with for..of in test-net-isipv6.js
1cf3f8d 
PR-URL: #49823
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
v20.10.0 release proposal #50682
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
2023-12-06, N|Solid v5.0.1 Iron Release nodesource/nsolid#41
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tniessen tniessen tniessen left review comments
@lpinca lpinca lpinca approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. commit-queue-squash PRs the Commit Queue should land as one squashed commit. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@niyashiyas @nodejs-github-bot @lpinca @tniessen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.