GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: replace forEach with for..of in test-http-url by niyashiyas · Pull Request #49840 · nodejs/node

Conversation

@niyashiyas

@niyashiyas niyashiyas commented Sep 24, 2023

Copy link
Copy Markdown
Contributor

Replaced forEach with for in test-http-url.parse-only-support-http-https-protocol.js

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Sep 24, 2023
@tniessen tniessen added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Sep 24, 2023
@benjamingr

benjamingr commented Sep 24, 2023

Copy link
Copy Markdown
Member

Hi @niyashiyas note that code and learn issues are usually preferably "one or a few per participant", you've opened 23. I thank you for your help and appreciate your enthusiasm but think it would be preferable to focus on addressing the issues on your other PRs until they land.
tniessen reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@benjamingr

benjamingr commented Sep 24, 2023

Copy link
Copy Markdown
Member

To explain these are issues/ideas specifically picked in order to get someone acquainted with the process of contributing to Node.js.

Each one you make creates work for project members who need to view the code, run benchmarks and track it.
tniessen and niyashiyas reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
niyashiyas added 2 commits September 30, 2023 17:48
@niyashiyas
test: replace forEach with for..of in test-http-url
8ae0b25
@niyashiyas
test: replace forEach with for..of in test-http-url
087fd13
@niyashiyas
niyashiyas force-pushed the test-10 branch from 8e7e48f to 087fd13 Compare September 30, 2023 12:20
@niyashiyas niyashiyas changed the title test: replaced forEach with for..of in test-http-url test: replace forEach with for..of in test-http-url Sep 30, 2023
lpinca
lpinca approved these changes Oct 6, 2023
View reviewed changes
@lpinca lpinca added commit-queue-squash PRs the Commit Queue should land as one squashed commit. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Oct 6, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 6, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 6, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54586/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Oct 7, 2023
CI Reliability 2023-10-07 nodejs/reliability#686
Open
19 tasks
@nodejs-github-bot

nodejs-github-bot commented Oct 7, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54592/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lpinca lpinca added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 7, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 7, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 7, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/49840
✔  Done loading data for nodejs/node/pull/49840
----------------------------------- PR info ------------------------------------
Title      test: replace forEach with for..of in test-http-url (#49840)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     niyashiyas:test-10 -> nodejs:main
Labels     test, code-and-learn, needs-ci, commit-queue-squash
Commits    2
 - test: replace forEach with for..of in test-http-url
 - test: replace forEach with for..of in test-http-url
Committers 1
 - Niya Shiyas 
PR-URL: https://github.com/nodejs/node/pull/49840
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49840
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 24 Sep 2023 10:12:56 GMT
   ✔  Approvals: 1
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/49840#pullrequestreview-1662401958
   ℹ  This PR is being fast-tracked because it is from a Code and Learn event
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2023-10-07T05:17:43Z: https://ci.nodejs.org/job/node-test-pull-request/54592/
- Querying data for job/node-test-pull-request/54592/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6440454179
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca pushed a commit that referenced this pull request Oct 7, 2023
@niyashiyas @lpinca
test: replace forEach with for..of in test-http-url
2449247 
PR-URL: #49840
Reviewed-By: Luigi Pinca <[email protected]>
@lpinca

lpinca commented Oct 7, 2023

Copy link
Copy Markdown
Member

Landed in 2449247.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lpinca lpinca closed this Oct 7, 2023
This was referenced Oct 8, 2023
CI Reliability 2023-10-08 nodejs/reliability#687
Open
CI Reliability 2023-10-09 nodejs/reliability#688
Open
@RafaelGSS RafaelGSS mentioned this pull request Oct 9, 2023
2023-10-17, Version 21.0.0 (Current) #49870
Merged
@github-actions github-actions Bot mentioned this pull request Oct 10, 2023
CI Reliability 2023-10-10 nodejs/reliability#689
Open
24 tasks
targos pushed a commit that referenced this pull request Nov 11, 2023
@niyashiyas @targos
test: replace forEach with for..of in test-http-url
81886c6 
PR-URL: #49840
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
v20.10.0 release proposal #50682
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
2023-12-06, N|Solid v5.0.1 Iron Release nodesource/nsolid#41
Merged
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
@niyashiyas @debadree25
test: replace forEach with for..of in test-http-url
2b77d58 
PR-URL: nodejs#49840
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. commit-queue-squash PRs the Commit Queue should land as one squashed commit. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@niyashiyas @benjamingr @nodejs-github-bot @lpinca @tniessen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.