GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fs: improve error performance for `fdatasyncSync` by pluris · Pull Request #49898 · nodejs/node

Conversation

@pluris

@pluris pluris commented Sep 27, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
                                                      confidence improvement accuracy (*)   (**)   (***)
fs/bench_fdatasyncSync.js n=10000 type='existing'            ***      6.39 %       ±1.85% ±2.48%  ±3.25%
fs/bench_fdatasyncSync.js n=10000 type='non-existing'        ***    116.11 %       ±6.89% ±9.21% ±12.08%

Be aware that when doing many comparisons the risk of a false-positive result increases.
In this case, there are 2 comparisons, you can thus expect the following amount of false-positive results:
  0.10 false positives, when considering a   5% risk acceptance (*, **, ***),
  0.02 false positives, when considering a   1% risk acceptance (**, ***),
  0.00 false positives, when considering a 0.1% risk acceptance (***)

Refs: nodejs/performance#106

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

H4ad and anonrig reacted with rocket emoji
All reactions
  • 🚀 2 reactions
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Sep 27, 2023
anonrig
anonrig approved these changes Sep 27, 2023
View reviewed changes
Comment thread src/node_file.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.

@anonrig anonrig added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. needs-benchmark-ci PRs that need a benchmark CI run. performance Issues and PRs related to the performance of Node.js. labels Sep 27, 2023
@pluris pluris mentioned this pull request Sep 27, 2023
src: add GetValidatedFd() to node_file #49903
Closed
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 27, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 27, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54302/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joyeecheung
joyeecheung reviewed Sep 27, 2023
View reviewed changes

@joyeecheung joyeecheung left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should introduce a seemingly new implementation by copying and repeating the original implementation & moving code to a new JS file which makes git blame harder to use. See #49593 (comment)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

pluris reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@anonrig anonrig mentioned this pull request Sep 28, 2023
Performance of node:fs nodejs/performance#106
Open
@github-actions github-actions Bot mentioned this pull request Sep 30, 2023
CI Reliability 2023-09-30 nodejs/reliability#679
Open
31 tasks
@anonrig

anonrig commented Sep 30, 2023

Copy link
Copy Markdown
Member

Hey @pluris can you rebase this pull request? You'll see that sync.js file is now removed and merged into lib/fs.js

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

pluris
fs: improve error performance for fdatasyncSync
70a8931
@pluris
pluris force-pushed the perf/fdatasync branch from 87d65c7 to 1d42984 Compare October 1, 2023 15:58
pluris
apply nodejs#49913
78b27c0
@pluris
pluris force-pushed the perf/fdatasync branch 2 times, most recently from 358c67e to 78b27c0 Compare October 1, 2023 16:03
@pluris

pluris commented Oct 1, 2023

Copy link
Copy Markdown
Contributor Author

@anonrig I rebased and applied #49913.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@anonrig

anonrig commented Oct 1, 2023

Copy link
Copy Markdown
Member

@anonrig I rebased and applied #49913.

Can you re-add the benchmark?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pluris

pluris commented Oct 1, 2023

Copy link
Copy Markdown
Contributor Author

@anonrig I updated the description.

                                                      confidence improvement accuracy (*)   (**)   (***)
fs/bench_fdatasyncSync.js n=10000 type='existing'                     1.12 %       ±1.51% ±2.01%  ±2.62%
fs/bench_fdatasyncSync.js n=10000 type='non-existing'        ***    109.42 %       ±6.13% ±8.19% ±10.73%

Be aware that when doing many comparisons the risk of a false-positive result increases.
In this case, there are 2 comparisons, you can thus expect the following amount of false-positive results:
  0.10 false positives, when considering a   5% risk acceptance (*, **, ***),
  0.02 false positives, when considering a   1% risk acceptance (**, ***),
  0.00 false positives, when considering a 0.1% risk acceptance (***)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@anonrig

anonrig commented Oct 1, 2023

Copy link
Copy Markdown
Member

The benchmark you're running doesn't exist in main or in your pull request. Can you add the file to your pull request? :-) @pluris

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pluris

pluris commented Oct 1, 2023

Copy link
Copy Markdown
Contributor Author

@anonrig Oh, sorry. I added it again.
I think I did something wrong during the rebase process. 😅

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 1, 2023
anonrig
anonrig approved these changes Oct 1, 2023
View reviewed changes
@anonrig anonrig added commit-queue-squash PRs the Commit Queue should land as one squashed commit. author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Oct 1, 2023
@pluris
pluris force-pushed the perf/fdatasync branch from a7ef140 to 1818fa3 Compare October 1, 2023 16:26
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 1, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 1, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54446/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

pluris
add benchmark for fdatasyncSync
4c0958c
@pluris
pluris force-pushed the perf/fdatasync branch from 1818fa3 to 4c0958c Compare October 1, 2023 16:44
@pluris

pluris commented Oct 1, 2023

Copy link
Copy Markdown
Contributor Author

Oops, there was a part where the condition check was missing, so I modified it again and updated the benchmark.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

pluris
src: remove GetValidateFd()
bba51b3
@pluris

pluris commented Oct 2, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

@joyeecheung GetValidatedFd() has also been removed here, as described in #49880 (explanation).

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pluris
pluris requested a review from joyeecheung October 2, 2023 14:10
joyeecheung
joyeecheung approved these changes Oct 2, 2023
View reviewed changes
@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 2, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 2, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 2, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54474/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot mentioned this pull request Oct 3, 2023
CI Reliability 2023-10-03 nodejs/reliability#682
Open
18 tasks
anonrig
anonrig approved these changes Oct 3, 2023
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Oct 3, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54512/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@anonrig anonrig added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 3, 2023
@github-actions github-actions Bot mentioned this pull request Oct 4, 2023
CI Reliability 2023-10-04 nodejs/reliability#683
Open
14 tasks
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 4, 2023
@nodejs-github-bot
nodejs-github-bot merged commit f7a160d into nodejs:main Oct 4, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 4, 2023

Copy link
Copy Markdown
Collaborator

Landed in f7a160d

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This was referenced Oct 5, 2023
CI Reliability 2023-10-05 nodejs/reliability#684
Open
CI Reliability 2023-10-06 nodejs/reliability#685
Open
@RafaelGSS RafaelGSS mentioned this pull request Oct 9, 2023
2023-10-17, Version 21.0.0 (Current) #49870
Merged
@pluris
pluris deleted the perf/fdatasync branch November 8, 2023 02:24
targos pushed a commit that referenced this pull request Nov 11, 2023
Jungku Lee @targos
fs: improve error performance for fdatasyncSync
d7132d9
PR-URL: #49898
Refs: nodejs/performance#106
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
v20.10.0 release proposal #50682
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
2023-12-06, N|Solid v5.0.1 Iron Release nodesource/nsolid#41
Merged
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
Jungku Lee @debadree25
fs: improve error performance for fdatasyncSync
4b7fc22
PR-URL: nodejs#49898
Refs: nodejs/performance#106
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes
@joyeecheung joyeecheung joyeecheung approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash PRs the Commit Queue should land as one squashed commit. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-benchmark-ci PRs that need a benchmark CI run. needs-ci PRs that need a full CI run. performance Issues and PRs related to the performance of Node.js.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@pluris @nodejs-github-bot @anonrig @joyeecheung
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.