GeezerVison is showing github.com — fs: improve error performance for `fdatasyncSync` by pluris · Pull Request #49898 · nodejs/node
Conversation
pluris
commented
Sep 27, 2023
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
confidence improvement accuracy (*) (**) (***)
fs/bench_fdatasyncSync.js n=10000 type='existing' *** 6.39 % ±1.85% ±2.48% ±3.25%
fs/bench_fdatasyncSync.js n=10000 type='non-existing' *** 116.11 % ±6.89% ±9.21% ±12.08%
Be aware that when doing many comparisons the risk of a false-positive result increases.
In this case, there are 2 comparisons, you can thus expect the following amount of false-positive results:
0.10 false positives, when considering a 5% risk acceptance (*, **, ***),
0.02 false positives, when considering a 1% risk acceptance (**, ***),
0.00 false positives, when considering a 0.1% risk acceptance (***)
Refs: nodejs/performance#106
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
H4ad and anonrig reacted with rocket emoji
nodejs-github-bot
added
c++
Issues and PRs that require attention from people who are familiar with C++.
lib / src
Issues and PRs involving general changes in the lib/ or src/ directories.
needs-ci
PRs that need a full CI run.
labels
Sep 27, 2023
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should introduce a seemingly new implementation by copying and repeating the original implementation & moving code to a new JS file which makes git blame harder to use. See #49593 (comment)
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
pluris reacted with thumbs up emoji
|
Hey @pluris can you rebase this pull request? You'll see that sync.js file is now removed and merged into lib/fs.js
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
@anonrig I updated the description.
confidence improvement accuracy (*) (**) (***)
fs/bench_fdatasyncSync.js n=10000 type='existing' 1.12 % ±1.51% ±2.01% ±2.62%
fs/bench_fdatasyncSync.js n=10000 type='non-existing' *** 109.42 % ±6.13% ±8.19% ±10.73%
Be aware that when doing many comparisons the risk of a false-positive result increases.
In this case, there are 2 comparisons, you can thus expect the following amount of false-positive results:
0.10 false positives, when considering a 5% risk acceptance (*, **, ***),
0.02 false positives, when considering a 1% risk acceptance (**, ***),
0.00 false positives, when considering a 0.1% risk acceptance (***)
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
The benchmark you're running doesn't exist in main or in your pull request. Can you add the file to your pull request? :-) @pluris
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
@anonrig Oh, sorry. I added it again.
I think I did something wrong during the rebase process. 😅
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
anonrig
added
the
request-ci
Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review.
label
Oct 1, 2023
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Oops, there was a part where the condition check was missing, so I modified it again and updated the benchmark.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
pluris
commented
Oct 2, 2023
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
@joyeecheung GetValidatedFd() has also been removed here, as described in #49880 (explanation).
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Oct 5, 2023
Reviewers
anonrig
anonrig approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Labels
author ready
PRs with CI started, the required approvals, and no outstanding review comments.
c++
Issues and PRs that require attention from people who are familiar with C++.
commit-queue-squash
PRs the Commit Queue should land as one squashed commit.
lib / src
Issues and PRs involving general changes in the lib/ or src/ directories.
needs-benchmark-ci
PRs that need a benchmark CI run.
needs-ci
PRs that need a full CI run.
performance
Issues and PRs related to the performance of Node.js.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|