GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Revert "test: mark test-runner-output as flaky" by lpinca · Pull Request #49905 · nodejs/node

Conversation

@lpinca

@lpinca lpinca commented Sep 27, 2023

Copy link
Copy Markdown
Member

This reverts commit 717e233.

Refs: fef7927cc3a7

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@lpinca
Revert "test: mark test-runner-output as flaky"
b91661b 
This reverts commit 717e233.

Refs: nodejs@fef7927cc3a7
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Sep 27, 2023
cjihrig
cjihrig approved these changes Sep 27, 2023
View reviewed changes
MoLow
MoLow approved these changes Sep 27, 2023
View reviewed changes
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. and removed needs-ci PRs that need a full CI run. labels Sep 28, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Sep 29, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 29, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/49905
✔  Done loading data for nodejs/node/pull/49905
----------------------------------- PR info ------------------------------------
Title      Revert "test: mark test-runner-output as flaky" (#49905)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     lpinca:revert/717e233cd956 -> nodejs:main
Labels     test, author ready
Commits    1
 - Revert "test: mark test-runner-output as flaky"
Committers 1
 - Luigi Pinca 
PR-URL: https://github.com/nodejs/node/pull/49905
Refs: https://github.com/nodejs/node/commit/fef7927cc3a7
Reviewed-By: Colin Ihrig 
Reviewed-By: Moshe Atlow 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49905
Refs: https://github.com/nodejs/node/commit/fef7927cc3a7
Reviewed-By: Colin Ihrig 
Reviewed-By: Moshe Atlow 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 27 Sep 2023 17:41:11 GMT
   ✔  Approvals: 2
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/49905#pullrequestreview-1647260204
   ✔  - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/49905#pullrequestreview-1647379240
   ✔  Last GitHub CI successful
   ✘  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6355169313
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 29, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 29, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 29, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54386/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mhdawson
mhdawson approved these changes Sep 29, 2023
View reviewed changes

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@github-actions github-actions Bot mentioned this pull request Sep 30, 2023
CI Reliability 2023-09-30 nodejs/reliability#679
Open
31 tasks
@nodejs-github-bot

nodejs-github-bot commented Sep 30, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54405/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Sep 30, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54410/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lpinca lpinca added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Sep 30, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 30, 2023
@nodejs-github-bot
nodejs-github-bot merged commit f05d6d0 into nodejs:main Sep 30, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 30, 2023

Copy link
Copy Markdown
Collaborator

Landed in f05d6d0
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lpinca
lpinca deleted the revert/717e233cd956 branch September 30, 2023 15:45
@github-actions github-actions Bot mentioned this pull request Oct 1, 2023
CI Reliability 2023-10-01 nodejs/reliability#680
Open
16 tasks
This was referenced Oct 2, 2023
CI Reliability 2023-10-02 nodejs/reliability#681
Open
CI Reliability 2023-10-03 nodejs/reliability#682
Open
@RafaelGSS RafaelGSS mentioned this pull request Oct 9, 2023
2023-10-17, Version 21.0.0 (Current) #49870
Merged
targos pushed a commit that referenced this pull request Nov 11, 2023
@lpinca @targos
Revert "test: mark test-runner-output as flaky"
179e293 
This reverts commit 717e233.

Refs: fef7927cc3a7
PR-URL: #49905
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
v20.10.0 release proposal #50682
Merged
@targos targos added the dont-land-on-v18.x label Nov 27, 2023
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
2023-12-06, N|Solid v5.0.1 Iron Release nodesource/nsolid#41
Merged
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
@lpinca @debadree25
Revert "test: mark test-runner-output as flaky"
b065bfa 
This reverts commit 717e233.

Refs: nodejs@fef7927cc3a7
PR-URL: nodejs#49905
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes
@MoLow MoLow MoLow approved these changes
+1 more reviewer
@mhdawson mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@lpinca @nodejs-github-bot @cjihrig @MoLow @mhdawson @targos @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.