GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — wasi: fix up wasi tests for ibmi by mhdawson · Pull Request #49953 · nodejs/node

Conversation

@mhdawson

@mhdawson mhdawson commented Sep 29, 2023

Copy link
Copy Markdown
Member

ibmi now reports os400 instead of aix

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot

nodejs-github-bot commented Sep 29, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/wasi
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Sep 29, 2023
@mhdawson

mhdawson commented Sep 29, 2023

Copy link
Copy Markdown
Member Author

@richardlau as discussed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
richardlau
richardlau approved these changes Sep 29, 2023
View reviewed changes
@richardlau richardlau mentioned this pull request Sep 29, 2023
build: fix IBM i build with Python 3.9 #48056
Closed
anonrig
anonrig approved these changes Sep 29, 2023
View reviewed changes
@richardlau richardlau added the ibm i Issues and PRs related to the IBM i platform. label Sep 29, 2023
lpinca
lpinca approved these changes Sep 29, 2023
View reviewed changes
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 29, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 29, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 29, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54387/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
richardlau
richardlau reviewed Sep 29, 2023
View reviewed changes
Comment thread test/wasi/c/readdir.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Sep 30, 2023
CI Reliability 2023-09-30 nodejs/reliability#679
Open
CI Reliability 2023-10-01 nodejs/reliability#680
Open
CI Reliability 2023-10-02 nodejs/reliability#681
Open
@richardlau richardlau added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Oct 2, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 2, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 2, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54478/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Oct 3, 2023
CI Reliability 2023-10-03 nodejs/reliability#682
Open
18 tasks
@mhdawson

mhdawson commented Oct 3, 2023

Copy link
Copy Markdown
Member Author

@richardlau will take another look to figure out what is going on.
richardlau reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhdawson

mhdawson commented Oct 3, 2023

Copy link
Copy Markdown
Member Author

Turns out the problem is that a newer version of the wasi-sdk has changed behaviour. I used the latest which was version 20. The docs dont' say what version was used before. I'll update the PR to fix up to work with wasi-sdk version 20 and to document that is the version which should be used.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhdawson
mhdawson force-pushed the fixuvwasi-ibmi branch from e66205b to 44a5528 Compare October 3, 2023 21:44
@mhdawson

mhdawson commented Oct 3, 2023

Copy link
Copy Markdown
Member Author

Ok PR updated, I had to make other changes as well due to other behaviour changes in wask-sdk verison 20, so we'll see if the CI is happy across platforms.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhdawson
wasi: fix up wasi tests for ibmi
d7650a3 
ibmi now reports os400 instead of aix

- update platform check in poll to allow for os400
- update wasi-sdk level to 20
  - document the level of wasi-sdk used to compile the tests
  - remove platform check in readdir test as it does not seem to be
    needed with wasi-sdk version 20
  - comment out tests for some clocks which are no longer available when
    compiling with wasi-sdk level 20. These may be added back after
    WebAssembly/wasi-libc#266 is resolved.

Signed-off-by: Michael Dawson <[email protected]>
@mhdawson
mhdawson force-pushed the fixuvwasi-ibmi branch from 44a5528 to 7873db3 Compare October 3, 2023 22:01
@mhdawson mhdawson added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 3, 2023
@mhdawson
mhdawson force-pushed the fixuvwasi-ibmi branch from 7873db3 to d7650a3 Compare October 3, 2023 22:04
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 3, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 3, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54508/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Oct 3, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54517/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Oct 4, 2023
CI Reliability 2023-10-04 nodejs/reliability#683
Open
14 tasks
@richardlau

richardlau commented Oct 4, 2023

Copy link
Copy Markdown
Member

Ok PR updated, I had to make other changes as well due to other behaviour changes in wask-sdk verison 20, so we'll see if the CI is happy across platforms.

This looks good sans the linter failure.
FWIW IBM i CI on d7650a3 shows test-wasi now passing 🎉: https://ci.nodejs.org/job/node-test-commit-ibmi/1314/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhdawson
squash: fixup for linter
280a28b 
Signed-off-by: Michael Dawson <[email protected]>
@mhdawson

mhdawson commented Oct 4, 2023

Copy link
Copy Markdown
Member Author

Pushed commit to fix linter complaint.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
richardlau
richardlau approved these changes Oct 4, 2023
View reviewed changes
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 4, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 4, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 4, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54526/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhdawson

mhdawson commented Oct 4, 2023

Copy link
Copy Markdown
Member Author

osx failure looks like a flaky test - created this issue to track it - #50040
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richardlau richardlau added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 4, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 4, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 9cb8eb7 into nodejs:main Oct 4, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 4, 2023

Copy link
Copy Markdown
Collaborator

Landed in 9cb8eb7
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Oct 5, 2023
CI Reliability 2023-10-05 nodejs/reliability#684
Open
CI Reliability 2023-10-06 nodejs/reliability#685
Open
CI Reliability 2023-10-07 nodejs/reliability#686
Open
CI Reliability 2023-10-08 nodejs/reliability#687
Open
@RafaelGSS RafaelGSS mentioned this pull request Oct 9, 2023
2023-10-17, Version 21.0.0 (Current) #49870
Merged
targos pushed a commit that referenced this pull request Nov 11, 2023
@mhdawson @targos
wasi: fix up wasi tests for ibmi
5b695d6 
ibmi now reports os400 instead of aix

- update platform check in poll to allow for os400
- update wasi-sdk level to 20
  - document the level of wasi-sdk used to compile the tests
  - remove platform check in readdir test as it does not seem to be
    needed with wasi-sdk version 20
  - comment out tests for some clocks which are no longer available when
    compiling with wasi-sdk level 20. These may be added back after
    WebAssembly/wasi-libc#266 is resolved.

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #49953
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
v20.10.0 release proposal #50682
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
2023-12-06, N|Solid v5.0.1 Iron Release nodesource/nsolid#41
Merged
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
@mhdawson @debadree25
wasi: fix up wasi tests for ibmi
0475027 
ibmi now reports os400 instead of aix

- update platform check in poll to allow for os400
- update wasi-sdk level to 20
  - document the level of wasi-sdk used to compile the tests
  - remove platform check in readdir test as it does not seem to be
    needed with wasi-sdk version 20
  - comment out tests for some clocks which are no longer available when
    compiling with wasi-sdk level 20. These may be added back after
    WebAssembly/wasi-libc#266 is resolved.

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: nodejs#49953
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@anonrig anonrig anonrig approved these changes
@richardlau richardlau richardlau approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

commit-queue-squash PRs the Commit Queue should land as one squashed commit. ibm i Issues and PRs related to the IBM i platform. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@mhdawson @nodejs-github-bot @richardlau @lpinca @anonrig
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.