GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — stream: readable bimap by ronag · Pull Request #49963 · nodejs/node

Conversation

@ronag

@ronag ronag commented Sep 29, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Still not complete but another step in the right direction.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss and mertcanaltin reacted with eyes emoji
All reactions
  • 👀 2 reactions
@ronag
ronag requested review from benjamingr and mcollina September 29, 2023 17:42
@nodejs-github-bot

nodejs-github-bot commented Sep 29, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/streams
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Sep 29, 2023
@ronag
ronag force-pushed the readable-bimap2 branch 14 times, most recently from 276dfec to 30ad6c0 Compare September 29, 2023 19:25
@ronag

ronag commented Sep 29, 2023

Copy link
Copy Markdown
Member Author

https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1430/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mscdex

mscdex commented Sep 29, 2023

Copy link
Copy Markdown
Contributor

s/bimap/bitmap/ in commit message

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ronag

ronag commented Sep 30, 2023

Copy link
Copy Markdown
Member Author
16:59:22 streams/creation.js kind='duplex' n=50000000                                                    ***     12.35 %       ±1.40%  ±1.88%  ±2.48%
16:59:22 streams/creation.js kind='readable' n=50000000                                                  ***     -4.51 %       ±0.79%  ±1.06%  ±1.39%
16:59:22 streams/creation.js kind='transform' n=50000000                                                 ***     12.76 %       ±1.82%  ±2.42%  ±3.16%
16:59:22 streams/creation.js kind='writable' n=50000000                                                          -0.64 %       ±1.02%  ±1.35%  ±1.76%
16:59:22 streams/destroy.js kind='duplex' n=1000000                                                       **     11.80 %       ±7.99% ±10.63% ±13.83%
16:59:22 streams/destroy.js kind='readable' n=1000000                                                             2.41 %       ±2.57%  ±3.43%  ±4.47%
16:59:22 streams/destroy.js kind='transform' n=1000000                                                   ***     15.18 %       ±6.19%  ±8.24% ±10.74%
16:59:22 streams/destroy.js kind='writable' n=1000000                                                             1.10 %       ±2.65%  ±3.53%  ±4.60%
16:59:22 streams/pipe-object-mode.js n=5000000                                                                   -2.38 %       ±3.85%  ±5.14%  ±6.70%
16:59:22 streams/pipe.js n=5000000                                                                       ***      7.06 %       ±3.17%  ±4.21%  ±5.48%
16:59:22 streams/readable-async-iterator.js sync='no' n=100000                                            **      4.96 %       ±2.83%  ±3.79%  ±4.98%
16:59:22 streams/readable-async-iterator.js sync='yes' n=100000                                                  -1.89 %       ±4.03%  ±5.42%  ±7.18%
16:59:22 streams/readable-bigread.js n=1000                                                                       1.83 %       ±2.07%  ±2.75%  ±3.59%
16:59:22 streams/readable-bigunevenread.js n=1000                                                                 1.53 %       ±6.04%  ±8.04% ±10.46%
16:59:22 streams/readable-boundaryread.js type='buffer' n=2000                                           ***      4.27 %       ±1.37%  ±1.83%  ±2.41%
16:59:22 streams/readable-boundaryread.js type='string' n=2000                                           ***      3.12 %       ±1.50%  ±1.99%  ±2.60%
16:59:22 streams/readable-from.js n=10000000                                                             ***     11.41 %       ±2.08%  ±2.76%  ±3.60%
16:59:22 streams/readable-readall.js n=5000                                                                       0.34 %       ±0.70%  ±0.93%  ±1.21%
16:59:22 streams/readable-unevenread.js n=1000                                                           ***      3.39 %       ±0.46%  ±0.61%  ±0.80%
16:59:22 streams/writable-manywrites.js len=1024 callback='no' writev='no' sync='no' n=100000                    -0.68 %       ±2.02%  ±2.69%  ±3.53%
16:59:22 streams/writable-manywrites.js len=1024 callback='no' writev='no' sync='yes' n=100000                    2.53 %       ±3.57%  ±4.75%  ±6.19%
16:59:22 streams/writable-manywrites.js len=1024 callback='no' writev='yes' sync='no' n=100000                    0.28 %       ±2.45%  ±3.28%  ±4.31%
16:59:22 streams/writable-manywrites.js len=1024 callback='no' writev='yes' sync='yes' n=100000                   0.67 %       ±2.94%  ±3.91%  ±5.09%
16:59:22 streams/writable-manywrites.js len=1024 callback='yes' writev='no' sync='no' n=100000                   -1.20 %       ±2.37%  ±3.17%  ±4.16%
16:59:22 streams/writable-manywrites.js len=1024 callback='yes' writev='no' sync='yes' n=100000                   1.15 %       ±2.52%  ±3.36%  ±4.38%
16:59:22 streams/writable-manywrites.js len=1024 callback='yes' writev='yes' sync='no' n=100000                   0.01 %       ±2.74%  ±3.66%  ±4.80%
16:59:22 streams/writable-manywrites.js len=1024 callback='yes' writev='yes' sync='yes' n=100000                  0.36 %       ±2.58%  ±3.44%  ±4.47%
16:59:22 streams/writable-manywrites.js len=32768 callback='no' writev='no' sync='no' n=100000                   -0.28 %       ±1.15%  ±1.53%  ±1.99%
16:59:22 streams/writable-manywrites.js len=32768 callback='no' writev='no' sync='yes' n=100000                   1.28 %       ±1.92%  ±2.56%  ±3.35%
16:59:22 streams/writable-manywrites.js len=32768 callback='no' writev='yes' sync='no' n=100000                  -0.03 %       ±1.44%  ±1.92%  ±2.50%
16:59:22 streams/writable-manywrites.js len=32768 callback='no' writev='yes' sync='yes' n=100000                  1.88 %       ±1.92%  ±2.57%  ±3.37%
16:59:22 streams/writable-manywrites.js len=32768 callback='yes' writev='no' sync='no' n=100000                  -0.55 %       ±1.28%  ±1.72%  ±2.24%
16:59:22 streams/writable-manywrites.js len=32768 callback='yes' writev='no' sync='yes' n=100000                 -0.48 %       ±0.94%  ±1.25%  ±1.63%
16:59:22 streams/writable-manywrites.js len=32768 callback='yes' writev='yes' sync='no' n=100000                  0.65 %       ±1.32%  ±1.75%  ±2.29%
16:59:22 streams/writable-manywrites.js len=32768 callback='yes' writev='yes' sync='yes' n=100000         **     -1.84 %       ±1.19%  ±1.58%  ±2.07%
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ronag ronag added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 30, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 30, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 30, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54392/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

benjamingr
benjamingr reviewed Sep 30, 2023
View reviewed changes

@benjamingr benjamingr left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a branch that does some of this (which you saw on our video call) but haven't been in office since (it's Sukkot here and we're on holiday). Anyway I'll review mostly should be good/similar.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
benjamingr
benjamingr reviewed Sep 30, 2023
View reviewed changes

@benjamingr benjamingr left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has more work than my branch so probably let's keep it on this one - there are a few places missing conversion to bitmap (also in the old properties) IIRC I'll check when I'm able

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
benjamingr
benjamingr reviewed Sep 30, 2023
View reviewed changes
Comment thread lib/internal/streams/readable.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

benjamingr
benjamingr reviewed Sep 30, 2023
View reviewed changes
Comment thread lib/internal/streams/readable.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

benjamingr
benjamingr reviewed Sep 30, 2023
View reviewed changes
Comment thread lib/internal/streams/readable.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot mentioned this pull request Oct 1, 2023
CI Reliability 2023-10-01 nodejs/reliability#680
Open
16 tasks
rluvaton
rluvaton reviewed Oct 16, 2023
View reviewed changes
Comment thread lib/internal/streams/readable.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

rluvaton
rluvaton reviewed Oct 16, 2023
View reviewed changes
Comment thread lib/internal/streams/readable.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

ronag
ronag commented Oct 16, 2023
View reviewed changes
Comment thread lib/internal/streams/readable.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

@ronag
stream: readable bimap
28b85ad
PR-URL: nodejs#49963
@ronag
ronag force-pushed the readable-bimap2 branch from c691e56 to 28b85ad Compare October 16, 2023 22:12
@ronag
ronag requested a review from rluvaton October 16, 2023 22:13
@ronag ronag added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 16, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 16, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 16, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54862/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

rluvaton
rluvaton reviewed Oct 16, 2023
View reviewed changes
Comment thread lib/internal/streams/readable.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Oct 17, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54872/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

rluvaton
rluvaton approved these changes Oct 17, 2023
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Oct 17, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54876/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tniessen

tniessen commented Oct 17, 2023

Copy link
Copy Markdown
Member

Nit: commit message does not adhere to guidelines.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Oct 17, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54885/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tniessen tniessen removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Oct 17, 2023
@tniessen

tniessen commented Oct 17, 2023

Copy link
Copy Markdown
Member

(Removed the author-ready label due to the commit message. Please amend before merging.)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Uzlopak

Uzlopak commented Oct 17, 2023

Copy link
Copy Markdown
Contributor

Should it be streams: readable bitmap or what do you suggest?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tniessen

tniessen commented Oct 17, 2023

Copy link
Copy Markdown
Member

Please refer to the commit message guidelines. The commit message must begin with the subsystem prefix (e.g., stream:) followed by a an imperative verb in lower case.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Trott

Trott commented Oct 17, 2023

Copy link
Copy Markdown
Member

Should it be something like stream: reduce scope of readable bitmap details? I'm happy to manually land this and amend the commit message, but I want to make sure I get it right and also keep the first line reasonably concise.

ronag reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lpinca
lpinca approved these changes Oct 17, 2023
View reviewed changes

@lpinca lpinca left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Trott
Trott approved these changes Oct 17, 2023
View reviewed changes

@Trott Trott left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Trott
Trott merged commit 4e70d23 into nodejs:main Oct 17, 2023
@Trott

Trott commented Oct 17, 2023

Copy link
Copy Markdown
Member

Landed in 4e70d23

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos pushed a commit that referenced this pull request Oct 23, 2023
@ronag @targos
stream: reduce scope of readable bitmap details
514ac86
PR-URL: #49963
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Raz Luvaton <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request Oct 23, 2023
v21.1.0 release proposal #50335
Merged
targos pushed a commit that referenced this pull request Nov 11, 2023
@ronag @targos
stream: reduce scope of readable bitmap details
6d7274e
PR-URL: #49963
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Raz Luvaton <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
v20.10.0 release proposal #50682
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
2023-12-06, N|Solid v5.0.1 Iron Release nodesource/nsolid#41
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes
@benjamingr benjamingr benjamingr approved these changes
@lpinca lpinca lpinca approved these changes
@rluvaton rluvaton rluvaton approved these changes
@mcollina mcollina Awaiting requested review from mcollina
+1 more reviewer
@mscdex mscdex mscdex left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@ronag @nodejs-github-bot @mscdex @benjamingr @tniessen @Uzlopak @Trott @lpinca @rluvaton
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.