GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — stream: avoid tick in writable hot path by ronag · Pull Request #49966 · nodejs/node

Conversation

@ronag

@ronag ronag commented Sep 29, 2023

Copy link
Copy Markdown
Member 
streams/writable-manywrites.js len=1024 callback='no' writev='no' sync='no' n=100000            ***      4.11 %       ±1.32% ±1.76% ±2.31%
streams/writable-manywrites.js len=1024 callback='no' writev='no' sync='yes' n=100000           ***     -2.82 %       ±1.32% ±1.77% ±2.34%
streams/writable-manywrites.js len=1024 callback='no' writev='yes' sync='no' n=100000           ***      4.15 %       ±1.63% ±2.18% ±2.85%
streams/writable-manywrites.js len=1024 callback='no' writev='yes' sync='yes' n=100000          ***      2.74 %       ±1.17% ±1.57% ±2.06%
streams/writable-manywrites.js len=1024 callback='yes' writev='no' sync='no' n=100000           ***      4.59 %       ±1.55% ±2.06% ±2.68%
streams/writable-manywrites.js len=1024 callback='yes' writev='no' sync='yes' n=100000          ***      5.49 %       ±2.10% ±2.80% ±3.65%
streams/writable-manywrites.js len=1024 callback='yes' writev='yes' sync='no' n=100000          ***      6.62 %       ±2.87% ±3.82% ±4.98%
streams/writable-manywrites.js len=1024 callback='yes' writev='yes' sync='yes' n=100000           *      5.87 %       ±4.72% ±6.34% ±8.37%
streams/writable-manywrites.js len=32768 callback='no' writev='no' sync='no' n=100000           ***      5.45 %       ±1.31% ±1.74% ±2.27%
streams/writable-manywrites.js len=32768 callback='no' writev='no' sync='yes' n=100000          ***      7.98 %       ±1.71% ±2.28% ±2.99%
streams/writable-manywrites.js len=32768 callback='no' writev='yes' sync='no' n=100000          ***      5.86 %       ±1.37% ±1.83% ±2.38%
streams/writable-manywrites.js len=32768 callback='no' writev='yes' sync='yes' n=100000         ***      8.15 %       ±1.79% ±2.41% ±3.19%
streams/writable-manywrites.js len=32768 callback='yes' writev='no' sync='no' n=100000          ***      4.93 %       ±0.67% ±0.90% ±1.17%
streams/writable-manywrites.js len=32768 callback='yes' writev='no' sync='yes' n=100000         ***      9.06 %       ±2.03% ±2.71% ±3.54%
streams/writable-manywrites.js len=32768 callback='yes' writev='yes' sync='no' n=100000         ***      6.20 %       ±1.85% ±2.47% ±3.23%
streams/writable-manywrites.js len=32768 callback='yes' writev='yes' sync='yes' n=100000        ***      8.49 %       ±0.85% ±1.13% ±1.47%

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
H4ad, anonrig, and bricss reacted with rocket emoji
All reactions
  • 🚀 3 reactions
@ronag
ronag requested review from benjamingr, lpinca and mcollina September 29, 2023 19:56
@nodejs-github-bot

nodejs-github-bot commented Sep 29, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/streams
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Sep 29, 2023
ronag
ronag commented Sep 29, 2023
View reviewed changes
Comment thread lib/internal/streams/writable.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ronag
ronag force-pushed the writable-avoid-tick branch from 3813f33 to dc8621c Compare September 29, 2023 20:15
benjamingr
benjamingr reviewed Sep 29, 2023
View reviewed changes
Comment thread lib/internal/streams/writable.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
benjamingr
benjamingr approved these changes Sep 29, 2023
View reviewed changes
anonrig
anonrig approved these changes Sep 29, 2023
View reviewed changes
@ronag ronag added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Sep 30, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 30, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 30, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54391/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mcollina
mcollina approved these changes Sep 30, 2023
View reviewed changes

@mcollina mcollina left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@lpinca

lpinca commented Sep 30, 2023

Copy link
Copy Markdown
Member

Test failures seem related.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ronag ronag removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Sep 30, 2023
@ronag
ronag force-pushed the writable-avoid-tick branch 5 times, most recently from e85a819 to 9d69bf9 Compare September 30, 2023 09:17
@ronag
ronag force-pushed the writable-avoid-tick branch from 9d69bf9 to 4b293ec Compare September 30, 2023 09:18
@ronag ronag added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Sep 30, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 30, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 30, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54402/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ronag
stream: avoid tick in writable hot path
f164932 
PR-URL: nodejs#49966
@ronag ronag added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 30, 2023
@ronag
ronag force-pushed the writable-avoid-tick branch from c17b6c7 to f164932 Compare September 30, 2023 13:50
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Sep 30, 2023
@nodejs-github-bot

nodejs-github-bot commented Sep 30, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54407/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Sep 30, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54415/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Sep 30, 2023
View reviewed changes
@ronag ronag added the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 30, 2023
@github-actions github-actions Bot mentioned this pull request Oct 1, 2023
CI Reliability 2023-10-01 nodejs/reliability#680
Open
16 tasks
@ronag

This comment was marked as resolved.

Sign in to view
@MoLow

This comment was marked as resolved.

Sign in to view
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 1, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 5de25de into nodejs:main Oct 1, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 1, 2023

Copy link
Copy Markdown
Collaborator

Landed in 5de25de
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Oct 2, 2023
CI Reliability 2023-10-02 nodejs/reliability#681
Open
CI Reliability 2023-10-03 nodejs/reliability#682
Open
@RafaelGSS RafaelGSS mentioned this pull request Oct 9, 2023
2023-10-17, Version 21.0.0 (Current) #49870
Merged
targos pushed a commit that referenced this pull request Nov 11, 2023
@ronag @targos
stream: avoid tick in writable hot path
def55f8 
PR-URL: #49966
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
v20.10.0 release proposal #50682
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
2023-12-06, N|Solid v5.0.1 Iron Release nodesource/nsolid#41
Merged
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
@ronag @debadree25
stream: avoid tick in writable hot path
b20e7c8 
PR-URL: nodejs#49966
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
@benjamingr benjamingr benjamingr approved these changes
@lpinca lpinca lpinca approved these changes
@anonrig anonrig anonrig approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@ronag @nodejs-github-bot @lpinca @MoLow @mcollina @benjamingr @anonrig
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.