GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: remove genv8constants.py by bnoordhuis · Pull Request #50023 · nodejs/node

Conversation

@bnoordhuis

@bnoordhuis bnoordhuis commented Oct 3, 2023

Copy link
Copy Markdown
Member

Unused after commit aa3a572 ("build: remove dtrace & etw support") from last year. I had this vague notion that llnode also used it but that is another script.

Fixes: #49991

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bnoordhuis
tools: remove genv8constants.py
f6a50cd 
Unused after commit aa3a572 ("build: remove dtrace & etw support")
from last year. I had this vague notion that llnode also used it but
that is another script.

Fixes: nodejs#49991
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. python PRs and issues that require attention from people who are familiar with Python. labels Oct 3, 2023
@bnoordhuis bnoordhuis mentioned this pull request Oct 3, 2023
tools: pass explicit section list to objdump #49992
Closed
targos
targos approved these changes Oct 3, 2023
View reviewed changes
anonrig
anonrig approved these changes Oct 3, 2023
View reviewed changes
@anonrig anonrig added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Oct 3, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 3, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 3, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54492/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
benjamingr
benjamingr approved these changes Oct 3, 2023
View reviewed changes
@richardlau richardlau added the dont-land-on-v18.x label Oct 3, 2023
richardlau
richardlau approved these changes Oct 3, 2023
View reviewed changes
tniessen
tniessen approved these changes Oct 3, 2023
View reviewed changes
cjihrig
cjihrig approved these changes Oct 3, 2023
View reviewed changes
lpinca
lpinca approved these changes Oct 3, 2023
View reviewed changes
@bnoordhuis bnoordhuis added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 5, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 5, 2023
@nodejs-github-bot
nodejs-github-bot merged commit f73650e into nodejs:main Oct 5, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 5, 2023

Copy link
Copy Markdown
Collaborator

Landed in f73650e
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS RafaelGSS mentioned this pull request Oct 9, 2023
2023-10-17, Version 21.0.0 (Current) #49870
Merged
targos pushed a commit that referenced this pull request Nov 11, 2023
@bnoordhuis @targos
tools: remove genv8constants.py
e323a36 
Unused after commit aa3a572 ("build: remove dtrace & etw support")
from last year. I had this vague notion that llnode also used it but
that is another script.

Fixes: #49991
PR-URL: #50023
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
v20.10.0 release proposal #50682
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
2023-12-06, N|Solid v5.0.1 Iron Release nodesource/nsolid#41
Merged
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
@bnoordhuis @debadree25
tools: remove genv8constants.py
c7a26dd 
Unused after commit aa3a572 ("build: remove dtrace & etw support")
from last year. I had this vague notion that llnode also used it but
that is another script.

Fixes: nodejs#49991
PR-URL: nodejs#50023
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingr benjamingr benjamingr approved these changes
@lpinca lpinca lpinca approved these changes
@anonrig anonrig anonrig approved these changes
@cjihrig cjihrig cjihrig approved these changes
@tniessen tniessen tniessen approved these changes
@richardlau richardlau richardlau approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. build Issues and PRs related to Node.js builds or CI infrastructure. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. python PRs and issues that require attention from people who are familiar with Python.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

genv8constants fails to extract all symbols with binutils 2.41

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@bnoordhuis @nodejs-github-bot @benjamingr @lpinca @anonrig @targos @cjihrig @tniessen @richardlau
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.