GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: use precise promise terminology in fs by benjamingr · Pull Request #50029 · nodejs/node

Conversation

@benjamingr

@benjamingr benjamingr commented Oct 3, 2023

Copy link
Copy Markdown
Member

See #50028 for context - this also has the added benefit of reducing the amount of times we use resolving a promise vs resolving a path.

Note this document already used fulfills in many cases and I kept resolves (for promises) in some cases where it made sense to me from a technical point of view

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@benjamingr
doc: use precise promise terminology in fs
750e86e 
See #50028 for context - this also has the added benefit of reducing the amount of times we use resolving a promise vs resolving a path.

Note this document already used `fulfills` in many cases and I kept resolves (for promises) in some cases where it made sense to me from a technical point of view
@benjamingr benjamingr added doc Issues and PRs related to Node.js documentation. fs Issues and PRs related to file-system APIs and the fs module. labels Oct 3, 2023
lpinca
lpinca approved these changes Oct 3, 2023
View reviewed changes
MoLow
MoLow approved these changes Oct 3, 2023
View reviewed changes
atlowChemi
atlowChemi approved these changes Oct 3, 2023
View reviewed changes
@aduh95
aduh95 merged commit e43bf4c into main Oct 8, 2023
@aduh95
aduh95 deleted the promise-terminology-in-fs branch October 8, 2023 10:06
@aduh95

aduh95 commented Oct 8, 2023

Copy link
Copy Markdown
Contributor

Landed in e43bf4c
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS RafaelGSS mentioned this pull request Oct 9, 2023
2023-10-17, Version 21.0.0 (Current) #49870
Merged
targos pushed a commit that referenced this pull request Nov 11, 2023
@benjamingr @targos
doc: use precise promise terminology in fs
9830165 
See #50028 for context - this also
has the added benefit of reducing the amount of times we use resolving a
promise vs resolving a path.

Note this document already used `fulfills` in many cases and I kept
resolves (for promises) in some cases where it made sense to me from a
technical point of view.

PR-URL: #50029
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
v20.10.0 release proposal #50682
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
2023-12-06, N|Solid v5.0.1 Iron Release nodesource/nsolid#41
Merged
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
@benjamingr @debadree25
doc: use precise promise terminology in fs
4853671 
See nodejs#50028 for context - this also
has the added benefit of reducing the amount of times we use resolving a
promise vs resolving a path.

Note this document already used `fulfills` in many cases and I kept
resolves (for promises) in some cases where it made sense to me from a
technical point of view.

PR-URL: nodejs#50029
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@MoLow MoLow MoLow approved these changes
@atlowChemi atlowChemi atlowChemi approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. fs Issues and PRs related to file-system APIs and the fs module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@benjamingr @aduh95 @lpinca @MoLow @atlowChemi
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.