GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fs,url: refactor `FileURLToPath` and `FromNamespacedPath` by anonrig · Pull Request #50090 · nodejs/node

Conversation

@anonrig

@anonrig anonrig commented Oct 8, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Moves FileURLToPath and FromNamespacedPath to node_url.cc and changes the function declarations

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with eyes emoji
All reactions
  • 👀 1 reaction
@nodejs-github-bot

nodejs-github-bot commented Oct 8, 2023 •
edited by anonrig
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/url
  • @nodejs/fs
  • @nodejs/cpp-reviewers
  • @nodejs/performance
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Oct 8, 2023
@anonrig
anonrig force-pushed the refactor-file-url-to-path branch from 0c45748 to f15ab36 Compare October 8, 2023 18:43
lemire
lemire reviewed Oct 8, 2023
View reviewed changes
Comment thread src/node_url.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.
anonrig
anonrig commented Oct 8, 2023
View reviewed changes
Comment thread src/node_url.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.
@GeoffreyBooth

GeoffreyBooth commented Oct 8, 2023

Copy link
Copy Markdown
Member

Does this just move, or move and refactor? If the latter could you please do that in two commits that we can land via commit-queue-rebase, so that we preserve the history of the refactor separately from the move.
anonrig reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig
anonrig force-pushed the refactor-file-url-to-path branch from f15ab36 to a8cbc30 Compare October 9, 2023 15:48
@anonrig anonrig changed the title url: refactor FileURLToPath fs,url: refactor FileURLToPath and FromNamespacedPath Oct 9, 2023
@anonrig anonrig added the commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. label Oct 9, 2023
@anonrig
anonrig force-pushed the refactor-file-url-to-path branch from a8cbc30 to a4ae983 Compare October 9, 2023 15:52
GeoffreyBooth
GeoffreyBooth approved these changes Oct 9, 2023
View reviewed changes

@GeoffreyBooth GeoffreyBooth left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
lemire
lemire approved these changes Oct 9, 2023
View reviewed changes
H4ad
H4ad approved these changes Oct 9, 2023
View reviewed changes
@anonrig
anonrig force-pushed the refactor-file-url-to-path branch 2 times, most recently from a645373 to 3abddc7 Compare October 9, 2023 19:52
mcollina
mcollina approved these changes Oct 9, 2023
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@anonrig anonrig added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Oct 9, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 9, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 9, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54638/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Oct 10, 2023
CI Reliability 2023-10-10 nodejs/reliability#689
Open
24 tasks
@nodejs-github-bot

nodejs-github-bot commented Oct 10, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54641/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Oct 10, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54651/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig
anonrig force-pushed the refactor-file-url-to-path branch from 3abddc7 to dc27ae3 Compare October 10, 2023 13:34
@anonrig

anonrig commented Oct 10, 2023

Copy link
Copy Markdown
Member Author

Rebased and force-pushed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 10, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 10, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 10, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54658/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Oct 25, 2023
CI Reliability 2023-10-25 nodejs/reliability#697
Open
16 tasks
anonrig added 3 commits October 25, 2023 18:08
@anonrig
fs,url: move FileURLToPath to node_url
9e7afcc
@anonrig
fs,url: refactor FileURLToPath method
31324bf
@anonrig
fs,url: move FromNamespacedPath to node_url
4bef812
@anonrig
anonrig force-pushed the refactor-file-url-to-path branch from 9a2cd4c to 4bef812 Compare October 25, 2023 22:09
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 25, 2023
@anonrig anonrig mentioned this pull request Oct 25, 2023
src: move package_json_reader cache to c++ #50322
Closed
8 tasks done
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 25, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 25, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55239/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
H4ad
H4ad approved these changes Oct 25, 2023
View reviewed changes
@github-actions github-actions Bot mentioned this pull request Oct 26, 2023
CI Reliability 2023-10-26 nodejs/reliability#698
Open
20 tasks
@nodejs-github-bot

nodejs-github-bot commented Oct 26, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55242/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig anonrig added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 26, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 26, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 26, 2023

Copy link
Copy Markdown
Collaborator

Landed in 9c714d8...b24215e
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot closed this Oct 26, 2023
nodejs-github-bot pushed a commit that referenced this pull request Oct 26, 2023
@anonrig @nodejs-github-bot
fs,url: move FileURLToPath to node_url
557f928 
PR-URL: #50090
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Oct 26, 2023
@anonrig @nodejs-github-bot
fs,url: refactor FileURLToPath method
f0995d1 
PR-URL: #50090
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Oct 26, 2023
@anonrig @nodejs-github-bot
fs,url: move FromNamespacedPath to node_url
b24215e 
PR-URL: #50090
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
targos pushed a commit that referenced this pull request Nov 11, 2023
@anonrig @targos
fs,url: move FileURLToPath to node_url
4345ee2 
PR-URL: #50090
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
targos pushed a commit that referenced this pull request Nov 11, 2023
@anonrig @targos
fs,url: refactor FileURLToPath method
b4db32e 
PR-URL: #50090
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
targos pushed a commit that referenced this pull request Nov 11, 2023
@anonrig @targos
fs,url: move FromNamespacedPath to node_url
67cbe1b 
PR-URL: #50090
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
v21.2.0 release proposal #50681
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@anonrig @UlisesGascon
fs,url: move FileURLToPath to node_url
186e6e0 
PR-URL: #50090
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@anonrig @UlisesGascon
fs,url: refactor FileURLToPath method
de7fe08 
PR-URL: #50090
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@anonrig @UlisesGascon
fs,url: move FromNamespacedPath to node_url
868a464 
PR-URL: #50090
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
v20.11.0 proposal #51124
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
@Qard Qard Qard approved these changes
@lemire lemire lemire approved these changes
@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes
@H4ad H4ad H4ad approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@anonrig @nodejs-github-bot @GeoffreyBooth @mcollina @Qard @lemire @H4ad
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.