GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: remove no-return-await lint rule by sapphi-red · Pull Request #50118 · nodejs/node

Conversation

@sapphi-red

@sapphi-red sapphi-red commented Oct 10, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

no-return-await rule was deprecated in ESLint 8.46.0. According to the ESLint docs removing await can make the code slower.

Refs: https://eslint.org/docs/latest/rules/no-return-await

This rule was added in #17265.
return await is sometimes necessary to create a better stacktrace (#49849 (comment)).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sapphi-red
tools: remove no-return-await lint rule
0d4caee 
no-return-await rule was deprecated in ESLint 8.46.0. According to the
ESLint docs removing `await` can make the code slower.

Refs: https://eslint.org/docs/latest/rules/no-return-await
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Oct 10, 2023
@sapphi-red
sapphi-red force-pushed the tools/remove-no-return-await-rule branch from a503145 to 0d4caee Compare October 10, 2023 10:38
anonrig
anonrig approved these changes Oct 10, 2023
View reviewed changes
@anonrig anonrig added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Oct 10, 2023
lpinca
lpinca approved these changes Oct 10, 2023
View reviewed changes
@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 11, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 12, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 760b5dd into nodejs:main Oct 12, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 12, 2023

Copy link
Copy Markdown
Collaborator

Landed in 760b5dd
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sapphi-red
sapphi-red deleted the tools/remove-no-return-await-rule branch October 12, 2023 11:30
@sapphi-red sapphi-red mentioned this pull request Oct 12, 2023
fs: add stacktrace to fs/promises #49849
Merged
@RafaelGSS RafaelGSS mentioned this pull request Oct 15, 2023
2023-10-17, Version 21.0.0 (Current) #49870
Merged
targos pushed a commit that referenced this pull request Nov 11, 2023
@sapphi-red @targos
tools: remove no-return-await lint rule
bd5d533 
no-return-await rule was deprecated in ESLint 8.46.0. According to the
ESLint docs removing `await` can make the code slower.

Refs: https://eslint.org/docs/latest/rules/no-return-await
PR-URL: #50118
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
v20.10.0 release proposal #50682
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
2023-12-06, N|Solid v5.0.1 Iron Release nodesource/nsolid#41
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@anonrig anonrig anonrig approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@sapphi-red @nodejs-github-bot @lpinca @anonrig @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.