GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — typings: Use `Symbol.dispose` and `Symbol.asyncDispose` in types by nikeee · Pull Request #50123 · nodejs/node

Conversation

@nikeee

@nikeee nikeee commented Oct 10, 2023

Copy link
Copy Markdown
Member

Both symbols seem to be available by now. TS 5.2 released in august, the TODO is from june.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added the typings Issues and PRs related to internal TypeScript declarations. label Oct 10, 2023
@nikeee
nikeee marked this pull request as ready for review October 10, 2023 15:51
@nikeee nikeee changed the title Use Symbol.dispose and Symbol.asyncDispose in types typings: Use Symbol.dispose and Symbol.asyncDispose in types Oct 10, 2023
@nikeee
nikeee force-pushed the enhancement/symbol-dispose branch from 255b5d5 to 6643fa4 Compare October 10, 2023 15:52
@nikeee
typings: use Symbol.dispose and Symbol.asyncDispose in types
742ccdc
@nikeee
nikeee force-pushed the enhancement/symbol-dispose branch from 6643fa4 to 742ccdc Compare October 10, 2023 16:18
aduh95
aduh95 approved these changes Oct 10, 2023
View reviewed changes
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 10, 2023
@nikeee

nikeee commented Oct 10, 2023

Copy link
Copy Markdown
Member Author

@aduh95 do you have any advice for me to meet the required code coverage?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 12, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 12, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/50123
✔  Done loading data for nodejs/node/pull/50123
----------------------------------- PR info ------------------------------------
Title      typings: Use `Symbol.dispose` and `Symbol.asyncDispose` in types (#50123)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     nikeee:enhancement/symbol-dispose -> nodejs:main
Labels     author ready, typings
Commits    1
 - typings: use `Symbol.dispose` and `Symbol.asyncDispose` in types
Committers 1
 - Niklas Mollenhauer 
PR-URL: https://github.com/nodejs/node/pull/50123
Reviewed-By: Antoine du Hamel 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/50123
Reviewed-By: Antoine du Hamel 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 10 Oct 2023 15:50:29 GMT
   ✔  Approvals: 1
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/50123#pullrequestreview-1668916117
   ✘  This PR needs to wait 119 more hours to land (or 0 hours if there is one more approval)
   ✘  Last GitHub CI failed
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6498021995
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
debadree25
debadree25 approved these changes Oct 14, 2023
View reviewed changes
@debadree25 debadree25 added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Oct 14, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 14, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 9df864d into nodejs:main Oct 14, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 14, 2023

Copy link
Copy Markdown
Collaborator

Landed in 9df864d
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Uzlopak Uzlopak mentioned this pull request Oct 14, 2023
Bump to 4.24.1 breaks build fastify/fastify#5094
Closed
2 tasks done
@nikeee
nikeee deleted the enhancement/symbol-dispose branch October 14, 2023 12:00
@RafaelGSS RafaelGSS mentioned this pull request Oct 15, 2023
2023-10-17, Version 21.0.0 (Current) #49870
Merged
targos pushed a commit that referenced this pull request Nov 11, 2023
@nikeee @targos
typings: use Symbol.dispose and Symbol.asyncDispose in types
0ddb87e 
PR-URL: #50123
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
v20.10.0 release proposal #50682
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
2023-12-06, N|Solid v5.0.1 Iron Release nodesource/nsolid#41
Merged
@coderabbitai coderabbitai Bot mentioned this pull request Jul 6, 2026
feat(node): proxy sessions with identity dedup and cleanup ByteVeda/flexiq#375
Merged
3 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95 aduh95 aduh95 approved these changes
+1 more reviewer
@debadree25 debadree25 debadree25 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. typings Issues and PRs related to internal TypeScript declarations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@nikeee @nodejs-github-bot @aduh95 @debadree25
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.