GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: fix update-acorn.sh and undici_version.h path by Keksonoid · Pull Request #50165 · nodejs/node

Conversation

@Keksonoid

@Keksonoid Keksonoid commented Oct 12, 2023

Copy link
Copy Markdown
Contributor

Fixes: #50159

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Keksonoid added 2 commits October 12, 2023 22:55
@Keksonoid
tools: fix update-acorn.sh path
e4d4b10
@Keksonoid
tools: fix undici_version.h path
9e368b3
@nodejs-github-bot

nodejs-github-bot commented Oct 12, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Oct 12, 2023
marco-ippolito
marco-ippolito reviewed Oct 12, 2023
View reviewed changes
Comment thread tools/dep_updaters/update-acorn.sh Resolved

Uh oh!

There was an error while loading. Please reload this page.
Keksonoid and others added 2 commits October 12, 2023 23:55
@Keksonoid
Merge branch 'nodejs:main' into update-undici
722f2db
@Keksonoid @marco-ippolito
tools: fix update-acorn.sh path
586bdcd 
Co-authored-by: Marco Ippolito <[email protected]>
@marco-ippolito marco-ippolito removed the c++ Issues and PRs that require attention from people who are familiar with C++. label Oct 12, 2023
aduh95
aduh95 approved these changes Oct 12, 2023
View reviewed changes
@aduh95 aduh95 added fast-track PRs proposed for a shorter-than-standard waiting period before landing. author ready PRs with CI started, the required approvals, and no outstanding review comments. and removed needs-ci PRs that need a full CI run. labels Oct 12, 2023
@github-actions

github-actions Bot commented Oct 12, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.
lpinca and panva reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Oct 12, 2023
View reviewed changes
mhdawson
mhdawson approved these changes Oct 12, 2023
View reviewed changes

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
panva
panva approved these changes Oct 12, 2023
View reviewed changes
@aduh95
aduh95 merged commit 766198b into nodejs:main Oct 12, 2023
@aduh95

aduh95 commented Oct 12, 2023

Copy link
Copy Markdown
Contributor

Landed in 766198b, thanks for the contribution!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pluris pluris mentioned this pull request Oct 13, 2023
tools: update comment in update-uncidi.sh and acorn_version.h #50175
Merged
@RafaelGSS RafaelGSS mentioned this pull request Oct 15, 2023
2023-10-17, Version 21.0.0 (Current) #49870
Merged
aduh95 pushed a commit that referenced this pull request Oct 15, 2023
Jungku Lee
tools: update comment in update-uncidi.sh and acorn_version.h
f09a50c 
PR-URL: #50175
Fixes: #50159
Refs: #50165
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
targos pushed a commit that referenced this pull request Oct 23, 2023
Jungku Lee @targos
tools: update comment in update-uncidi.sh and acorn_version.h
5df3d5a 
PR-URL: #50175
Fixes: #50159
Refs: #50165
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
targos pushed a commit that referenced this pull request Nov 11, 2023
@Keksonoid @targos
tools: fix comments referencing dep_updaters scripts
b959d36 
PR-URL: #50165
Fixes: #50159
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
targos pushed a commit that referenced this pull request Nov 11, 2023
Jungku Lee @targos
tools: update comment in update-uncidi.sh and acorn_version.h
05ee350 
PR-URL: #50175
Fixes: #50159
Refs: #50165
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
v20.10.0 release proposal #50682
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
2023-12-06, N|Solid v5.0.1 Iron Release nodesource/nsolid#41
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marco-ippolito marco-ippolito marco-ippolito left review comments
@panva panva panva approved these changes
@lpinca lpinca lpinca approved these changes
@aduh95 aduh95 aduh95 approved these changes
+1 more reviewer
@mhdawson mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. fast-track PRs proposed for a shorter-than-standard waiting period before landing. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

undici_version.h and acorn_version.h displaying wrong update script path

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@Keksonoid @nodejs-github-bot @aduh95 @panva @lpinca @mhdawson @marco-ippolito
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.