GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: add information about Node-API versions >=9 by mhdawson · Pull Request #50168 · nodejs/node

Conversation

@mhdawson

@mhdawson mhdawson commented Oct 12, 2023

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mhdawson
doc: add information about Node-API versions >=9
f84e39b 
Signed-off-by: Michael Dawson <[email protected]>
@nodejs-github-bot

nodejs-github-bot commented Oct 12, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/node-api
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to Node.js documentation. node-api Issues and PRs related to Node-API. labels Oct 12, 2023
@mhdawson
mhdawson requested a review from legendecas October 12, 2023 21:20
@mhdawson

mhdawson commented Oct 12, 2023

Copy link
Copy Markdown
Member Author

@legendecas can you review to confirm I've gotten this correct.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vmoroz
vmoroz reviewed Oct 12, 2023
View reviewed changes
Comment thread doc/api/n-api.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
vmoroz
vmoroz reviewed Oct 12, 2023
View reviewed changes
Comment thread doc/api/n-api.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
vmoroz
vmoroz reviewed Oct 12, 2023
View reviewed changes
Comment thread doc/api/n-api.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
mhdawson and others added 2 commits October 13, 2023 15:48
@mhdawson
Update n-api.md
87155ef
@mhdawson
squash: make linter happy
aaad700 
Signed-off-by: Michael Dawson <[email protected]>
legendecas
legendecas approved these changes Oct 15, 2023
View reviewed changes
Mifrill
Mifrill reviewed Oct 17, 2023
View reviewed changes
Comment thread doc/api/n-api.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
mhdawson and others added 2 commits October 17, 2023 14:00
@mhdawson @Mifrill
Update doc/api/n-api.md
626e1a2 
Co-authored-by: Alex Strizhak <[email protected]>
@mhdawson
Update n-api.md
fd3279c
gabrielschulhof
gabrielschulhof reviewed Oct 18, 2023
View reviewed changes
Comment thread doc/api/n-api.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread doc/api/n-api.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread doc/api/n-api.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread doc/api/n-api.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread doc/api/n-api.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread doc/api/n-api.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread doc/api/n-api.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread doc/api/n-api.md Resolved

Uh oh!

There was an error while loading. Please reload this page.
mhdawson and others added 8 commits October 20, 2023 09:34
@mhdawson @gabrielschulhof
Update doc/api/n-api.md
cfcc153 
Co-authored-by: Gabriel Schulhof <[email protected]>
@mhdawson @gabrielschulhof
Update doc/api/n-api.md
91db079 
Co-authored-by: Gabriel Schulhof <[email protected]>
@mhdawson @gabrielschulhof
Update doc/api/n-api.md
59552c9 
Co-authored-by: Gabriel Schulhof <[email protected]>
@mhdawson @gabrielschulhof
Update doc/api/n-api.md
bcaaf77 
Co-authored-by: Gabriel Schulhof <[email protected]>
@mhdawson @gabrielschulhof
Update doc/api/n-api.md
ef41a2f 
Co-authored-by: Gabriel Schulhof <[email protected]>
@mhdawson @gabrielschulhof
Update doc/api/n-api.md
ec30e4f 
Co-authored-by: Gabriel Schulhof <[email protected]>
@mhdawson @gabrielschulhof
Update doc/api/n-api.md
ef5fc04 
Co-authored-by: Gabriel Schulhof <[email protected]>
@mhdawson @gabrielschulhof
Update doc/api/n-api.md
0231b66 
Co-authored-by: Gabriel Schulhof <[email protected]>
@mhdawson

mhdawson commented Oct 20, 2023

Copy link
Copy Markdown
Member Author

@gabrielschulhof thanks for the suggestions, pulled them all in.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mhdawson added 2 commits October 23, 2023 17:20
@mhdawson
Update n-api.md
7fa9d66
@mhdawson
Update n-api.md
e7fda3c
@mhdawson

mhdawson commented Oct 23, 2023

Copy link
Copy Markdown
Member Author

@gabrielschulhof @vmoroz believe it is ready for rev-review.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
legendecas
legendecas approved these changes Oct 25, 2023
View reviewed changes

@legendecas legendecas left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
mhdawson added a commit that referenced this pull request Oct 25, 2023
@mhdawson
doc: add information about Node-API versions >=9
7d30667 
Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #50168
Reviewed-By: Chengzhong Wu <[email protected]>
@mhdawson

mhdawson commented Oct 25, 2023

Copy link
Copy Markdown
Member Author

Landed in 7d30667
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhdawson mhdawson closed this Oct 25, 2023
targos pushed a commit that referenced this pull request Nov 11, 2023
@mhdawson @targos
doc: add information about Node-API versions >=9
d62e812 
Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #50168
Reviewed-By: Chengzhong Wu <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
v21.2.0 release proposal #50681
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@mhdawson @UlisesGascon
doc: add information about Node-API versions >=9
cca55b8 
Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #50168
Reviewed-By: Chengzhong Wu <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
v20.11.0 proposal #51124
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vmoroz vmoroz vmoroz left review comments
@gabrielschulhof gabrielschulhof gabrielschulhof left review comments
@legendecas legendecas legendecas approved these changes
+1 more reviewer
@Mifrill Mifrill Mifrill left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation. node-api Issues and PRs related to Node-API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@mhdawson @nodejs-github-bot @vmoroz @gabrielschulhof @legendecas @Mifrill
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.