GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — esm: rename error code related to import attributes by aduh95 · Pull Request #50181 · nodejs/node

Conversation

@aduh95

@aduh95 aduh95 commented Oct 14, 2023

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@aduh95
esm: rename error code related to import attributes
8b2c77c
@aduh95 aduh95 added experimental Issues and PRs related to experimental features. esm Issues and PRs related to the ECMAScript Modules implementation. needs-citgm PRs that need a CITGM CI run. labels Oct 14, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 14, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added errors Issues and PRs related to JavaScript errors originating in Node.js core. needs-ci PRs that need a full CI run. labels Oct 14, 2023
JakobJingleheimer
JakobJingleheimer reviewed Oct 14, 2023
View reviewed changes
Comment thread doc/api/errors.md
removed: REPLACEME
-->

An import assertion has failed, preventing the specified module to be imported.

@JakobJingleheimer JakobJingleheimer Oct 14, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
An import assertion has failed, preventing the specified module to be imported.
An import assertion has failed, preventing the specified module being imported.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@aduh95 aduh95 Oct 14, 2023

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to keep it as is, it's the wording used today in https://nodejs.org/api/errors.html#err_import_assertion_type_failed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread doc/api/errors.md
removed: REPLACEME
-->

An import assertion is missing, preventing the specified module to be imported.

@JakobJingleheimer JakobJingleheimer Oct 14, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
An import assertion is missing, preventing the specified module to be imported.
An import assertion is missing, preventing the specified module being imported.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@aduh95
fixup! esm: rename error code related to import attributes
fe5bef6
GeoffreyBooth
GeoffreyBooth approved these changes Oct 14, 2023
View reviewed changes
@aduh95
fixup! esm: rename error code related to import attributes
945456d
GeoffreyBooth
GeoffreyBooth approved these changes Oct 14, 2023
View reviewed changes
himself65
himself65 approved these changes Oct 14, 2023
View reviewed changes
@aduh95

aduh95 commented Oct 16, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3333/

Test failures seems to match the ones happening on 21.0.0 release proposal, the only addition is torrent-stream but that's a timeout.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Oct 16, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 16, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 16, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54855/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Oct 17, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54902/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95 aduh95 added commit-queue PRs queued for automated landing through the Commit Queue. dont-land-on-v18.x labels Oct 18, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 18, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 37d4f08 into nodejs:main Oct 18, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 18, 2023

Copy link
Copy Markdown
Collaborator

Landed in 37d4f08
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request Oct 23, 2023
@aduh95 @targos
esm: rename error code related to import attributes
7740bf8 
PR-URL: #50181
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
@targos targos mentioned this pull request Oct 23, 2023
v21.1.0 release proposal #50335
Merged
@aduh95
aduh95 deleted the esm-import-attributes branch October 24, 2023 10:19
@targos

targos commented Dec 13, 2023

Copy link
Copy Markdown
Member

Why is this dont-land-on-v20.x ? I need it for #50703
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Dec 13, 2023
v20.11.0 proposal #51124
Merged
[v18.x backport] esm: use import attributes instead of import assertions #51136
Closed
targos pushed a commit to targos/node that referenced this pull request Dec 13, 2023
@aduh95 @targos
esm: rename error code related to import attributes
20efdc9 
PR-URL: nodejs#50181
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
@aduh95

aduh95 commented Dec 13, 2023

Copy link
Copy Markdown
Contributor Author

I'm pretty sure I added the dont-land with the assumption that import attributes would not be backported.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95

aduh95 commented Dec 13, 2023

Copy link
Copy Markdown
Contributor Author

Ah no, I remember now, this PR changes the error codes, and that could break existing code.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos

targos commented Dec 14, 2023

Copy link
Copy Markdown
Member

Aren't we allowed to break code since this is an experimental feature?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos

targos commented Dec 14, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The thing is that a side-effect of #50703 is to change the error code for existing tests (that are updated by this PR).

Forget it. We can keep this out of LTS.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JakobJingleheimer JakobJingleheimer JakobJingleheimer left review comments
@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes
@himself65 himself65 himself65 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. errors Issues and PRs related to JavaScript errors originating in Node.js core. esm Issues and PRs related to the ECMAScript Modules implementation. experimental Issues and PRs related to experimental features. needs-ci PRs that need a full CI run. needs-citgm PRs that need a CITGM CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@aduh95 @nodejs-github-bot @targos @GeoffreyBooth @JakobJingleheimer @himself65
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.