GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — stream: avoid getter for defaultEncoding by ronag · Pull Request #50203 · nodejs/node

Conversation

@ronag

@ronag ronag commented Oct 16, 2023

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot

nodejs-github-bot commented Oct 16, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/streams
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 16, 2023
@ronag
ronag requested review from anonrig, benjamingr and mcollina October 16, 2023 18:50
anonrig
anonrig reviewed Oct 16, 2023
View reviewed changes
Comment thread lib/internal/streams/writable.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
meyfa
meyfa reviewed Oct 16, 2023
View reviewed changes
Comment thread lib/internal/streams/writable.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
mcollina
mcollina approved these changes Oct 17, 2023
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
benjamingr
benjamingr approved these changes Oct 17, 2023
View reviewed changes
@ronag ronag added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 17, 2023
@ronag
ronag force-pushed the writable-default-encoding branch from afbc8dc to ada4899 Compare October 17, 2023 17:46
@ronag ronag added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Oct 17, 2023
anonrig
anonrig approved these changes Oct 17, 2023
View reviewed changes
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 17, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 17, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54893/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Oct 17, 2023
View reviewed changes
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 17, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 17, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 17, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54901/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Oct 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54928/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ronag
stream: avoid getter for defaultEncoding
e05f661 
PR-URL: nodejs#50203
@ronag
ronag force-pushed the writable-default-encoding branch from 9493b26 to e05f661 Compare October 18, 2023 09:27
pacifiquem
pacifiquem reviewed Oct 18, 2023
View reviewed changes

@pacifiquem pacifiquem left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ronag ronag added commit-queue PRs queued for automated landing through the Commit Queue. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Oct 18, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 18, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54941/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 18, 2023
@github-actions github-actions Bot mentioned this pull request Oct 20, 2023
CI Reliability 2023-10-20 nodejs/reliability#692
Open
20 tasks
@ronag ronag added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Oct 21, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 21, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55093/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Oct 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55103/
ronag reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ronag ronag added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 21, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 21, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 21, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/50203
✔  Done loading data for nodejs/node/pull/50203
----------------------------------- PR info ------------------------------------
Title      stream: avoid getter for defaultEncoding (#50203)
Author     Robert Nagy  (@ronag)
Branch     ronag:writable-default-encoding -> nodejs:main
Labels     author ready, needs-ci
Commits    1
 - stream: avoid getter for defaultEncoding
Committers 1
 - Robert Nagy 
PR-URL: https://github.com/nodejs/node/pull/50203
Reviewed-By: Matteo Collina 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/50203
Reviewed-By: Matteo Collina 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - stream: avoid getter for defaultEncoding
   ℹ  This PR was created on Mon, 16 Oct 2023 18:49:29 GMT
   ✔  Approvals: 4
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/50203#pullrequestreview-1681620676
   ✔  - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/50203#pullrequestreview-1682971946
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/50203#pullrequestreview-1683007855
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/50203#pullrequestreview-1683084786
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2023-10-21T19:06:08Z: https://ci.nodejs.org/job/node-test-pull-request/55103/
- Querying data for job/node-test-pull-request/55103/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6599503281
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label Oct 21, 2023
This was referenced Oct 22, 2023
CI Reliability 2023-10-22 nodejs/reliability#694
Open
CI Reliability 2023-10-23 nodejs/reliability#695
Open
@mcollina mcollina added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Oct 23, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 23, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 23, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/50203
✔  Done loading data for nodejs/node/pull/50203
----------------------------------- PR info ------------------------------------
Title      stream: avoid getter for defaultEncoding (#50203)
Author     Robert Nagy  (@ronag)
Branch     ronag:writable-default-encoding -> nodejs:main
Labels     author ready, needs-ci
Commits    1
 - stream: avoid getter for defaultEncoding
Committers 1
 - Robert Nagy 
PR-URL: https://github.com/nodejs/node/pull/50203
Reviewed-By: Matteo Collina 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/50203
Reviewed-By: Matteo Collina 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - stream: avoid getter for defaultEncoding
   ℹ  This PR was created on Mon, 16 Oct 2023 18:49:29 GMT
   ✔  Approvals: 4
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/50203#pullrequestreview-1681620676
   ✔  - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/50203#pullrequestreview-1682971946
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/50203#pullrequestreview-1683007855
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/50203#pullrequestreview-1683084786
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-10-21T20:28:41Z: https://ci.nodejs.org/job/node-test-pull-request/55103/
- Querying data for job/node-test-pull-request/55103/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6609871118
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ronag
ronag requested a review from mcollina October 23, 2023 07:19
mcollina
mcollina approved these changes Oct 23, 2023
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mcollina mcollina added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Oct 23, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 23, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 8e814e3 into nodejs:main Oct 23, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 23, 2023

Copy link
Copy Markdown
Collaborator

Landed in 8e814e3
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Oct 24, 2023
CI Reliability 2023-10-24 nodejs/reliability#696
Open
27 tasks
targos pushed a commit that referenced this pull request Nov 11, 2023
@ronag @targos
stream: avoid getter for defaultEncoding
766bd9c 
PR-URL: #50203
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
v21.2.0 release proposal #50681
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@ronag @UlisesGascon
stream: avoid getter for defaultEncoding
b338f3d 
PR-URL: #50203
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
v20.11.0 proposal #51124
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@mcollina mcollina mcollina approved these changes
@benjamingr benjamingr benjamingr approved these changes
@anonrig anonrig anonrig approved these changes
+3 more reviewers
@meyfa meyfa meyfa left review comments
@Mifrill Mifrill Mifrill left review comments
@pacifiquem pacifiquem pacifiquem left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@ronag @nodejs-github-bot @mcollina @benjamingr @lpinca @anonrig @meyfa @Mifrill @pacifiquem
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.