GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: skip test-benchmark-os.js on IBM i by abmusse · Pull Request #50208 · nodejs/node

Conversation

@abmusse

@abmusse abmusse commented Oct 17, 2023

Copy link
Copy Markdown
Contributor

This change skips the entire test-benchmark-os.js suite on IBM i. Currently this is failing due to os.uptime call:

node/benchmark/os/uptime.js

Line 4 in ea595eb

const uptime = require('os').uptime;

Instead of skipping the entire os benchmark suite, I would rather skip just the uptime benchmark
but I'm not sure how to achieve this. Anyone have any ideas to skip one of the os benchmarks?

CC
@nodejs/platform-ibmi
@richardlau
Fixes #50207

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@abmusse
test: skip test-benchmark-os.js on IBM i
4c44ec6
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Oct 17, 2023
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 17, 2023
richardlau
richardlau approved these changes Oct 17, 2023
View reviewed changes
@richardlau richardlau added the ibm i Issues and PRs related to the IBM i platform. label Oct 17, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 17, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 17, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54879/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mhdawson
mhdawson approved these changes Oct 17, 2023
View reviewed changes

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mhdawson mhdawson added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Oct 17, 2023
@github-actions

github-actions Bot commented Oct 17, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @mhdawson. Please 👍 to approve.
Uzlopak and richardlau reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhdawson

mhdawson commented Oct 17, 2023

Copy link
Copy Markdown
Member

I have an idea on how to be more specific, but think it's good to land this quickly to get the nightly build back to green.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Oct 17, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54905/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Uzlopak

Uzlopak commented Oct 17, 2023

Copy link
Copy Markdown
Contributor

I didnt know that the uptime is not working on ibm :/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Uzlopak
Uzlopak approved these changes Oct 17, 2023
View reviewed changes

@Uzlopak Uzlopak left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created the benchmark and it is not a critical benchmark. It was just for demonstrating that the corresponding PR improves the performance.

We.should simply skip it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot

nodejs-github-bot commented Oct 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54945/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Oct 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54951/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Oct 18, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54964/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@abmusse

abmusse commented Oct 18, 2023

Copy link
Copy Markdown
Contributor Author

I didnt know that the uptime is not working on ibm :/
No worries 😄

I created the benchmark and it is not a critical benchmark. It was just for demonstrating that the corresponding PR improves the performance.

We.should simply skip it.

Yes we will look into how to skip this one individually but for now we will skip the benchmark until we get a patch ready.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mhdawson pushed a commit that referenced this pull request Oct 18, 2023
@abmusse @mhdawson
test: skip test-benchmark-os.js on IBM i
286fdaf 
PR-URL: #50208
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@mhdawson

mhdawson commented Oct 18, 2023

Copy link
Copy Markdown
Member

Landed in 286fdaf
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhdawson mhdawson closed this Oct 18, 2023
@abmusse
abmusse deleted the test-skip-test-benchmark-os branch October 18, 2023 19:48
This was referenced Oct 19, 2023
CI Reliability 2023-10-19 nodejs/reliability#691
Open
CI Reliability 2023-10-20 nodejs/reliability#692
Open
targos pushed a commit that referenced this pull request Oct 23, 2023
@abmusse @targos
test: skip test-benchmark-os.js on IBM i
3e38001 
PR-URL: #50208
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@targos targos mentioned this pull request Oct 23, 2023
v21.1.0 release proposal #50335
Merged
targos pushed a commit that referenced this pull request Nov 11, 2023
@abmusse @targos
test: skip test-benchmark-os.js on IBM i
f3296d2 
PR-URL: #50208
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
v20.10.0 release proposal #50682
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
2023-12-06, N|Solid v5.0.1 Iron Release nodesource/nsolid#41
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlau richardlau richardlau approved these changes
+2 more reviewers
@Uzlopak Uzlopak Uzlopak approved these changes
@mhdawson mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

fast-track PRs proposed for a shorter-than-standard waiting period before landing. ibm i Issues and PRs related to the IBM i platform. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test: benchmark/test-benchmark-os fails on IBM i

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@abmusse @nodejs-github-bot @mhdawson @Uzlopak @richardlau
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.