GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — deps: update undici to 5.26.4 by nodejs-github-bot · Pull Request #50274 · nodejs/node

Conversation

@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot commented Oct 19, 2023

Copy link
Copy Markdown
Collaborator

This is an automated update of undici to 5.26.4.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
transitive-bullshit reacted with rocket emoji
All reactions
  • 🚀 1 reaction
@nodejs-github-bot
deps: update undici to 5.26.4
2bb23ad
@nodejs-github-bot nodejs-github-bot added dependencies PRs that add, update, or configure Node.js dependencies. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Oct 19, 2023
@aduh95 aduh95 mentioned this pull request Oct 19, 2023
deps: update undici to 5.26.4 #50272
Closed
tniessen
tniessen approved these changes Oct 19, 2023
View reviewed changes
richardlau
richardlau approved these changes Oct 19, 2023
View reviewed changes
@richardlau richardlau added lts-watch-v18.x request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Oct 19, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 19, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 19, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/54999/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos linked an issue Oct 19, 2023 that may be closed by this pull request
Node Version 18.18.2 Fails to Instantiate Fetch Request with Proper Options #50263
Closed
@mattcollier mattcollier mentioned this pull request Oct 19, 2023
Node Version 18.18.2 Fails to Instantiate Fetch Request with Proper Options #50263
Closed
@nodejs-github-bot

nodejs-github-bot commented Oct 19, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/55010/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Oct 19, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/55023/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Oct 20, 2023
CI Reliability 2023-10-20 nodejs/reliability#692
Open
20 tasks
@richardlau richardlau added the lts-watch-v20.x label Oct 20, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 20, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/55037/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
panva
panva reviewed Oct 20, 2023
View reviewed changes
Comment thread deps/undici/src/package-lock.json

@panva panva Oct 20, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package-lock.json is not part of the source code and was generated during the build in nodejs/node GitHub Actions, should it be part of deps/undici and commited to nodejs/node?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@mcollina mcollina Oct 20, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package-lock is hardly useful (for undici and this library). We can update the script and remove the package-lock file if you prefer.

I think landing this asap would be better tho.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
panva
panva reviewed Oct 20, 2023
View reviewed changes
Comment thread deps/undici/src/package.json
],
"scripts": {
"build:node": "node scripts/esbuild-build.mjs",
"build:node": "npx esbuild@0.19.4 index-fetch.js --bundle --platform=node --outfile=undici-fetch.js --define:esbuildDetection=1 --keep-names",

@panva panva Oct 20, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this build dependency, fixed to be [email protected], version-automated to be maintained up to date?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@mcollina mcollina Oct 20, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was done like that in undici, and we switched to a build script in a hurry for the security release. https://github.com/nodejs/undici/blob/4006aaf43ac8b30e16d6d3b89fa2e0df4b7eef33/package.json#L73.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@KhafraDev KhafraDev Oct 22, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@panva undici always pinned esbuild's version here. I updated it from some version of 0.14. Realistically we would want to get rid of esbuild entirely, as it's caused nothing but issues (hinting at my next pr probably).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mcollina

mcollina commented Oct 20, 2023

Copy link
Copy Markdown
Member

I kindly ask to fast-track this to be able to fix v18.x v20.x and v21.x asap:

#50263
bbowman and transitive-bullshit reacted with thumbs up emoji bricss reacted with eyes emoji
All reactions
  • 👍 2 reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mcollina mcollina added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Oct 20, 2023
@github-actions

github-actions Bot commented Oct 20, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @mcollina. Please 👍 to approve.
panva, musfiqurcse, bricss, yuripave, and transitive-bullshit reacted with thumbs up emoji
All reactions
  • 👍 5 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Oct 21, 2023
CI Reliability 2023-10-21 nodejs/reliability#693
Open
CI Reliability 2023-10-22 nodejs/reliability#694
Open
@nodejs-github-bot
deps: update undici to 5.26.4
e56f840
@mcollina mcollina added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 22, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 22, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 22, 2023

Copy link
Copy Markdown
Collaborator Author
Commit Queue failed
- Loading data for nodejs/node/pull/50274
✔  Done loading data for nodejs/node/pull/50274
----------------------------------- PR info ------------------------------------
Title      deps: update undici to 5.26.4 (#50274)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     nodejs-github-bot:actions/tools-update-undici -> nodejs:main
Labels     lib / src, fast-track, needs-ci, dependencies, lts-watch-v18.x, lts-watch-v20.x
Commits    2
 - deps: update undici to 5.26.4
 - deps: update undici to 5.26.4
Committers 1
 - Node.js GitHub Bot 
PR-URL: https://github.com/nodejs/node/pull/50274
Reviewed-By: Tobias Nießen 
Reviewed-By: Richard Lau 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/50274
Reviewed-By: Tobias Nießen 
Reviewed-By: Richard Lau 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - deps: update undici to 5.26.4
   ℹ  This PR was created on Thu, 19 Oct 2023 09:23:04 GMT
   ✔  Approvals: 2
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/50274#pullrequestreview-1687504480
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/50274#pullrequestreview-1687505651
   ℹ  This PR is being fast-tracked
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-10-20T08:28:39Z: https://ci.nodejs.org/job/node-test-pull-request/55037/
   ⚠  Commits were pushed after the last Full PR CI run:
   ⚠  - deps: update undici to 5.26.4
- Querying data for job/node-test-pull-request/55037/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6602832895
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 22, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 22, 2023

Copy link
Copy Markdown
Collaborator Author
Commit Queue failed
- Loading data for nodejs/node/pull/50274
✔  Done loading data for nodejs/node/pull/50274
----------------------------------- PR info ------------------------------------
Title      deps: update undici to 5.26.4 (#50274)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     nodejs-github-bot:actions/tools-update-undici -> nodejs:main
Labels     lib / src, fast-track, needs-ci, dependencies, lts-watch-v18.x, lts-watch-v20.x
Commits    2
 - deps: update undici to 5.26.4
 - deps: update undici to 5.26.4
Committers 1
 - Node.js GitHub Bot 
PR-URL: https://github.com/nodejs/node/pull/50274
Reviewed-By: Tobias Nießen 
Reviewed-By: Richard Lau 
Reviewed-By: Matteo Collina 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/50274
Reviewed-By: Tobias Nießen 
Reviewed-By: Richard Lau 
Reviewed-By: Matteo Collina 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 19 Oct 2023 09:23:04 GMT
   ✔  Approvals: 3
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/50274#pullrequestreview-1687504480
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/50274#pullrequestreview-1687505651
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/50274#pullrequestreview-1691423089
   ℹ  This PR is being fast-tracked
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-10-22T09:04:44Z: https://ci.nodejs.org/job/node-test-pull-request/55037/
- Querying data for job/node-test-pull-request/55037/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 50274
From https://github.com/nodejs/node
 * branch                  refs/pull/50274/merge -> FETCH_HEAD
✔  Fetched commits as 7dc74a045118..e56f840313f4
--------------------------------------------------------------------------------
Auto-merging doc/contributing/maintaining/maintaining-dependencies.md
[main 1445ed7391] deps: update undici to 5.26.4
 Date: Thu Oct 19 09:23:01 2023 +0000
 10 files changed, 15449 insertions(+), 116 deletions(-)
 create mode 100644 deps/undici/src/package-lock.json
 delete mode 100644 deps/undici/src/scripts/esbuild-build.mjs
[main d4b24a0cd6] deps: update undici to 5.26.4
 Date: Sun Oct 22 00:28:59 2023 +0000
 1 file changed, 108 insertions(+), 73 deletions(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)

Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

deps: update undici to 5.26.4


PR-URL: #50274

Reviewed-By: Tobias Nießen [email protected]

Reviewed-By: Richard Lau [email protected]

Reviewed-By: Matteo Collina [email protected]


[detached HEAD 02ac09c72c] deps: update undici to 5.26.4

Date: Thu Oct 19 09:23:01 2023 +0000

10 files changed, 15449 insertions(+), 116 deletions(-)

create mode 100644 deps/undici/src/package-lock.json

delete mode 100644 deps/undici/src/scripts/esbuild-build.mjs

Rebasing (3/4)

Rebasing (4/4)


Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

deps: update undici to 5.26.4


PR-URL: #50274

Reviewed-By: Tobias Nießen [email protected]

Reviewed-By: Richard Lau [email protected]

Reviewed-By: Matteo Collina [email protected]


[detached HEAD 150db3e942] deps: update undici to 5.26.4

Date: Sun Oct 22 00:28:59 2023 +0000

1 file changed, 108 insertions(+), 73 deletions(-)


Successfully rebased and updated refs/heads/main.


ℹ  Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.
https://github.com/nodejs/node/actions/runs/6603683952
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richardlau richardlau added commit-queue-squash PRs the Commit Queue should land as one squashed commit. commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Oct 22, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 22, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 76f59b4 into main Oct 22, 2023
@nodejs-github-bot
nodejs-github-bot deleted the actions/tools-update-undici branch October 22, 2023 15:20
@nodejs-github-bot

nodejs-github-bot commented Oct 22, 2023

Copy link
Copy Markdown
Collaborator Author

Landed in 76f59b4
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request Oct 23, 2023
@nodejs-github-bot @targos
deps: update undici to 5.26.4
0005317 
PR-URL: #50274
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@targos targos mentioned this pull request Oct 23, 2023
v21.1.0 release proposal #50335
Merged
@davidlehn

davidlehn commented Oct 24, 2023

Copy link
Copy Markdown

@mcollina It looks like the 5.26.4 update made it into v21.1.0, but not v20.9.0 or v18.x yet. #50263 is still an issue in 20 and 18. These issues are closed now due to the v21 fix but the problem remains. Where is this being tracked and what's the status now?
MajorTanya reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bbowman bbowman mentioned this pull request Oct 25, 2023
Node 18.18.2 Incorrectly copies headers onto fetches nodejs/undici#2374
Closed
@mcollina

mcollina commented Oct 25, 2023

Copy link
Copy Markdown
Member

@nodejs/releasers we need a quick backport to v18.x and v20.x for this one to fix a problematic regression.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request Oct 25, 2023
@nodejs-github-bot @targos
deps: update undici to 5.26.4
7ccb478 
PR-URL: #50274
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@targos

targos commented Oct 25, 2023

Copy link
Copy Markdown
Member

I just cherry-picked it to v18.x-staging.
KhafraDev, MajorTanya, Bas950, and petteri-hirvonen-crasman reacted with heart emoji
All reactions
  • ❤️ 4 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
richardlau pushed a commit that referenced this pull request Oct 26, 2023
@nodejs-github-bot @richardlau
deps: update undici to 5.26.4
61b4afb 
PR-URL: #50274
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@richardlau

richardlau commented Oct 26, 2023

Copy link
Copy Markdown
Member

76f59b4 has also been cherry-picked onto v20.x-staging.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos targos added backported-to-v18.x and removed lts-watch-v18.x labels Oct 27, 2023
@richardlau richardlau added backported-to-v20.x and removed lts-watch-v20.x labels Oct 31, 2023
@sholladay sholladay mentioned this pull request Nov 3, 2023
Header not set on node version 18.18.2 sindresorhus/ky#535
Closed
@targos targos mentioned this pull request Nov 12, 2023
v20.10.0 release proposal #50682
Merged
@targos targos mentioned this pull request Nov 28, 2023
v18.19.0 release proposal #50953
Merged
@codebytere codebytere mentioned this pull request Jan 17, 2024
fix: undici incorrectly copies headers onto fetches electron/electron#41019
Merged
3 tasks done
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
deps: update undici to 5.26.4
23b0e84 
PR-URL: nodejs/node#50274
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
deps: update undici to 5.26.4
8fe3907 
PR-URL: nodejs/node#50274
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panva panva panva left review comments
@KhafraDev KhafraDev KhafraDev left review comments
@mcollina mcollina mcollina approved these changes
@tniessen tniessen tniessen approved these changes
@richardlau richardlau richardlau approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

commit-queue-squash PRs the Commit Queue should land as one squashed commit. dependencies PRs that add, update, or configure Node.js dependencies. fast-track PRs proposed for a shorter-than-standard waiting period before landing. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Node Version 18.18.2 Fails to Instantiate Fetch Request with Proper Options

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@nodejs-github-bot @mcollina @davidlehn @targos @richardlau @panva @tniessen @KhafraDev
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.