GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fixup! test: set test-worker-nearheaplimit-deadlock flaky by StefanStojanovic · Pull Request #50277 · nodejs/node

Conversation

@StefanStojanovic

@StefanStojanovic StefanStojanovic commented Oct 19, 2023 •
edited by targos
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The test is only flaky on x86 Windows.

This is a fixup to #50238 because process.arch returns ia32 and not x86 on x86 node.exe on Windows.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Oct 19, 2023
richardlau
richardlau approved these changes Oct 19, 2023
View reviewed changes
@StefanStojanovic StefanStojanovic mentioned this pull request Oct 19, 2023
parallel.test-worker-nearheaplimit-deadlock is flaky #50220
Closed
@targos

targos commented Oct 19, 2023

Copy link
Copy Markdown
Member

I edited the OP to remove the Fixes link. We should not close issues when the test is marked as flaky, only when it's actually fixed.
richardlau, StefanStojanovic, and anonrig reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@StefanStojanovic
test: set test-worker-nearheaplimit-deadlock flaky
bae1e41
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 19, 2023
@StefanStojanovic
StefanStojanovic force-pushed the mefi-test-worker-nearheaplimit-deadlock-flaky-2 branch from 4b081e1 to bae1e41 Compare October 19, 2023 12:00
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 19, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 19, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54998/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@StefanStojanovic

StefanStojanovic commented Oct 19, 2023

Copy link
Copy Markdown
Contributor Author

We should not close issues when the test is marked as flaky, only when it's actually fixed.

Makes sense! Btw, I had to change the commit message since having fixup part made it longer than 72 characters.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anonrig
anonrig approved these changes Oct 19, 2023
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Oct 19, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55019/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig anonrig added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 19, 2023
@github-actions github-actions Bot mentioned this pull request Oct 20, 2023
CI Reliability 2023-10-20 nodejs/reliability#692
Open
20 tasks
@StefanStojanovic StefanStojanovic mentioned this pull request Oct 20, 2023
test: set test-cli-node-options as flaky #50296
Closed
@StefanStojanovic

StefanStojanovic commented Oct 20, 2023

Copy link
Copy Markdown
Contributor Author

Can someone please request Fast-track for this? I saw it failing in other PRs often. I think it would be beneficial to land this ASAP.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richardlau richardlau added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Oct 20, 2023
@github-actions

github-actions Bot commented Oct 20, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @richardlau. Please 👍 to approve.
richardlau, StefanStojanovic, Ayase-252, and mhdawson reacted with thumbs up emoji
All reactions
  • 👍 4 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richardlau richardlau added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Oct 20, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 20, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 20, 2023

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/50277
✔  Done loading data for nodejs/node/pull/50277
----------------------------------- PR info ------------------------------------
Title      fixup! test: set test-worker-nearheaplimit-deadlock flaky (#50277)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     StefanStojanovic:mefi-test-worker-nearheaplimit-deadlock-flaky-2 -> nodejs:main
Labels     test, fast-track, author ready, needs-ci
Commits    1
 - test: set test-worker-nearheaplimit-deadlock flaky
Committers 1
 - StefanStojanovic 
PR-URL: https://github.com/nodejs/node/pull/50277
Reviewed-By: Richard Lau 
Reviewed-By: Yagiz Nizipli 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/50277
Reviewed-By: Richard Lau 
Reviewed-By: Yagiz Nizipli 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Thu, 19 Oct 2023 10:58:20 GMT
   ✔  Approvals: 2
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/50277#pullrequestreview-1687369552
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/50277#pullrequestreview-1687520300
   ℹ  This PR is being fast-tracked
   ✘  This PR needs to wait 23 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators).
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-10-19T17:01:00Z: https://ci.nodejs.org/job/node-test-pull-request/55019/
- Querying data for job/node-test-pull-request/55019/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6586894859
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richardlau richardlau removed the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label Oct 20, 2023
@StefanStojanovic

StefanStojanovic commented Oct 20, 2023

Copy link
Copy Markdown
Contributor Author

From what I see this is why it failed ✘ This PR needs to wait 23 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators). I've approved fast-track, but I'm not a collaborator, so someone else has to do it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mhdawson
mhdawson approved these changes Oct 20, 2023
View reviewed changes

@mhdawson mhdawson left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
mhdawson pushed a commit that referenced this pull request Oct 20, 2023
@StefanStojanovic @mhdawson
test: set test-worker-nearheaplimit-deadlock flaky
b4cc3e2 
PR-URL: #50277
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@mhdawson

mhdawson commented Oct 20, 2023

Copy link
Copy Markdown
Member

Landed in b4cc3e2
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhdawson mhdawson closed this Oct 20, 2023
@github-actions github-actions Bot mentioned this pull request Oct 21, 2023
CI Reliability 2023-10-21 nodejs/reliability#693
Open
24 tasks
targos pushed a commit that referenced this pull request Oct 23, 2023
@StefanStojanovic @targos
test: set test-worker-nearheaplimit-deadlock flaky
6507f66 
PR-URL: #50277
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@targos targos mentioned this pull request Oct 23, 2023
v21.1.0 release proposal #50335
Merged
targos pushed a commit that referenced this pull request Nov 11, 2023
@StefanStojanovic @targos
test: set test-worker-nearheaplimit-deadlock flaky
b9e0fed 
PR-URL: #50277
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
v20.10.0 release proposal #50682
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
@StefanStojanovic @targos
test: set test-worker-nearheaplimit-deadlock flaky
b41aa7b 
PR-URL: #50277
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
v18.19.0 release proposal #50953
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
2023-12-06, N|Solid v5.0.1 Iron Release nodesource/nsolid#41
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: set test-worker-nearheaplimit-deadlock flaky
e945d7a 
PR-URL: nodejs/node#50277
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: set test-worker-nearheaplimit-deadlock flaky
c0ae310 
PR-URL: nodejs/node#50277
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes
@richardlau richardlau richardlau approved these changes
+1 more reviewer
@mhdawson mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. fast-track PRs proposed for a shorter-than-standard waiting period before landing. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@StefanStojanovic @targos @nodejs-github-bot @mhdawson @anonrig @richardlau
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.