GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — benchmark: skip test-benchmark-os on IBMi by mhdawson · Pull Request #50286 · nodejs/node

Conversation

@mhdawson

@mhdawson mhdawson commented Oct 19, 2023

Copy link
Copy Markdown
Member
  • IBMi does not have the os.uptime implemented so skip otherwise CI tests fail.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mhdawson
benchmark: skip test-benchmark-os on IBMi
b899ab7 
- IBMi does not have the os.uptime implemented so skip
  otherwise CI tests fail.

Signed-off-by: Michael Dawson <[email protected]>
@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. needs-ci PRs that need a full CI run. performance Issues and PRs related to the performance of Node.js. test Issues and PRs related to Node.js core tests and test infrastructure. labels Oct 19, 2023
Uzlopak
Uzlopak approved these changes Oct 19, 2023
View reviewed changes

@Uzlopak Uzlopak left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mhdawson

mhdawson commented Oct 19, 2023

Copy link
Copy Markdown
Member Author

CI run to confirm this skips the test on IBMi and the CI is green - https://ci.nodejs.org/view/All/job/node-test-commit-ibmi/1338/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhdawson
squash: address linter issues
5bb8b87 
Signed-off-by: Michael Dawson <[email protected]>
@mhdawson

mhdawson commented Oct 19, 2023

Copy link
Copy Markdown
Member Author

@abmusse FYI
abmusse reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
H4ad
H4ad reviewed Oct 19, 2023
View reviewed changes
Comment thread benchmark/run.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@mhdawson
squash: address comments
42c2df2 
Signed-off-by: Michael Dawson <[email protected]>
@mhdawson

mhdawson commented Oct 19, 2023

Copy link
Copy Markdown
Member Author

@H4ad @anonrig that works for me as well, pushed commit to do it that way instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
abmusse
abmusse approved these changes Oct 19, 2023
View reviewed changes

@abmusse abmusse left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mhdawson

mhdawson commented Oct 19, 2023

Copy link
Copy Markdown
Member Author

CI to verify again that is passed on ibmi - https://ci.nodejs.org/view/All/job/node-test-commit-ibmi/1339/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
H4ad
H4ad reviewed Oct 19, 2023
View reviewed changes
Comment thread benchmark/os/uptime.js
Comment on lines +14 to +17
if (os.type() === 'OS400') {
console.log('Skipping: os.uptime is not implemented on IBMi');
process.exit(0);
}

@H4ad H4ad Oct 19, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is better to put outside main, on top of the file, just not to have any weird behavior.

But is not a blocker for me, so do it if you agree.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@anonrig anonrig Oct 20, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mhdawson can you move this to a similar position like in other fs benchmarks?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
H4ad
H4ad approved these changes Oct 19, 2023
View reviewed changes
@H4ad H4ad added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Oct 19, 2023
@mhdawson mhdawson added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. fast-track PRs proposed for a shorter-than-standard waiting period before landing. labels Oct 20, 2023
@github-actions

github-actions Bot commented Oct 20, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @mhdawson. Please 👍 to approve.
H4ad, richardlau, and anonrig reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 20, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 20, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55047/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
richardlau
richardlau approved these changes Oct 20, 2023
View reviewed changes
anonrig
anonrig approved these changes Oct 20, 2023
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Oct 20, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55057/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Oct 20, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55064/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lpinca
lpinca approved these changes Oct 20, 2023
View reviewed changes
This was referenced Oct 21, 2023
CI Reliability 2023-10-21 nodejs/reliability#693
Open
CI Reliability 2023-10-22 nodejs/reliability#694
Open
CI Reliability 2023-10-23 nodejs/reliability#695
Open
@nodejs-github-bot

nodejs-github-bot commented Oct 23, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55166/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mhdawson added a commit that referenced this pull request Oct 24, 2023
@mhdawson
benchmark: skip test-benchmark-os on IBMi
abd8ff6 
- IBMi does not have the os.uptime implemented so skip
  otherwise CI tests fail.

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #50286
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@mhdawson

mhdawson commented Oct 24, 2023

Copy link
Copy Markdown
Member Author

Landed in abd8ff6
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhdawson mhdawson closed this Oct 24, 2023
targos pushed a commit that referenced this pull request Nov 11, 2023
@mhdawson @targos
benchmark: skip test-benchmark-os on IBMi
2006b57 
- IBMi does not have the os.uptime implemented so skip
  otherwise CI tests fail.

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #50286
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
v21.2.0 release proposal #50681
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@mhdawson @UlisesGascon
benchmark: skip test-benchmark-os on IBMi
dbe6c5f 
- IBMi does not have the os.uptime implemented so skip
  otherwise CI tests fail.

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #50286
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
v20.11.0 proposal #51124
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes
@lpinca lpinca lpinca approved these changes
@richardlau richardlau richardlau approved these changes
@H4ad H4ad H4ad approved these changes
@abmusse abmusse abmusse approved these changes
+1 more reviewer
@Uzlopak Uzlopak Uzlopak approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. fast-track PRs proposed for a shorter-than-standard waiting period before landing. needs-ci PRs that need a full CI run. performance Issues and PRs related to the performance of Node.js. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@mhdawson @nodejs-github-bot @lpinca @anonrig @Uzlopak @richardlau @H4ad @abmusse
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.