GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: explain how to disable `navigator` by GeoffreyBooth · Pull Request #50310 · nodejs/node

Conversation

@GeoffreyBooth

@GeoffreyBooth GeoffreyBooth commented Oct 20, 2023

Copy link
Copy Markdown
Member

Per #50269 (comment), this adds a note about how to delete the navigator global if necessary. This also sets the experimental status level.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Nikunj262, H4ad, alanabdulkalaam25, and bricss reacted with thumbs up emoji
All reactions
  • 👍 4 reactions
@GeoffreyBooth
doc: explain how to disable navigator
45a04c7
@GeoffreyBooth GeoffreyBooth added doc Issues and PRs related to Node.js documentation. experimental Issues and PRs related to experimental features. dont-land-on-v18.x labels Oct 20, 2023
@GeoffreyBooth
GeoffreyBooth requested a review from anonrig October 20, 2023 22:14
anonrig
anonrig approved these changes Oct 20, 2023
View reviewed changes
himself65
himself65 approved these changes Oct 21, 2023
View reviewed changes
@GeoffreyBooth GeoffreyBooth added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Oct 21, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55077/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bnoordhuis

bnoordhuis commented Oct 21, 2023

Copy link
Copy Markdown
Member

Landing should wait until a decision has been made on whether or not to keep navigator around (IOW, blocked on #50269.)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@GeoffreyBooth

GeoffreyBooth commented Oct 21, 2023

Copy link
Copy Markdown
Member Author

Landing should wait until a decision has been made on whether or not to keep navigator

No. We can always land this and remove the API.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Oct 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55090/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Oct 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55096/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Oct 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55097/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Oct 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55100/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Oct 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55102/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
MoLow
MoLow approved these changes Oct 21, 2023
View reviewed changes
@GeoffreyBooth GeoffreyBooth added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 21, 2023
@github-actions github-actions Bot mentioned this pull request Oct 22, 2023
CI Reliability 2023-10-22 nodejs/reliability#694
Open
29 tasks
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 22, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 25576b5 into nodejs:main Oct 22, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 22, 2023

Copy link
Copy Markdown
Collaborator

Landed in 25576b5
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Oct 23, 2023
CI Reliability 2023-10-23 nodejs/reliability#695
Open
26 tasks
targos pushed a commit that referenced this pull request Oct 23, 2023
@GeoffreyBooth @targos
doc: explain how to disable navigator
6e537ae 
PR-URL: #50310
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
@targos targos mentioned this pull request Oct 23, 2023
v21.1.0 release proposal #50335
Merged
@github-actions github-actions Bot mentioned this pull request Oct 24, 2023
CI Reliability 2023-10-24 nodejs/reliability#696
Open
27 tasks
@GeoffreyBooth GeoffreyBooth mentioned this pull request Oct 26, 2023
lib: hide navigator behind a flag #50412
Closed
@ljharb

ljharb commented Oct 26, 2023

Copy link
Copy Markdown
Member

cc @nodejs/web-standards since we weren't given a chance to weigh in before node's docs recommended a decades-old bad practice.
tniessen reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95

aduh95 commented Oct 26, 2023

Copy link
Copy Markdown
Contributor

Another issue with this recommendation if that --import runs after --require, so if the issue happens in a script that's being preloaded, users are out of luck.
ljharb reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@GeoffreyBooth
GeoffreyBooth deleted the navigator-note branch October 26, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes
@MoLow MoLow MoLow approved these changes
@himself65 himself65 himself65 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. experimental Issues and PRs related to experimental features.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@GeoffreyBooth @nodejs-github-bot @bnoordhuis @ljharb @aduh95 @anonrig @MoLow @himself65
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.