GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — benchmark: add benchmarks for encodings by Uzlopak · Pull Request #50348 · nodejs/node

Conversation

@Uzlopak

@Uzlopak Uzlopak commented Oct 23, 2023

Copy link
Copy Markdown
Contributor

Adds benchmarks for base64url and improves the benchmarks for hex

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. buffer Issues and PRs related to the buffer subsystem. labels Oct 23, 2023
@Uzlopak Uzlopak mentioned this pull request Oct 23, 2023
performance of encodings (hex, base64, base64url) nodejs/performance#128
Open
H4ad
H4ad reviewed Oct 23, 2023
View reviewed changes
Comment thread benchmark/buffers/buffer-hex-decoded.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread benchmark/buffers/buffer-base64url-encode.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread benchmark/buffers/buffer-base64url-decode.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Uzlopak
Uzlopak force-pushed the benchmarks-encodings branch from e68c850 to e76e90a Compare October 23, 2023 22:35
@Uzlopak

Uzlopak commented Oct 23, 2023

Copy link
Copy Markdown
Contributor Author

@H4ad
done
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
H4ad
H4ad approved these changes Oct 23, 2023
View reviewed changes
@Uzlopak
benchmark: add benchmarks for encodings
6ee3a1f
@Uzlopak
Uzlopak force-pushed the benchmarks-encodings branch from e76e90a to 6ee3a1f Compare October 23, 2023 22:39
@H4ad H4ad added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Oct 24, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 24, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 24, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55184/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anonrig
anonrig approved these changes Oct 24, 2023
View reviewed changes
@H4ad H4ad added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 24, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 25, 2023
@nodejs-github-bot
nodejs-github-bot merged commit d895130 into nodejs:main Oct 25, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 25, 2023

Copy link
Copy Markdown
Collaborator

Landed in d895130
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Uzlopak
Uzlopak deleted the benchmarks-encodings branch October 25, 2023 20:52
targos pushed a commit that referenced this pull request Nov 11, 2023
@Uzlopak @targos
benchmark: add benchmarks for encodings
3f37ed9 
PR-URL: #50348
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
v21.2.0 release proposal #50681
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@Uzlopak @UlisesGascon
benchmark: add benchmarks for encodings
15c2ed9 
PR-URL: #50348
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
v20.11.0 proposal #51124
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes
@H4ad H4ad H4ad approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. buffer Issues and PRs related to the buffer subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@Uzlopak @nodejs-github-bot @anonrig @H4ad
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.