GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: run coverage CI only on relevant files by aduh95 · Pull Request #50349 · nodejs/node

Conversation

@aduh95

@aduh95 aduh95 commented Oct 23, 2023

Copy link
Copy Markdown
Contributor

I think it makes sense to restrict run of coverage jobs only on files that can affect its result, so that's what this PR is trying to do.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@aduh95
tools: run coverage CI only on relevant files
8d0ccae
@nodejs-github-bot

nodejs-github-bot commented Oct 23, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 23, 2023
richardlau
richardlau reviewed Oct 23, 2023
View reviewed changes
Comment thread .github/workflows/coverage-linux.yml
Comment on lines +6 to +11
paths:
- lib/**/*.js
- src/**/*.cc
- src/**/*.h
- test/**/*
- .github/workflows/coverage-linux.yml

@richardlau richardlau Oct 23, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theoretically changes to the Python test runner and/or build files (Makefile, gyp files) could also affect coverage results.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@aduh95
fixup! tools: run coverage CI only on relevant files
09c3462
anonrig
anonrig approved these changes Oct 24, 2023
View reviewed changes
richardlau
richardlau approved these changes Oct 24, 2023
View reviewed changes
bnb
bnb approved these changes Oct 25, 2023
View reviewed changes
@aduh95 aduh95 added commit-queue PRs queued for automated landing through the Commit Queue. author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Oct 25, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 25, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 69c0571 into nodejs:main Oct 25, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 25, 2023

Copy link
Copy Markdown
Collaborator

Landed in 69c0571
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 deleted the coverage-allowlist branch October 26, 2023 09:13
targos pushed a commit that referenced this pull request Nov 11, 2023
@aduh95 @targos
tools: run coverage CI only on relevant files
f210915 
PR-URL: #50349
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
v21.2.0 release proposal #50681
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@aduh95 @UlisesGascon
tools: run coverage CI only on relevant files
586becb 
PR-URL: #50349
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
v20.11.0 proposal #51124
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnb bnb bnb approved these changes
@anonrig anonrig anonrig approved these changes
@richardlau richardlau richardlau approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@aduh95 @nodejs-github-bot @bnb @anonrig @richardlau
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.