GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — stream: readable use bitmap accessors by ronag · Pull Request #50350 · nodejs/node

Conversation

ronag commented Oct 23, 2023

Copy link

Copy Markdown

Member

streams/pipe-object-mode.js n=5000000         **      8.12 %       ±5.09% ±7.09% ±9.94%
streams/pipe.js n=5000000                             1.64 %       ±2.67% ±3.69% ±5.10%

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss and lin72h reacted with rocket emoji

All reactions

🚀 2 reactions

nodejs-github-bot commented Oct 23, 2023 •

edited by ronag

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Collaborator

Review requested:

@nodejs/streams

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot added the needs-ci PRs that need a full CI run. label

Oct 23, 2023

ronag force-pushed the readable-bitmap branch from 4b160a9 to 87024e5 Compare

October 23, 2023 21:04

ronag requested review from mcollina and rluvaton

October 23, 2023 21:04

rluvaton added stream

Issues and PRs related to Node.js streams.

performance

Issues and PRs related to the performance of Node.js.

needs-benchmark-ci PRs that need a benchmark CI run. labels

Oct 23, 2023

benjamingr approved these changes

Oct 23, 2023

View reviewed changes

rluvaton approved these changes

Oct 23, 2023

View reviewed changes

ronag added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Oct 23, 2023

ronag force-pushed the readable-bitmap branch from 87024e5 to d6e11dc Compare

October 23, 2023 21:11

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Oct 23, 2023

nodejs-github-bot commented Oct 23, 2023

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55165/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ronag force-pushed the readable-bitmap branch from d6e11dc to 3544359 Compare

October 24, 2023 06:54

ronag changed the title ~~stream: Readable use bitmap accessors~~ stream: readable use bitmap accessors

Oct 24, 2023


          stream: readable use bitmap accessors

b9248c9

PR-URL: nodejs#50350

ronag force-pushed the readable-bitmap branch from 3544359 to b9248c9 Compare

October 24, 2023 06:59

ronag added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label

Oct 24, 2023

nodejs-github-bot commented Oct 24, 2023

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55172/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ronag added the commit-queue PRs queued for automated landing through the Commit Queue. label

Oct 24, 2023

Uzlopak approved these changes

Oct 24, 2023

View reviewed changes

Uzlopak left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

nodejs-github-bot commented Oct 24, 2023

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55176/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Oct 24, 2023

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55189/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot mentioned this pull request

Oct 25, 2023

CI Reliability 2023-10-25 nodejs/reliability#697

Open

16 tasks

nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels

Oct 25, 2023

nodejs-github-bot commented Oct 25, 2023

Copy link

Copy Markdown

Collaborator

Commit Queue failed

- Loading data for nodejs/node/pull/50350
✔  Done loading data for nodejs/node/pull/50350
----------------------------------- PR info ------------------------------------
Title      stream: readable use bitmap accessors (#50350)
Author     Robert Nagy  (@ronag)
Branch     ronag:readable-bitmap -> nodejs:main
Labels     stream, performance, author ready, needs-ci, needs-benchmark-ci
Commits    1
 - stream: readable use bitmap accessors
Committers 1
 - Robert Nagy 
PR-URL: https://github.com/nodejs/node/pull/50350
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Raz Luvaton 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/50350
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Raz Luvaton 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - stream: readable use bitmap accessors
   ℹ  This PR was created on Mon, 23 Oct 2023 21:04:28 GMT
   ✔  Approvals: 2
   ✔  - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/50350#pullrequestreview-1693524231
   ✔  - Raz Luvaton (@rluvaton): https://github.com/nodejs/node/pull/50350#pullrequestreview-1693525520
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-10-24T13:57:48Z: https://ci.nodejs.org/job/node-test-pull-request/55189/
- Querying data for job/node-test-pull-request/55189/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/6646200515

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

rluvaton approved these changes

Oct 25, 2023

View reviewed changes

rluvaton added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels

Oct 25, 2023

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label

Oct 25, 2023

nodejs-github-bot merged commit 31e0759 into nodejs:main

Oct 25, 2023

nodejs-github-bot commented Oct 25, 2023

Copy link

Copy Markdown

Collaborator

Landed in 31e0759

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This was referenced Oct 26, 2023

CI Reliability 2023-10-26 nodejs/reliability#698

Open

CI Reliability 2023-10-27 nodejs/reliability#699

Open

CI Reliability 2023-10-28 nodejs/reliability#700

Open

targos pushed a commit that referenced this pull request

Nov 11, 2023


          stream: readable use bitmap accessors

586ec48

PR-URL: #50350
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Raz Luvaton <[email protected]>

targos mentioned this pull request

Nov 12, 2023

v21.2.0 release proposal #50681

Merged

UlisesGascon pushed a commit that referenced this pull request

Dec 11, 2023


          stream: readable use bitmap accessors

9d52430

PR-URL: #50350
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Raz Luvaton <[email protected]>

UlisesGascon mentioned this pull request

Dec 12, 2023

v20.11.0 proposal #51124

Merged

dead-claudia mentioned this pull request

Feb 12, 2024

Bitwise operations are seemingly not minimized or optimized at all terser/terser#1343

Closed

Reviewers

benjamingr

benjamingr approved these changes

rluvaton

rluvaton approved these changes

mcollina

Awaiting requested review from mcollina

+1 more reviewer

Uzlopak

Uzlopak approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready

PRs with CI started, the required approvals, and no outstanding review comments.

needs-benchmark-ci

PRs that need a benchmark CI run.

needs-ci

PRs that need a full CI run.

performance

Issues and PRs related to the performance of Node.js.

stream

Issues and PRs related to Node.js streams.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

ronag commented Oct 23, 2023

Uh oh!

nodejs-github-bot commented Oct 23, 2023 • edited by ronag Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Oct 23, 2023

Uh oh!

nodejs-github-bot commented Oct 24, 2023

Uh oh!

Uzlopak left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Oct 24, 2023

Uh oh!

nodejs-github-bot commented Oct 24, 2023

Uh oh!

nodejs-github-bot commented Oct 25, 2023

Uh oh!

nodejs-github-bot commented Oct 25, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

nodejs-github-bot commented Oct 23, 2023 •

edited by ronag

Loading

Uh oh!

There was an error while loading. Please reload this page.