GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — benchmark: add more cases to Readable.from by rluvaton · Pull Request #50351 · nodejs/node

Conversation

@rluvaton

@rluvaton rluvaton commented Oct 23, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I'm planning to improve the from perf...

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. stream Issues and PRs related to Node.js streams. labels Oct 23, 2023
@rluvaton
rluvaton requested review from anonrig, benjamingr and ronag October 23, 2023 21:43
@rluvaton rluvaton added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Oct 23, 2023
@github-actions

github-actions Bot commented Oct 23, 2023

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @rluvaton. Please 👍 to approve.
anonrig and H4ad reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rluvaton
benchmark: add more cases to Readable.from
2fbbaed
@rluvaton
rluvaton force-pushed the add-more-cases-to-readable-from branch from 63aa6aa to 2fbbaed Compare October 23, 2023 22:10
anonrig
anonrig approved these changes Oct 23, 2023
View reviewed changes
H4ad
H4ad approved these changes Oct 23, 2023
View reviewed changes
@anonrig anonrig added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 24, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 24, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 0fb5123 into nodejs:main Oct 24, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 24, 2023

Copy link
Copy Markdown
Collaborator

Landed in 0fb5123
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rluvaton
rluvaton deleted the add-more-cases-to-readable-from branch October 24, 2023 08:25
targos pushed a commit that referenced this pull request Nov 11, 2023
@rluvaton @targos
benchmark: add more cases to Readable.from
c4b6e1e 
PR-URL: #50351
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
v21.2.0 release proposal #50681
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@rluvaton @UlisesGascon
benchmark: add more cases to Readable.from
8a89642 
PR-URL: #50351
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
v20.11.0 proposal #51124
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes
@H4ad H4ad H4ad approved these changes
@benjamingr benjamingr Awaiting requested review from benjamingr
@ronag ronag Awaiting requested review from ronag

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

benchmark Issues and PRs related to Node.js benchmarks and benchmarking infrastructure. fast-track PRs proposed for a shorter-than-standard waiting period before landing. stream Issues and PRs related to Node.js streams.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@rluvaton @nodejs-github-bot @anonrig @H4ad
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.