GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: update gyp-next to v0.16.1 by targos · Pull Request #50380 · nodejs/node

Conversation

@targos

@targos targos commented Oct 25, 2023

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot

nodejs-github-bot commented Oct 25, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. gyp Issues and PRs related to GYP and .gyp or .gypi build files. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Oct 25, 2023
@targos

targos commented Oct 25, 2023

Copy link
Copy Markdown
Member Author

@nodejs/python not sure what to do about https://github.com/nodejs/node/actions/runs/6636731539/job/18029693061
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gengjiawen

gengjiawen commented Oct 25, 2023

Copy link
Copy Markdown
Member

@nodejs/python not sure what to do about nodejs/node/actions/runs/6636731539/job/18029693061

ignore tools/gyp should do.

node/pyproject.toml

Line 23 in d1ccca9

"tools/node_modules",

targos reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos added 2 commits October 25, 2023 09:10
@targos
tools: skip ruff on tools/gyp
a723950
@targos
tools: update gyp-next to v0.16.1
4c784ef
@targos
targos force-pushed the update-gyp branch from 003bb7b to 4c784ef Compare October 25, 2023 07:10
gengjiawen
gengjiawen approved these changes Oct 25, 2023
View reviewed changes
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 25, 2023
@cclauss

cclauss commented Oct 25, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

I would comment out this line in tools/gyp/pyproject.toml
error: TOML parse error at line 94, column 3
|
94 | "PLR1714",
| ^^^^^^^^^
Unknown rule selector: PLR1714
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gengjiawen

gengjiawen commented Oct 25, 2023

Copy link
Copy Markdown
Member

I would comment out this line: error: TOML parse error at line 94, column 3 | 94 | "PLR1714", | ^^^^^^^^^ Unknown rule selector: PLR1714

In the long run, we shouldn't lint and format deps in Node.js repo. This can be done in gyp-next.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cclauss

cclauss commented Oct 25, 2023

Copy link
Copy Markdown
Contributor

Oh... This is because we are using a pinned version of ruff and gyp-next is using a current one.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 25, 2023
@cclauss

cclauss commented Oct 25, 2023

Copy link
Copy Markdown
Contributor

Please update

node/Makefile

Lines 1499 to 1500 in d1ccca9

$(PYTHON) -m pip install --upgrade --target tools/pip/site-packages ruff==0.0.272 || \
$(PYTHON) -m pip install --upgrade --system --target tools/pip/site-packages ruff==0.0.272

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Oct 25, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55218/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@targos

targos commented Oct 25, 2023

Copy link
Copy Markdown
Member Author

This should not be related. gyp-next is linted in its own project and I agree with @gengjiawen we should not lint it again with our own rules here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cclauss

cclauss commented Oct 25, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Ruff is designed to work in complex monorepos so we would not be testing the node-gyp directory using this repo’s pyproject.toml (as this error proves). Ruff parsed this file because it will be the settings used to lint that directory.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Oct 28, 2023
View reviewed changes
anonrig
anonrig approved these changes Oct 31, 2023
View reviewed changes
@anonrig anonrig added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. labels Oct 31, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 31, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 31, 2023

Copy link
Copy Markdown
Collaborator

Landed in a77ef54...6557c1c
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot closed this Oct 31, 2023
nodejs-github-bot pushed a commit that referenced this pull request Oct 31, 2023
@targos @nodejs-github-bot
tools: skip ruff on tools/gyp
76d4e38 
PR-URL: #50380
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Oct 31, 2023
@targos @nodejs-github-bot
tools: update gyp-next to v0.16.1
6557c1c 
PR-URL: #50380
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@targos
targos deleted the update-gyp branch October 31, 2023 12:45
This was referenced Nov 6, 2023
build: support Python 3.12 #50209
Merged
build: fix build with Python 3.12 #50582
Merged
targos added a commit that referenced this pull request Nov 11, 2023
@targos
tools: skip ruff on tools/gyp
de9dc10 
PR-URL: #50380
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
targos added a commit that referenced this pull request Nov 11, 2023
@targos
tools: update gyp-next to v0.16.1
171ae59 
PR-URL: #50380
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
v21.2.0 release proposal #50681
Merged
targos added a commit that referenced this pull request Nov 14, 2023
@targos
tools: skip ruff on tools/gyp
9fc29c9 
PR-URL: #50380
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
targos added a commit that referenced this pull request Nov 14, 2023
@targos
tools: update gyp-next to v0.16.1
52e7b6d 
PR-URL: #50380
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@targos targos added lts-watch-v18.x labels Nov 15, 2023
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@targos @UlisesGascon
tools: skip ruff on tools/gyp
f5ccab5 
PR-URL: #50380
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@targos @UlisesGascon
tools: update gyp-next to v0.16.1
22b7a74 
PR-URL: #50380
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
v20.11.0 proposal #51124
Merged
@richardlau richardlau mentioned this pull request Mar 22, 2024
ansible: upgrade test-digitalocean-fedora32-x64-1 nodejs/build#3660
Merged
@richardlau richardlau added backported-to-v20.x and removed lts-watch-v20.x labels Mar 25, 2024
joshuafried pushed a commit to joshuafried/node that referenced this pull request Sep 13, 2024
@targos @joshuafried
tools: update gyp-next to v0.16.1
eb4420d 
PR-URL: nodejs/node#50380
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95 pushed a commit that referenced this pull request Nov 2, 2024
@targos @aduh95
tools: skip ruff on tools/gyp
fa72b2c 
PR-URL: #50380
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95 pushed a commit that referenced this pull request Nov 2, 2024
@targos @aduh95
tools: update gyp-next to v0.16.1
0fb652e 
PR-URL: #50380
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@aduh95 aduh95 added backported-to-v18.x and removed lts-watch-v18.x labels Nov 2, 2024
@aduh95 aduh95 mentioned this pull request Nov 7, 2024
2024-11-12, Version 18.20.5 'Hydrogen' (LTS) #55768
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@anonrig anonrig anonrig approved these changes
@gengjiawen gengjiawen gengjiawen approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. gyp Issues and PRs related to GYP and .gyp or .gypi build files. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@targos @nodejs-github-bot @gengjiawen @cclauss @jasnell @anonrig @richardlau @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.