GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — tools: improve macOS notarization process output readability by UlisesGascon · Pull Request #50389 · nodejs/node

Conversation

UlisesGascon commented Oct 25, 2023

Copy link

Copy Markdown

Member

Main Changes

Improve readability in the MacOS Notarization process.

Details

This was tested in iojs+release-ulises-experimental pipeline in jenkins ci release.

Before

Full log available here

13:38:47 sh tools/osx-notarize.sh v22.0.0-test202310256410f3bf0d
13:38:47 Notarization process is done with Notarytool.
13:40:41 Notarization submitted. Operation ID:

After

Full log available here

15:26:40 sh tools/osx-notarize.sh v22.0.0-test202310256410f3bf0d
15:26:40 Notarization process is done with Notarytool.
15:26:40 Submitting node-v22.0.0-test202310256410f3bf0d.pkg for notarization...
15:26:40 Conducting pre-submission checks for node-v22.0.0-test202310256410f3bf0d.pkg and initiating connection to the Apple notary service...
15:26:41 Submission ID received
15:26:41   id: 8e51972f-3cf5-4b11-aaa4-d4510bea2d04
15:26:53 Successfully uploaded file
15:26:53   id: 8e51972f-3cf5-4b11-aaa4-d4510bea2d04
15:26:53   path: /Users/iojs/build/ws/node-v22.0.0-test202310256410f3bf0d.pkg
15:26:53 Waiting for processing to complete.
15:26:59 
Current status: In Progress...
Current status: In Progress....
Current status: In Progress.....
Current status: In Progress......
Current status: In Progress.......
Current status: In Progress........
Current status: In Progress.........
Current status: In Progress..........
Current status: In Progress...........
Current status: In Progress............
Current status: In Progress.............
Current status: Accepted..............Processing complete
15:28:28   id: 8e51972f-3cf5-4b11-aaa4-d4510bea2d04
15:28:28   status: Accepted
15:28:28 
15:28:28 Notarization node-v22.0.0-test202310256410f3bf0d.pkg submitted successfully.

Context

close: nodejs/build#3529

cc: @nodejs/build

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          tools: improve macOS notarization process output readability

4fc2689

nodejs-github-bot added macos

Issues and PRs related to the macOS platform.

tools Issues and PRs related to the tools directory. labels

Oct 25, 2023

UlisesGascon added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Oct 25, 2023


          fix: remove old variable reference

7021cc4

richardlau reviewed

Oct 25, 2023

View reviewed changes

Comment thread

tools/osx-notarize.sh Resolved

Uh oh!

There was an error while loading. Please reload this page.

UlisesGascon requested a review from richardlau

October 25, 2023 13:52

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Oct 25, 2023

nodejs-github-bot commented Oct 25, 2023

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55229/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

UlisesGascon marked this pull request as ready for review

October 25, 2023 13:56

richardlau approved these changes

Oct 25, 2023

View reviewed changes

richardlau added the commit-queue-squash PRs the Commit Queue should land as one squashed commit. label

Oct 25, 2023

lpinca approved these changes

Oct 25, 2023

View reviewed changes

This was referenced Oct 26, 2023

CI Reliability 2023-10-26 nodejs/reliability#698

Open

CI Reliability 2023-10-27 nodejs/reliability#699

Open

CI Reliability 2023-10-28 nodejs/reliability#700

Open

jasnell approved these changes

Oct 28, 2023

View reviewed changes

github-actions Bot mentioned this pull request

Oct 29, 2023

CI Reliability 2023-10-29 nodejs/reliability#701

Open

21 tasks

nodejs-github-bot commented Oct 29, 2023

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55318/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot mentioned this pull request

Oct 30, 2023

CI Reliability 2023-10-30 nodejs/reliability#702

Open

25 tasks

nodejs-github-bot commented Oct 31, 2023

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55341/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Oct 31, 2023

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55350/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot mentioned this pull request

Nov 1, 2023

CI Reliability 2023-11-01 nodejs/reliability#704

Open

24 tasks

lpinca added the commit-queue PRs queued for automated landing through the Commit Queue. label

Nov 1, 2023

nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label

Nov 1, 2023

nodejs-github-bot merged commit d2903f9 into nodejs:main

Nov 1, 2023

nodejs-github-bot commented Nov 1, 2023

Copy link

Copy Markdown

Collaborator

Landed in d2903f9

UlisesGascon reacted with heart emoji

All reactions

❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot mentioned this pull request

Nov 2, 2023

CI Reliability 2023-11-02 nodejs/reliability#705

Open

25 tasks

UlisesGascon deleted the tools/improve-notarization-details branch

November 5, 2023 19:24

richardlau pushed a commit that referenced this pull request

Nov 7, 2023


          tools: improve macOS notarization process output readability

0aaab45

PR-URL: #50389
Fixes: nodejs/build#3529
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>

targos pushed a commit that referenced this pull request

Nov 11, 2023


          tools: improve macOS notarization process output readability

ed70eb2

PR-URL: #50389
Fixes: nodejs/build#3529
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>

This was referenced Nov 12, 2023

v21.2.0 release proposal #50681

Merged

v20.10.0 release proposal #50682

Merged

targos pushed a commit that referenced this pull request

Nov 14, 2023


          tools: improve macOS notarization process output readability

02dec64

PR-URL: #50389
Fixes: nodejs/build#3529
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>

juanarbol mentioned this pull request

Dec 6, 2023

2023-12-06, N|Solid v5.0.1 Iron Release nodesource/nsolid#41

Merged

richardlau pushed a commit that referenced this pull request

Jan 16, 2024


          tools: improve macOS notarization process output readability

75049b0

PR-URL: #50389
Fixes: nodejs/build#3529
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>

RafaelGSS pushed a commit that referenced this pull request

Feb 14, 2024


          2024-02-14, Version 18.19.1 'Hydrogen' (LTS)

2a5a150

This is a security release.

Notable changes:

crypto:
  * update root certificates to NSS 3.95 (Node.js GitHub Bot) #50805
  * disable PKCS#1 padding for privateDecrypt (Michael Dawson) nodejs-private/node-private#525
deps:
  * upgrade npm to 10.2.4 (npm team) #50751
  * update archs files for openssl-3.0.13+quic1 (Node.js GitHub Bot) #51614
  * upgrade openssl sources to quictls/openssl-3.0.13+quic1 (Node.js GitHub Bot) ://github.com//pull/51614
  * fix GHSA-f74f-cvh7-c6q6/CVE-2024-24806 (Santiago Gimeno) #51614
http:
  * add maximum chunk extension size (Paolo Insogna) nodejs-private/node-private#520
lib:
  * update undici to v5.28.3 (Matteo Collina) nodejs-private/node-private#536
src:
  * fix HasOnly(capability) in node::credentials (Tobias Nießen) nodejs-private/node-private#505
test:
  * skip test-child-process-stdio-reuse-readable-stdio on Windows (Joyee Cheung) #49621
tools:
  * add macOS notarization verification step (Ulises Gascón) #50833
  * use macOS keychain to notarize the releases (Ulises Gascón) #50715
  * remove unused file (Ulises Gascon) #50622
  * add macOS notarization stapler (Ulises Gascón) #50625
  * improve macOS notarization process output readability (Ulises Gascón) #50389
  * remove unused `version` function (Ulises Gascón) #50390
win,tools:
  * upgrade Windows signing to smctl (Stefan Stojanovic) #50956
zlib:
  * pause stream if outgoing buffer is full (Matteo Collina) nodejs-private/node-private#542

PR-URL: nodejs-private/node-private#545

sercher added a commit to sercher/graaljs that referenced this pull request

Apr 25, 2024


          tools: improve macOS notarization process output readability

6bfff7f

PR-URL: nodejs/node#50389
Fixes: nodejs/build#3529
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>

sercher added a commit to sercher/graaljs that referenced this pull request

Apr 25, 2024


          2024-02-14, Version 18.19.1 'Hydrogen' (LTS)

1ddeb10

This is a security release.

Notable changes:

crypto:
  * update root certificates to NSS 3.95 (Node.js GitHub Bot) nodejs/node#50805
  * disable PKCS#1 padding for privateDecrypt (Michael Dawson) https://github.com/nodejs-private/node-private/pull/525
deps:
  * upgrade npm to 10.2.4 (npm team) nodejs/node#50751
  * update archs files for openssl-3.0.13+quic1 (Node.js GitHub Bot) nodejs/node#51614
  * upgrade openssl sources to quictls/openssl-3.0.13+quic1 (Node.js GitHub Bot) ://github.com/nodejs/node/pull/51614
  * fix GHSA-f74f-cvh7-c6q6/CVE-2024-24806 (Santiago Gimeno) nodejs/node#51614
http:
  * add maximum chunk extension size (Paolo Insogna) https://github.com/nodejs-private/node-private/pull/520
lib:
  * update undici to v5.28.3 (Matteo Collina) https://github.com/nodejs-private/node-private/pull/536
src:
  * fix HasOnly(capability) in node::credentials (Tobias Nießen) https://github.com/nodejs-private/node-private/pull/505
test:
  * skip test-child-process-stdio-reuse-readable-stdio on Windows (Joyee Cheung) nodejs/node#49621
tools:
  * add macOS notarization verification step (Ulises Gascón) nodejs/node#50833
  * use macOS keychain to notarize the releases (Ulises Gascón) nodejs/node#50715
  * remove unused file (Ulises Gascon) nodejs/node#50622
  * add macOS notarization stapler (Ulises Gascón) nodejs/node#50625
  * improve macOS notarization process output readability (Ulises Gascón) nodejs/node#50389
  * remove unused `version` function (Ulises Gascón) nodejs/node#50390
win,tools:
  * upgrade Windows signing to smctl (Stefan Stojanovic) nodejs/node#50956
zlib:
  * pause stream if outgoing buffer is full (Matteo Collina) https://github.com/nodejs-private/node-private/pull/542

PR-URL: https://github.com/nodejs-private/node-private/pull/545

sercher added a commit to sercher/graaljs that referenced this pull request

Apr 25, 2024


          tools: improve macOS notarization process output readability

e95f5dd

PR-URL: nodejs/node#50389
Fixes: nodejs/build#3529
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>

sercher added a commit to sercher/graaljs that referenced this pull request

Apr 25, 2024


          2024-02-14, Version 18.19.1 'Hydrogen' (LTS)

d02cd45

This is a security release.

Notable changes:

crypto:
  * update root certificates to NSS 3.95 (Node.js GitHub Bot) nodejs/node#50805
  * disable PKCS#1 padding for privateDecrypt (Michael Dawson) https://github.com/nodejs-private/node-private/pull/525
deps:
  * upgrade npm to 10.2.4 (npm team) nodejs/node#50751
  * update archs files for openssl-3.0.13+quic1 (Node.js GitHub Bot) nodejs/node#51614
  * upgrade openssl sources to quictls/openssl-3.0.13+quic1 (Node.js GitHub Bot) ://github.com/nodejs/node/pull/51614
  * fix GHSA-f74f-cvh7-c6q6/CVE-2024-24806 (Santiago Gimeno) nodejs/node#51614
http:
  * add maximum chunk extension size (Paolo Insogna) https://github.com/nodejs-private/node-private/pull/520
lib:
  * update undici to v5.28.3 (Matteo Collina) https://github.com/nodejs-private/node-private/pull/536
src:
  * fix HasOnly(capability) in node::credentials (Tobias Nießen) https://github.com/nodejs-private/node-private/pull/505
test:
  * skip test-child-process-stdio-reuse-readable-stdio on Windows (Joyee Cheung) nodejs/node#49621
tools:
  * add macOS notarization verification step (Ulises Gascón) nodejs/node#50833
  * use macOS keychain to notarize the releases (Ulises Gascón) nodejs/node#50715
  * remove unused file (Ulises Gascon) nodejs/node#50622
  * add macOS notarization stapler (Ulises Gascón) nodejs/node#50625
  * improve macOS notarization process output readability (Ulises Gascón) nodejs/node#50389
  * remove unused `version` function (Ulises Gascón) nodejs/node#50390
win,tools:
  * upgrade Windows signing to smctl (Stefan Stojanovic) nodejs/node#50956
zlib:
  * pause stream if outgoing buffer is full (Matteo Collina) https://github.com/nodejs-private/node-private/pull/542

PR-URL: https://github.com/nodejs-private/node-private/pull/545

aduh95 pushed a commit to aduh95/node that referenced this pull request

Feb 18, 2025


          tools: improve macOS notarization process output readability

4168c4f

PR-URL: nodejs#50389
Fixes: nodejs/build#3529
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>

aduh95 pushed a commit to aduh95/node that referenced this pull request

Feb 18, 2025


          2024-02-14, Version 18.19.1 'Hydrogen' (LTS)

6610cc4

This is a security release.

Notable changes:

crypto:
  * update root certificates to NSS 3.95 (Node.js GitHub Bot) nodejs#50805
  * disable PKCS#1 padding for privateDecrypt (Michael Dawson) nodejs-private/node-private#525
deps:
  * upgrade npm to 10.2.4 (npm team) nodejs#50751
  * update archs files for openssl-3.0.13+quic1 (Node.js GitHub Bot) nodejs#51614
  * upgrade openssl sources to quictls/openssl-3.0.13+quic1 (Node.js GitHub Bot) ://github.com/nodejs/pull/51614
  * fix GHSA-f74f-cvh7-c6q6/CVE-2024-24806 (Santiago Gimeno) nodejs#51614
http:
  * add maximum chunk extension size (Paolo Insogna) nodejs-private/node-private#520
lib:
  * update undici to v5.28.3 (Matteo Collina) nodejs-private/node-private#536
src:
  * fix HasOnly(capability) in node::credentials (Tobias Nießen) nodejs-private/node-private#505
test:
  * skip test-child-process-stdio-reuse-readable-stdio on Windows (Joyee Cheung) nodejs#49621
tools:
  * add macOS notarization verification step (Ulises Gascón) nodejs#50833
  * use macOS keychain to notarize the releases (Ulises Gascón) nodejs#50715
  * remove unused file (Ulises Gascon) nodejs#50622
  * add macOS notarization stapler (Ulises Gascón) nodejs#50625
  * improve macOS notarization process output readability (Ulises Gascón) nodejs#50389
  * remove unused `version` function (Ulises Gascón) nodejs#50390
win,tools:
  * upgrade Windows signing to smctl (Stefan Stojanovic) nodejs#50956
zlib:
  * pause stream if outgoing buffer is full (Matteo Collina) nodejs-private/node-private#542

PR-URL: nodejs-private/node-private#545

Reviewers

jasnell

jasnell approved these changes

lpinca

lpinca approved these changes

richardlau

richardlau approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

commit-queue-squash

PRs the Commit Queue should land as one squashed commit.

macos

Issues and PRs related to the macOS platform.

tools

Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Notarization script prints an empty operation id

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.