GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — deps: update OpenSSL to 3.0.12+quic1 by nodejs-github-bot · Pull Request #50411 · nodejs/node

Conversation

@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot commented Oct 26, 2023

Copy link
Copy Markdown
Collaborator

This is an automated update of OpenSSL to 3.0.12+quic1.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@nodejs-github-bot nodejs-github-bot added dependencies PRs that add, update, or configure Node.js dependencies. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency. labels Oct 26, 2023
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 26, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 26, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@richardlau

richardlau commented Oct 26, 2023

Copy link
Copy Markdown
Member

For reference, this PR was generated by https://github.com/nodejs/node/actions/runs/6655826163/job/18086969161 (we should get the workflow to add this link to the PR).

aduh95 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

richardlau
richardlau approved these changes Oct 26, 2023
View reviewed changes

@richardlau richardlau left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@richardlau

richardlau commented Oct 26, 2023

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/55256/

I've canceled that run as it was started too early -- some of the platforms were only building the first commit (and the ones started later both commits).

We'll probably need #50395 to land first for the tests to pass on this version of OpenSSL.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

RafaelGSS
RafaelGSS approved these changes Oct 26, 2023
View reviewed changes
@richardlau richardlau mentioned this pull request Oct 27, 2023
deps: update OpenSSL to 3.0.12+quic1 #50410
Closed
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 27, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 27, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
nodejs-github-bot added 2 commits October 27, 2023 19:31
@nodejs-github-bot @richardlau
deps: upgrade openssl sources to quictls/openssl-3.0.12+quic1
6e854c9
@nodejs-github-bot @richardlau
deps: update archs files for openssl-3.0.12+quic1
b1dd1fe
@richardlau
richardlau force-pushed the actions/tools-update-openssl branch from 17be836 to b1dd1fe Compare October 27, 2023 23:45
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 27, 2023
@richardlau

richardlau commented Oct 27, 2023

Copy link
Copy Markdown
Member

I've rebased this PR to pick up #50395 so the GitHub action runs can pass.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 27, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 27, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/55275/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Oct 28, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/55277/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Oct 28, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/55278/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@richardlau richardlau added the commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. label Oct 28, 2023
jasnell
jasnell approved these changes Oct 28, 2023
View reviewed changes
@richardlau richardlau added the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 28, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 28, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 28, 2023

Copy link
Copy Markdown
Collaborator Author

Landed in d1592bd...116b28c

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot nodejs-github-bot closed this Oct 28, 2023
nodejs-github-bot added a commit that referenced this pull request Oct 28, 2023
@nodejs-github-bot
deps: upgrade openssl sources to quictls/openssl-3.0.12+quic1
4281387
PR-URL: #50411
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@github-actions github-actions Bot mentioned this pull request Oct 29, 2023
CI Reliability 2023-10-29 nodejs/reliability#701
Open
21 tasks
This was referenced Oct 30, 2023
CI Reliability 2023-10-30 nodejs/reliability#702
Open
CI Reliability 2023-10-31 nodejs/reliability#703
Open
CI Reliability 2023-11-01 nodejs/reliability#704
Open
@richardlau richardlau added lts-watch-v18.x labels Nov 1, 2023
@baparham

baparham commented Nov 7, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

@richardlau @jasnell @RafaelGSS It seems reasonable that this upgrade should also be backported to 18.x since it is security related (albeit low, as already mentioned on the node.js blog post) so that it's in place for the next release cycle.

What's the process to run the openssl updater against older branches, or would it make sense to just do a manual cherry-pick of this commit to the 18.x branch? I see the lts-watch-v18.x label, but I'm not entirely sure what that does.

edit: I seem to have jumped the gun a bit before reading the backporting docs, so I found that the label does in fact mean that the releaser will have an eye on this PR to backport to 18.x when the time is right.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@RafaelGSS

RafaelGSS commented Nov 10, 2023

Copy link
Copy Markdown
Member

When creating the v18 proposal it should be cherry-picked.

baparham reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos pushed a commit that referenced this pull request Nov 11, 2023
@nodejs-github-bot @targos
deps: upgrade openssl sources to quictls/openssl-3.0.12+quic1
a64217c
PR-URL: #50411
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Nov 11, 2023
@nodejs-github-bot @targos
deps: update archs files for openssl-3.0.12+quic1
a90c6d6
PR-URL: #50411
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
v21.2.0 release proposal #50681
Merged
@targos targos added backported-to-v20.x and removed lts-watch-v20.x labels Nov 15, 2023
targos pushed a commit that referenced this pull request Nov 15, 2023
@nodejs-github-bot @targos
deps: upgrade openssl sources to quictls/openssl-3.0.12+quic1
3308189
PR-URL: #50411
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Nov 15, 2023
@nodejs-github-bot @targos
deps: update archs files for openssl-3.0.12+quic1
68cddd7
PR-URL: #50411
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos added backported-to-v18.x and removed lts-watch-v18.x labels Nov 15, 2023
targos pushed a commit that referenced this pull request Nov 15, 2023
@nodejs-github-bot @targos
deps: upgrade openssl sources to quictls/openssl-3.0.12+quic1
da26cdb
PR-URL: #50411
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Nov 15, 2023
@nodejs-github-bot @targos
deps: update archs files for openssl-3.0.12+quic1
3f6dcc6
PR-URL: #50411
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Nov 21, 2023
v20.10.0 release proposal #50682
Merged
@targos targos mentioned this pull request Nov 28, 2023
v18.19.0 release proposal #50953
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
2023-12-06, N|Solid v5.0.1 Iron Release nodesource/nsolid#41
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
deps: upgrade openssl sources to quictls/openssl-3.0.12+quic1
f8ac42e
PR-URL: nodejs/node#50411
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: James M Snell <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
deps: update archs files for openssl-3.0.12+quic1
1b391ba
PR-URL: nodejs/node#50411
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: James M Snell <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
deps: upgrade openssl sources to quictls/openssl-3.0.12+quic1
3ca3d76
PR-URL: nodejs/node#50411
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: James M Snell <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
deps: update archs files for openssl-3.0.12+quic1
7afcea5
PR-URL: nodejs/node#50411
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@richardlau richardlau richardlau approved these changes
@RafaelGSS RafaelGSS RafaelGSS approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. dependencies PRs that add, update, or configure Node.js dependencies. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@nodejs-github-bot @richardlau @baparham @RafaelGSS @jasnell @panva @targos
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.