GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — meta: add web-standards as web api visibility owner by legendecas · Pull Request #50418 · nodejs/node

Conversation

@legendecas

@legendecas legendecas commented Oct 26, 2023

Copy link
Copy Markdown
Member

When Web APIs global visibility is changed, ping @nodejs/web-standards.

Refs: #50412 (comment)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ljharb reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@legendecas
meta: add web-standards as web api visibility owner
0f49816
@nodejs-github-bot

nodejs-github-bot commented Oct 26, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 26, 2023
aduh95
aduh95 approved these changes Oct 26, 2023
View reviewed changes
GeoffreyBooth
GeoffreyBooth approved these changes Oct 26, 2023
View reviewed changes

@GeoffreyBooth GeoffreyBooth left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also any of the Web Platform Tests? Undici, fetch, ws? Are there any other paths we should cover for this team?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@GeoffreyBooth GeoffreyBooth added the web-standards Issues and PRs related to web-platform APIs and standards compliance. label Oct 26, 2023
benjamingr
benjamingr approved these changes Oct 26, 2023
View reviewed changes
ljharb
ljharb approved these changes Oct 26, 2023
View reviewed changes
tniessen
tniessen approved these changes Oct 26, 2023
View reviewed changes
RaisinTen
RaisinTen approved these changes Oct 27, 2023
View reviewed changes
anonrig
anonrig approved these changes Oct 27, 2023
View reviewed changes
anonrig
anonrig reviewed Oct 27, 2023
View reviewed changes
Comment thread .github/CODEOWNERS Resolved

Uh oh!

There was an error while loading. Please reload this page.
@legendecas
fixup! meta: add web-standards as web api visibility owner
83f704c
@legendecas

legendecas commented Oct 27, 2023

Copy link
Copy Markdown
Member Author

undici is covered by its own dedicated team so I would prefer to defer it to them. Added navigator.js as suggested by @anonrig .
anonrig reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anonrig
anonrig approved these changes Oct 27, 2023
View reviewed changes
GeoffreyBooth
GeoffreyBooth approved these changes Oct 27, 2023
View reviewed changes
mcollina
mcollina approved these changes Oct 28, 2023
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@debadree25 debadree25 added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Oct 28, 2023
@GeoffreyBooth GeoffreyBooth added the commit-queue-squash PRs the Commit Queue should land as one squashed commit. label Oct 28, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Oct 28, 2023
@nodejs-github-bot
nodejs-github-bot merged commit d1592bd into nodejs:main Oct 28, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 28, 2023

Copy link
Copy Markdown
Collaborator

Landed in d1592bd
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@legendecas
legendecas deleted the meta/web-standards branch October 29, 2023 01:51
targos pushed a commit that referenced this pull request Nov 11, 2023
@legendecas @targos
meta: add web-standards as web api visibility owner
d94010b 
PR-URL: #50418
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
v21.2.0 release proposal #50681
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@legendecas @UlisesGascon
meta: add web-standards as web api visibility owner
8d3cf8c 
PR-URL: #50418
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
v20.11.0 proposal #51124
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharb ljharb ljharb approved these changes
@mcollina mcollina mcollina approved these changes
@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes
@benjamingr benjamingr benjamingr approved these changes
@anonrig anonrig anonrig approved these changes
@tniessen tniessen tniessen approved these changes
@aduh95 aduh95 aduh95 approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. meta Issues and PRs related to the general management of the project. web-standards Issues and PRs related to web-platform APIs and standards compliance.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

11 participants

@legendecas @nodejs-github-bot @ljharb @mcollina @GeoffreyBooth @benjamingr @anonrig @tniessen @aduh95 @RaisinTen @debadree25
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.