GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test_runner, cli: add --test-timeout flag by shubham9411 · Pull Request #50443 · nodejs/node

Conversation

@shubham9411

@shubham9411 shubham9411 commented Oct 28, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This commit introduces a new command-line argument, --test-timeout, which allows users to specify a timeout for the test runner CLI.
Fixes: #50431

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss, prashantpandey9, maniSHarma7575, and timursevimli reacted with heart emoji bricss reacted with rocket emoji
All reactions
  • ❤️ 4 reactions
  • 🚀 1 reaction
@nodejs-github-bot

nodejs-github-bot commented Oct 28, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Oct 28, 2023
jasnell
jasnell approved these changes Oct 28, 2023
View reviewed changes
@jasnell jasnell added the semver-minor PRs that contain new features and should be released in the next minor version. label Oct 28, 2023
ljharb
ljharb approved these changes Oct 28, 2023
View reviewed changes
MoLow
MoLow reviewed Oct 28, 2023
View reviewed changes
Comment thread test/fixtures/test-runner/timeout.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

MoLow
MoLow approved these changes Oct 28, 2023
View reviewed changes
@MoLow MoLow added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Oct 28, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 28, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 28, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55299/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Oct 28, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55302/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot mentioned this pull request Oct 29, 2023
CI Reliability 2023-10-29 nodejs/reliability#701
Open
21 tasks
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 29, 2023
MoLow
MoLow approved these changes Oct 29, 2023
View reviewed changes
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 29, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 29, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55312/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

rluvaton
rluvaton approved these changes Oct 29, 2023
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Oct 29, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55313/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

atlowChemi
atlowChemi approved these changes Oct 29, 2023
View reviewed changes
@shubham9411

shubham9411 commented Oct 29, 2023

Copy link
Copy Markdown
Contributor Author

Can anyone help me with the failed tests? I'm not sure if they're flaky or if I need to fix something.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot mentioned this pull request Oct 30, 2023
CI Reliability 2023-10-30 nodejs/reliability#702
Open
25 tasks
@nodejs-github-bot

nodejs-github-bot commented Oct 30, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55331/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@MoLow MoLow added the test_runner Issues and PRs related to the test runner subsystem. label Oct 30, 2023
@github-actions github-actions Bot mentioned this pull request Oct 31, 2023
CI Reliability 2023-10-31 nodejs/reliability#703
Open
17 tasks
@nodejs-github-bot

nodejs-github-bot commented Oct 31, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55339/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Oct 31, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55347/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@MoLow

MoLow commented Oct 31, 2023

Copy link
Copy Markdown
Member

CI seems to fail due to a zombie process:

12:06:01 ps awwx | grep Release/node | grep -v grep | cat
12:06:01 69416   ??  R      8:24.87 /Users/iojs/build/workspace/node-test-commit-osx-arm/nodes/osx11/out/Release/node --test-timeout 50 /Users/iojs/build/workspace/node-test-commit-osx-arm/nodes/osx11/test/fixtures/test-runner/never_ending_sync.js
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@targos targos mentioned this pull request Nov 12, 2023
v21.2.0 release proposal #50681
Merged
targos added a commit that referenced this pull request Nov 13, 2023
@targos
2023-11-14, Version 21.2.0 (Current)
0f82899
Notable changes:

doc:
  * add MrJithil to collaborators (Jithil P Ponnan) #50666
  * add Ethan-Arrowood as a collaborator (Ethan Arrowood) #50393
esm:
  * (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) #48740
fs:
  * add stacktrace to fs/promises (翠 / green) #49849
lib:
  * (SEMVER-MINOR) add `--no-experimental-global-navigator` CLI flag (Antoine du Hamel) #50562
  * (SEMVER-MINOR) add navigator.language & navigator.languages (Aras Abbasi) #50303
  * (SEMVER-MINOR) add navigator.platform (Aras Abbasi) #50385
stream:
  * (SEMVER-MINOR) add support for `deflate-raw` format to webstreams compression (Damian Krzeminski) #50097
  * use Array for Readable buffer (Robert Nagy) #50341
  * optimize creation (Robert Nagy) #50337
test_runner:
  * (SEMVER-MINOR) adds built in lcov reporter (Phil Nash) #50018
  * (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) #48638
test_runner, cli:
  * (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) #50443

PR-URL: #50681
targos pushed a commit that referenced this pull request Nov 14, 2023
@shubham9411 @targos
test_runner, cli: add --test-timeout flag
05e8b6e
PR-URL: #50443
Fixes: #50431
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Raz Luvaton <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
targos added a commit that referenced this pull request Nov 14, 2023
@targos
2023-11-14, Version 21.2.0 (Current)
13b266f
Notable changes:

doc:
  * add MrJithil to collaborators (Jithil P Ponnan) #50666
  * add Ethan-Arrowood as a collaborator (Ethan Arrowood) #50393
esm:
  * (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) #48740
fs:
  * add stacktrace to fs/promises (翠 / green) #49849
lib:
  * (SEMVER-MINOR) add `--no-experimental-global-navigator` CLI flag (Antoine du Hamel) #50562
  * (SEMVER-MINOR) add navigator.language & navigator.languages (Aras Abbasi) #50303
  * (SEMVER-MINOR) add navigator.platform (Aras Abbasi) #50385
stream:
  * (SEMVER-MINOR) add support for `deflate-raw` format to webstreams compression (Damian Krzeminski) #50097
  * use Array for Readable buffer (Robert Nagy) #50341
  * optimize creation (Robert Nagy) #50337
test_runner:
  * (SEMVER-MINOR) adds built in lcov reporter (Phil Nash) #50018
  * (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) #48638
test_runner, cli:
  * (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) #50443

PR-URL: #50681
targos added a commit that referenced this pull request Nov 14, 2023
@targos
2023-11-14, Version 21.2.0 (Current)
02db7fc
Notable changes:

doc:
  * add MrJithil to collaborators (Jithil P Ponnan) #50666
  * add Ethan-Arrowood as a collaborator (Ethan Arrowood) #50393
esm:
  * (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) #48740
fs:
  * add stacktrace to fs/promises (翠 / green) #49849
lib:
  * (SEMVER-MINOR) add `--no-experimental-global-navigator` CLI flag (Antoine du Hamel) #50562
  * (SEMVER-MINOR) add navigator.language & navigator.languages (Aras Abbasi) #50303
  * (SEMVER-MINOR) add navigator.platform (Aras Abbasi) #50385
stream:
  * (SEMVER-MINOR) add support for `deflate-raw` format to webstreams compression (Damian Krzeminski) #50097
  * use Array for Readable buffer (Robert Nagy) #50341
  * optimize creation (Robert Nagy) #50337
test_runner:
  * (SEMVER-MINOR) adds built in lcov reporter (Phil Nash) #50018
  * (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) #48638
test_runner, cli:
  * (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) #50443

PR-URL: #50681
@mateonunez mateonunez mentioned this pull request Nov 16, 2023
refactor(test): remove tap from create-platformatic tests platformatic/platformatic#1811
Merged
18 tasks done
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@shubham9411 @UlisesGascon
test_runner, cli: add --test-timeout flag
842dc01
PR-URL: #50443
Fixes: #50431
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Raz Luvaton <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
UlisesGascon added a commit that referenced this pull request Dec 12, 2023
@UlisesGascon
2023-12-14, Version 20.11.0 'Iron' (LTS)
f02ed77
Notable changes:

crypto:
  * update root certificates to NSS 3.95 (Node.js GitHub Bot) #50805
doc:
  * add MrJithil to collaborators (Jithil P Ponnan) #50666
  * add Ethan-Arrowood as a collaborator (Ethan Arrowood) #50393
esm:
  * (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) #48740
fs:
  * add c++ fast path for writeFileSync utf8 (CanadaHonk) #49884
module:
  * (SEMVER-MINOR) remove useCustomLoadersIfPresent flag (Chengzhong Wu) #48655
src:
  * (SEMVER-MINOR) add `--disable-warning` option (Ethan Arrowood) #50661
  * (SEMVER-MINOR) create per isolate proxy env template (Chengzhong Wu) #48655
  * (SEMVER-MINOR) make process binding data weak (Chengzhong Wu) #48655
stream:
  * use Array for Readable buffer (Robert Nagy) #50341
  * optimize creation (Robert Nagy) #50337
test_runner:
  * (SEMVER-MINOR) adds built in lcov reporter (Phil Nash) #50018
  * (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) #48638
test_runner, cli:
  * (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) #50443

PR-URL: TODO
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
v20.11.0 proposal #51124
Merged
UlisesGascon added a commit that referenced this pull request Dec 12, 2023
@UlisesGascon
2023-12-14, Version 20.11.0 'Iron' (LTS)
ee7e999
Notable changes:

crypto:
  * update root certificates to NSS 3.95 (Node.js GitHub Bot) #50805
doc:
  * add MrJithil to collaborators (Jithil P Ponnan) #50666
  * add Ethan-Arrowood as a collaborator (Ethan Arrowood) #50393
esm:
  * (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) #48740
fs:
  * add c++ fast path for writeFileSync utf8 (CanadaHonk) #49884
module:
  * (SEMVER-MINOR) remove useCustomLoadersIfPresent flag (Chengzhong Wu) #48655
src:
  * (SEMVER-MINOR) add `--disable-warning` option (Ethan Arrowood) #50661
  * (SEMVER-MINOR) create per isolate proxy env template (Chengzhong Wu) #48655
  * (SEMVER-MINOR) make process binding data weak (Chengzhong Wu) #48655
stream:
  * use Array for Readable buffer (Robert Nagy) #50341
  * optimize creation (Robert Nagy) #50337
test_runner:
  * (SEMVER-MINOR) adds built in lcov reporter (Phil Nash) #50018
  * (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) #48638
test_runner, cli:
  * (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) #50443

PR-URL: #51124
UlisesGascon added a commit that referenced this pull request Dec 13, 2023
@UlisesGascon
2023-12-14, Version 20.11.0 'Iron' (LTS)
86c2275
Notable changes:

crypto:
  * update root certificates to NSS 3.95 (Node.js GitHub Bot) #50805
doc:
  * add MrJithil to collaborators (Jithil P Ponnan) #50666
  * add Ethan-Arrowood as a collaborator (Ethan Arrowood) #50393
esm:
  * (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) #48740
fs:
  * add c++ fast path for writeFileSync utf8 (CanadaHonk) #49884
module:
  * (SEMVER-MINOR) remove useCustomLoadersIfPresent flag (Chengzhong Wu) #48655
src:
  * (SEMVER-MINOR) add `--disable-warning` option (Ethan Arrowood) #50661
  * (SEMVER-MINOR) create per isolate proxy env template (Chengzhong Wu) #48655
  * (SEMVER-MINOR) make process binding data weak (Chengzhong Wu) #48655
stream:
  * use Array for Readable buffer (Robert Nagy) #50341
  * optimize creation (Robert Nagy) #50337
test_runner:
  * (SEMVER-MINOR) adds built in lcov reporter (Phil Nash) #50018
  * (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) #48638
test_runner, cli:
  * (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) #50443

PR-URL: #51124
UlisesGascon added a commit that referenced this pull request Dec 15, 2023
@UlisesGascon
2023-12-18, Version 20.11.0 'Iron' (LTS)
c966327
Notable changes:

crypto:
  * update root certificates to NSS 3.95 (Node.js GitHub Bot) #50805
doc:
  * add MrJithil to collaborators (Jithil P Ponnan) #50666
  * add Ethan-Arrowood as a collaborator (Ethan Arrowood) #50393
esm:
  * (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) #48740
fs:
  * add c++ fast path for writeFileSync utf8 (CanadaHonk) #49884
module:
  * (SEMVER-MINOR) remove useCustomLoadersIfPresent flag (Chengzhong Wu) #48655
  * (SEMVER-MINOR) bootstrap module loaders in shadow realm (Chengzhong Wu) #48655
src:
  * (SEMVER-MINOR) add `--disable-warning` option (Ethan Arrowood) #50661
  * (SEMVER-MINOR) create per isolate proxy env template (Chengzhong Wu) #48655
  * (SEMVER-MINOR) make process binding data weak (Chengzhong Wu) #48655
stream:
  * use Array for Readable buffer (Robert Nagy) #50341
  * optimize creation (Robert Nagy) #50337
test_runner:
  * (SEMVER-MINOR) adds built in lcov reporter (Phil Nash) #50018
  * (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) #48638
test_runner, cli:
  * (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) #50443

PR-URL: #51124
UlisesGascon added a commit that referenced this pull request Dec 15, 2023
@UlisesGascon
2023-12-18, Version 20.11.0 'Iron' (LTS)
30081c1
Notable changes:

crypto:
  * update root certificates to NSS 3.95 (Node.js GitHub Bot) #50805
doc:
  * add MrJithil to collaborators (Jithil P Ponnan) #50666
  * add Ethan-Arrowood as a collaborator (Ethan Arrowood) #50393
esm:
  * (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) #48740
fs:
  * add c++ fast path for writeFileSync utf8 (CanadaHonk) #49884
module:
  * (SEMVER-MINOR) remove useCustomLoadersIfPresent flag (Chengzhong Wu) #48655
  * (SEMVER-MINOR) bootstrap module loaders in shadow realm (Chengzhong Wu) #48655
src:
  * (SEMVER-MINOR) add `--disable-warning` option (Ethan Arrowood) #50661
  * (SEMVER-MINOR) create per isolate proxy env template (Chengzhong Wu) #48655
  * (SEMVER-MINOR) make process binding data weak (Chengzhong Wu) #48655
stream:
  * use Array for Readable buffer (Robert Nagy) #50341
  * optimize creation (Robert Nagy) #50337
test_runner:
  * (SEMVER-MINOR) adds built in lcov reporter (Phil Nash) #50018
  * (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) #48638
test_runner, cli:
  * (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) #50443

PR-URL: #51124
UlisesGascon added a commit that referenced this pull request Dec 20, 2023
@UlisesGascon
2023-12-21, Version 20.11.0 'Iron' (LTS)
1a0be53
Notable changes:

crypto:
  * update root certificates to NSS 3.95 (Node.js GitHub Bot) #50805
doc:
  * add MrJithil to collaborators (Jithil P Ponnan) #50666
  * add Ethan-Arrowood as a collaborator (Ethan Arrowood) #50393
esm:
  * (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) #48740
fs:
  * add c++ fast path for writeFileSync utf8 (CanadaHonk) #49884
module:
  * (SEMVER-MINOR) remove useCustomLoadersIfPresent flag (Chengzhong Wu) #48655
  * (SEMVER-MINOR) bootstrap module loaders in shadow realm (Chengzhong Wu) #48655
src:
  * (SEMVER-MINOR) add `--disable-warning` option (Ethan Arrowood) #50661
  * (SEMVER-MINOR) create per isolate proxy env template (Chengzhong Wu) #48655
  * (SEMVER-MINOR) make process binding data weak (Chengzhong Wu) #48655
stream:
  * use Array for Readable buffer (Robert Nagy) #50341
  * optimize creation (Robert Nagy) #50337
test_runner:
  * (SEMVER-MINOR) adds built in lcov reporter (Phil Nash) #50018
  * (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) #48638
test_runner, cli:
  * (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) #50443

PR-URL: #51124
UlisesGascon added a commit that referenced this pull request Jan 3, 2024
@UlisesGascon
2024-01-03, Version 20.11.0 'Iron' (LTS)
fc48ba7
Notable changes:

crypto:
  * update root certificates to NSS 3.95 (Node.js GitHub Bot) #50805
doc:
  * add MrJithil to collaborators (Jithil P Ponnan) #50666
  * add Ethan-Arrowood as a collaborator (Ethan Arrowood) #50393
esm:
  * (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) #48740
fs:
  * add c++ fast path for writeFileSync utf8 (CanadaHonk) #49884
module:
  * (SEMVER-MINOR) remove useCustomLoadersIfPresent flag (Chengzhong Wu) #48655
  * (SEMVER-MINOR) bootstrap module loaders in shadow realm (Chengzhong Wu) #48655
src:
  * (SEMVER-MINOR) add `--disable-warning` option (Ethan Arrowood) #50661
  * (SEMVER-MINOR) create per isolate proxy env template (Chengzhong Wu) #48655
  * (SEMVER-MINOR) make process binding data weak (Chengzhong Wu) #48655
stream:
  * use Array for Readable buffer (Robert Nagy) #50341
  * optimize creation (Robert Nagy) #50337
test_runner:
  * (SEMVER-MINOR) adds built in lcov reporter (Phil Nash) #50018
  * (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) #48638
test_runner, cli:
  * (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) #50443

PR-URL: #51124
UlisesGascon added a commit that referenced this pull request Jan 4, 2024
@UlisesGascon
2024-01-08, Version 20.11.0 'Iron' (LTS)
72bf8da
Notable changes:

crypto:
  * update root certificates to NSS 3.95 (Node.js GitHub Bot) #50805
doc:
  * add MrJithil to collaborators (Jithil P Ponnan) #50666
  * add Ethan-Arrowood as a collaborator (Ethan Arrowood) #50393
esm:
  * (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) #48740
fs:
  * add c++ fast path for writeFileSync utf8 (CanadaHonk) #49884
module:
  * (SEMVER-MINOR) remove useCustomLoadersIfPresent flag (Chengzhong Wu) #48655
  * (SEMVER-MINOR) bootstrap module loaders in shadow realm (Chengzhong Wu) #48655
src:
  * (SEMVER-MINOR) add `--disable-warning` option (Ethan Arrowood) #50661
  * (SEMVER-MINOR) create per isolate proxy env template (Chengzhong Wu) #48655
  * (SEMVER-MINOR) make process binding data weak (Chengzhong Wu) #48655
stream:
  * use Array for Readable buffer (Robert Nagy) #50341
  * optimize creation (Robert Nagy) #50337
test_runner:
  * (SEMVER-MINOR) adds built in lcov reporter (Phil Nash) #50018
  * (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) #48638
test_runner, cli:
  * (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) #50443

PR-URL: #51124
UlisesGascon added a commit that referenced this pull request Jan 9, 2024
@UlisesGascon
2024-01-09, Version 20.11.0 'Iron' (LTS)
8d4fbd7
Notable changes:

crypto:
  * update root certificates to NSS 3.95 (Node.js GitHub Bot) #50805
doc:
  * add MrJithil to collaborators (Jithil P Ponnan) #50666
  * add Ethan-Arrowood as a collaborator (Ethan Arrowood) #50393
esm:
  * (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) #48740
fs:
  * add c++ fast path for writeFileSync utf8 (CanadaHonk) #49884
module:
  * (SEMVER-MINOR) remove useCustomLoadersIfPresent flag (Chengzhong Wu) #48655
  * (SEMVER-MINOR) bootstrap module loaders in shadow realm (Chengzhong Wu) #48655
src:
  * (SEMVER-MINOR) add `--disable-warning` option (Ethan Arrowood) #50661
  * (SEMVER-MINOR) create per isolate proxy env template (Chengzhong Wu) #48655
  * (SEMVER-MINOR) make process binding data weak (Chengzhong Wu) #48655
stream:
  * use Array for Readable buffer (Robert Nagy) #50341
  * optimize creation (Robert Nagy) #50337
test_runner:
  * (SEMVER-MINOR) adds built in lcov reporter (Phil Nash) #50018
  * (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) #48638
test_runner, cli:
  * (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) #50443

PR-URL: #51124
UlisesGascon added a commit that referenced this pull request Jan 9, 2024
@UlisesGascon
2024-01-09, Version 20.11.0 'Iron' (LTS)
2d74e77
Notable changes:

crypto:
  * update root certificates to NSS 3.95 (Node.js GitHub Bot) #50805
doc:
  * add MrJithil to collaborators (Jithil P Ponnan) #50666
  * add Ethan-Arrowood as a collaborator (Ethan Arrowood) #50393
esm:
  * (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) #48740
fs:
  * add c++ fast path for writeFileSync utf8 (CanadaHonk) #49884
module:
  * (SEMVER-MINOR) remove useCustomLoadersIfPresent flag (Chengzhong Wu) #48655
  * (SEMVER-MINOR) bootstrap module loaders in shadow realm (Chengzhong Wu) #48655
src:
  * (SEMVER-MINOR) add `--disable-warning` option (Ethan Arrowood) #50661
  * (SEMVER-MINOR) create per isolate proxy env template (Chengzhong Wu) #48655
  * (SEMVER-MINOR) make process binding data weak (Chengzhong Wu) #48655
stream:
  * use Array for Readable buffer (Robert Nagy) #50341
  * optimize creation (Robert Nagy) #50337
test_runner:
  * (SEMVER-MINOR) adds built in lcov reporter (Phil Nash) #50018
  * (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) #48638
test_runner, cli:
  * (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) #50443

PR-URL: #51124
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Jan 12, 2024
@UlisesGascon @marco-ippolito
2024-01-09, Version 20.11.0 'Iron' (LTS)
c967502
Notable changes:

crypto:
  * update root certificates to NSS 3.95 (Node.js GitHub Bot) nodejs#50805
doc:
  * add MrJithil to collaborators (Jithil P Ponnan) nodejs#50666
  * add Ethan-Arrowood as a collaborator (Ethan Arrowood) nodejs#50393
esm:
  * (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) nodejs#48740
fs:
  * add c++ fast path for writeFileSync utf8 (CanadaHonk) nodejs#49884
module:
  * (SEMVER-MINOR) remove useCustomLoadersIfPresent flag (Chengzhong Wu) nodejs#48655
  * (SEMVER-MINOR) bootstrap module loaders in shadow realm (Chengzhong Wu) nodejs#48655
src:
  * (SEMVER-MINOR) add `--disable-warning` option (Ethan Arrowood) nodejs#50661
  * (SEMVER-MINOR) create per isolate proxy env template (Chengzhong Wu) nodejs#48655
  * (SEMVER-MINOR) make process binding data weak (Chengzhong Wu) nodejs#48655
stream:
  * use Array for Readable buffer (Robert Nagy) nodejs#50341
  * optimize creation (Robert Nagy) nodejs#50337
test_runner:
  * (SEMVER-MINOR) adds built in lcov reporter (Phil Nash) nodejs#50018
  * (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) nodejs#48638
test_runner, cli:
  * (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) nodejs#50443

PR-URL: nodejs#51124
Medhansh404 pushed a commit to Medhansh404/node that referenced this pull request Jan 19, 2024
@UlisesGascon @Medhansh404
2024-01-09, Version 20.11.0 'Iron' (LTS)
5053986
Notable changes:

crypto:
  * update root certificates to NSS 3.95 (Node.js GitHub Bot) nodejs#50805
doc:
  * add MrJithil to collaborators (Jithil P Ponnan) nodejs#50666
  * add Ethan-Arrowood as a collaborator (Ethan Arrowood) nodejs#50393
esm:
  * (SEMVER-MINOR) add import.meta.dirname and import.meta.filename (James Sumners) nodejs#48740
fs:
  * add c++ fast path for writeFileSync utf8 (CanadaHonk) nodejs#49884
module:
  * (SEMVER-MINOR) remove useCustomLoadersIfPresent flag (Chengzhong Wu) nodejs#48655
  * (SEMVER-MINOR) bootstrap module loaders in shadow realm (Chengzhong Wu) nodejs#48655
src:
  * (SEMVER-MINOR) add `--disable-warning` option (Ethan Arrowood) nodejs#50661
  * (SEMVER-MINOR) create per isolate proxy env template (Chengzhong Wu) nodejs#48655
  * (SEMVER-MINOR) make process binding data weak (Chengzhong Wu) nodejs#48655
stream:
  * use Array for Readable buffer (Robert Nagy) nodejs#50341
  * optimize creation (Robert Nagy) nodejs#50337
test_runner:
  * (SEMVER-MINOR) adds built in lcov reporter (Phil Nash) nodejs#50018
  * (SEMVER-MINOR) add Date to the supported mock APIs (Lucas Santos) nodejs#48638
test_runner, cli:
  * (SEMVER-MINOR) add --test-timeout flag (Shubham Pandey) nodejs#50443

PR-URL: nodejs#51124
jeffyaw added a commit to YawLabs/aws-mcp that referenced this pull request Aug 23, 2026
@jeffyaw @claude
fix(test): bound the suite, and stop the fork race hanging on a dead …
5006907
…child

Two fixes for the same failure mode -- an unbounded wait turning a failure
into a hang. `npm test` runs unattended inside release.sh, so a hang wedges
the release rather than aborting it.

1. The concrete defect. The credential-race test forks children and waits on
   `child.once("message")` for a "ready" signal, with nothing on the failure
   path. A child that dies BEFORE signalling -- an import throw, a stale
   build -- never sends it, so the promise stays pending forever and the whole
   suite hangs. It now also settles on `exit`, reporting the child's own exit
   code. A late exit after res() is a no-op on an already-settled promise,
   which is the normal path here: these children are expected to exit once
   the race has been signalled.

2. The backstop. node:test has no default per-test timeout, so any future
   unbounded wait has the same effect. --test-timeout=300000 is deliberately
   generous -- measured files run ~7.5s worst case, so 5 minutes is ~40x
   headroom and cannot false-fail, while still converting a hang into a
   reported failure.

Note the semantics: until Node 24 the flag is per-FILE, not per-test
(nodejs/node#57672), so the value must clear the slowest FILE. Requires
Node >= 20.11.0 (nodejs/node#50443); dev-side script only, so engines is
left alone.

Co-Authored-By: Claude Opus 5 <[email protected]>
jeffyaw added a commit to YawLabs/electron-mcp that referenced this pull request Aug 23, 2026
@jeffyaw @claude
fix(test): bound the suite with --test-timeout so a hang cannot wedge…
8b87bb2
… a release

node:test has NO default per-test timeout, so a test awaiting an event that
never arrives runs forever. `npm test` runs unattended inside release.sh, so
that turns a wedged release rather than a failed one -- the release just never
returns.

--test-timeout=300000 is a backstop, deliberately generous: measured test files
run ~7.5s worst case here, so 5 minutes is roughly 40x headroom and cannot
false-fail, while still converting an infinite hang into a reported failure.

Note the semantics: until Node 24 the flag is per-FILE, not per-test
(nodejs/node#57672), so the value has to clear the slowest FILE. Verified
empirically rather than assumed -- and note that Node already catches the
easy case (a pending promise with a drained event loop) on its own; the case
this flag actually covers is a hang holding a live handle, e.g. a child
process that never messages back.

Requires Node >= 20.11.0 (nodejs/node#50443). This affects the dev-side test
script only, not package consumers, so engines is left alone.

Co-Authored-By: Claude Opus 5 <[email protected]>
jeffyaw added a commit to YawLabs/lemonsqueezy-mcp that referenced this pull request Aug 23, 2026
@jeffyaw @claude
fix(test): bound the suite with --test-timeout so a hang cannot wedge…
9a017a6
… a release

node:test has NO default per-test timeout, so a test awaiting an event that
never arrives runs forever. `npm test` runs unattended inside release.sh, so
that turns a wedged release rather than a failed one -- the release just never
returns.

--test-timeout=300000 is a backstop, deliberately generous: measured test files
run ~7.5s worst case here, so 5 minutes is roughly 40x headroom and cannot
false-fail, while still converting an infinite hang into a reported failure.

Note the semantics: until Node 24 the flag is per-FILE, not per-test
(nodejs/node#57672), so the value has to clear the slowest FILE. Verified
empirically rather than assumed -- and note that Node already catches the
easy case (a pending promise with a drained event loop) on its own; the case
this flag actually covers is a hang holding a live handle, e.g. a child
process that never messages back.

Requires Node >= 20.11.0 (nodejs/node#50443). This affects the dev-side test
script only, not package consumers, so engines is left alone.

Co-Authored-By: Claude Opus 5 <[email protected]>
jeffyaw added a commit to YawLabs/lemonsqueezy-webhook-sink that referenced this pull request Aug 23, 2026
@jeffyaw @claude
fix(test): bound the suite with --test-timeout so a hang cannot wedge…
f6cefa9
… a release

node:test has NO default per-test timeout, so a test awaiting an event that
never arrives runs forever. `npm test` runs unattended inside release.sh, so
that turns a wedged release rather than a failed one -- the release just never
returns.

--test-timeout=300000 is a backstop, deliberately generous: measured test files
run ~7.5s worst case here, so 5 minutes is roughly 40x headroom and cannot
false-fail, while still converting an infinite hang into a reported failure.

Note the semantics: until Node 24 the flag is per-FILE, not per-test
(nodejs/node#57672), so the value has to clear the slowest FILE. Verified
empirically rather than assumed -- and note that Node already catches the
easy case (a pending promise with a drained event loop) on its own; the case
this flag actually covers is a hang holding a live handle, e.g. a child
process that never messages back.

Requires Node >= 20.11.0 (nodejs/node#50443). This affects the dev-side test
script only, not package consumers, so engines is left alone.

Co-Authored-By: Claude Opus 5 <[email protected]>
jeffyaw added a commit to YawLabs/npmjs-mcp that referenced this pull request Aug 23, 2026
@jeffyaw @claude
fix(test): bound the suite with --test-timeout so a hang cannot wedge…
7db6813
… a release

node:test has NO default per-test timeout, so a test awaiting an event that
never arrives runs forever. `npm test` runs unattended inside release.sh, so
that turns a wedged release rather than a failed one -- the release just never
returns.

--test-timeout=300000 is a backstop, deliberately generous: measured test files
run ~7.5s worst case here, so 5 minutes is roughly 40x headroom and cannot
false-fail, while still converting an infinite hang into a reported failure.

Note the semantics: until Node 24 the flag is per-FILE, not per-test
(nodejs/node#57672), so the value has to clear the slowest FILE. Verified
empirically rather than assumed -- and note that Node already catches the
easy case (a pending promise with a drained event loop) on its own; the case
this flag actually covers is a hang holding a live handle, e.g. a child
process that never messages back.

Requires Node >= 20.11.0 (nodejs/node#50443). This affects the dev-side test
script only, not package consumers, so engines is left alone.

Co-Authored-By: Claude Opus 5 <[email protected]>
jeffyaw added a commit to YawLabs/tailscale-mcp that referenced this pull request Aug 23, 2026
@jeffyaw @claude
fix(test): bound the suite with --test-timeout so a hang cannot wedge…
987f601
… a release

node:test has NO default per-test timeout, so a test awaiting an event that
never arrives runs forever. `npm test` runs unattended inside release.sh, so
that turns a wedged release rather than a failed one -- the release just never
returns.

--test-timeout=300000 is a backstop, deliberately generous: measured test files
run ~7.5s worst case here, so 5 minutes is roughly 40x headroom and cannot
false-fail, while still converting an infinite hang into a reported failure.

Note the semantics: until Node 24 the flag is per-FILE, not per-test
(nodejs/node#57672), so the value has to clear the slowest FILE. Verified
empirically rather than assumed -- and note that Node already catches the
easy case (a pending promise with a drained event loop) on its own; the case
this flag actually covers is a hang holding a live handle, e.g. a child
process that never messages back.

Requires Node >= 20.11.0 (nodejs/node#50443). This affects the dev-side test
script only, not package consumers, so engines is left alone.

Co-Authored-By: Claude Opus 5 <[email protected]>
jeffyaw added a commit to YawLabs/tailscale-mcp that referenced this pull request Aug 23, 2026
@jeffyaw @claude
chore(engines): require Node >= 20.11.0 to match the test tooling
2d65587
The test script passes --test-timeout, which node added in 20.11.0
(nodejs/node#50443). The previous ">=20" admitted 20.0-20.10, where the flag
does not exist and `npm test` fails on a bad option.

This narrows the declared floor for consumers even though only the dev-side
script needs it -- the server itself runs on 20.0. Accepted deliberately: the
band is narrow (20.11.0 is the 20 LTS line's own January-2024 patch floor) and
a declared floor that matches what the repo's tooling actually requires beats
one that silently does not.

README updated to match. Only the runtime figure moved; its separate "22+ to develop" note stays correct, since 22 already clears 20.11.

Co-Authored-By: Claude Opus 5 <[email protected]>
jeffyaw added a commit to YawLabs/electron-mcp that referenced this pull request Aug 23, 2026
@jeffyaw @claude
chore(engines): require Node >= 20.11.0 to match the test tooling
80f192a
The test script passes --test-timeout, which node added in 20.11.0
(nodejs/node#50443). The previous ">=20" admitted 20.0-20.10, where the flag
does not exist and `npm test` fails on a bad option.

This narrows the declared floor for consumers even though only the dev-side
script needs it -- the server itself runs on 20.0. Accepted deliberately: the
band is narrow (20.11.0 is the 20 LTS line's own January-2024 patch floor) and
a declared floor that matches what the repo's tooling actually requires beats
one that silently does not.

README updated to match. It claimed "Node.js 18+", which had already drifted from the previous engines ">=20".

Co-Authored-By: Claude Opus 5 <[email protected]>
jeffyaw added a commit to YawLabs/npmjs-mcp that referenced this pull request Aug 23, 2026
@jeffyaw @claude
chore(engines): require Node >= 20.11.0 to match the test tooling
ec21c0a
The test script passes --test-timeout, which node added in 20.11.0
(nodejs/node#50443). The previous ">=20" admitted 20.0-20.10, where the flag
does not exist and `npm test` fails on a bad option.

This narrows the declared floor for consumers even though only the dev-side
script needs it -- the server itself runs on 20.0. Accepted deliberately: the
band is narrow (20.11.0 is the 20 LTS line's own January-2024 patch floor) and
a declared floor that matches what the repo's tooling actually requires beats
one that silently does not.

README updated to match. It quoted the old engines value verbatim and also claimed "the CI matrix tests 20 and 22" -- this repo has no workflows, so that was already false; the claim is dropped rather than reworded.

Co-Authored-By: Claude Opus 5 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharb ljharb ljharb approved these changes
@jasnell jasnell jasnell approved these changes
@benjamingr benjamingr benjamingr approved these changes
@MoLow MoLow MoLow approved these changes
@rluvaton rluvaton rluvaton approved these changes
@atlowChemi atlowChemi atlowChemi approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash PRs the Commit Queue should land as one squashed commit. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

add --test-timeout flag

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@shubham9411 @nodejs-github-bot @MoLow @ljharb @jasnell @benjamingr @rluvaton @atlowChemi
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.