GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: update doc to [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] by nodejs-github-bot · Pull Request #50459 · nodejs/node

Conversation

@nodejs-github-bot

@nodejs-github-bot nodejs-github-bot commented Oct 29, 2023 •
edited by aduh95
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

This is an automated update of doc to [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] (updating those breaks the no-intl CI) [email protected] [email protected].

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Oct 29, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 29, 2023

Copy link
Copy Markdown
Collaborator Author

Review requested:

  • @nodejs/web-infra
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Oct 29, 2023
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 29, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 29, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 29, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/55304/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Oct 29, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/55306/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
MoLow
MoLow previously approved these changes Oct 29, 2023
View reviewed changes
@lpinca lpinca added the blocked PRs that are blocked by other issues or PRs. label Oct 29, 2023
@lpinca

lpinca commented Oct 29, 2023

Copy link
Copy Markdown
Member

See #50414.
MoLow reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MoLow
MoLow dismissed their stale review October 29, 2023 06:30

See #50414.

@github-actions github-actions Bot mentioned this pull request Oct 30, 2023
CI Reliability 2023-10-30 nodejs/reliability#702
Open
25 tasks
@aduh95

aduh95 commented Oct 30, 2023

Copy link
Copy Markdown
Contributor

I think the logical fix is to build the docs with a stable node binary on the without-intl job, so we don't crash the build if the deps uses a regex with the u flag. @nodejs/build how can we make this happen? IIRC the setup job is not available publicly, only a build member can do this sort of change.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@richardlau

richardlau commented Oct 30, 2023

Copy link
Copy Markdown
Member

@aduh95 FWIW the without-intl job runs:

NODE_TEST_DIR=/home/iojs/node-tmp FLAKY_TESTS=dontcare CONFIG_FLAGS=' --without-intl' make run-ci -j 4

Given that we describe how to build without intl in https://github.com/nodejs/node/blob/main/BUILDING.md#building-without-intl-support I'd prefer if we had a solution that worked without involving changes to the Jenkins job -- i.e. running the Makefile after configure --without-intl should just work.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Oct 31, 2023
CI Reliability 2023-10-31 nodejs/reliability#703
Open
17 tasks
jasnell
jasnell approved these changes Nov 11, 2023
View reviewed changes
@nodejs-github-bot nodejs-github-bot changed the title tools: update doc to [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] tools: update doc to [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] Nov 12, 2023
aymen94
aymen94 approved these changes Nov 30, 2023
View reviewed changes
@nodejs-github-bot @aduh95
tools: update doc to [email protected] [email protected]
88b53dd 
And [email protected].
@aduh95
aduh95 force-pushed the actions/tools-update-doc branch from 002a698 to 88b53dd Compare December 10, 2023 23:38
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed blocked PRs that are blocked by other issues or PRs. labels Dec 10, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Dec 10, 2023
@nodejs-github-bot

nodejs-github-bot commented Dec 10, 2023

Copy link
Copy Markdown
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/56213/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 approved these changes Dec 11, 2023
View reviewed changes
@aduh95
aduh95 merged commit ab93a35 into main Dec 11, 2023
@aduh95
aduh95 deleted the actions/tools-update-doc branch December 11, 2023 00:41
@aduh95

aduh95 commented Dec 11, 2023

Copy link
Copy Markdown
Contributor

Landed in ab93a35
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RafaelGSS pushed a commit that referenced this pull request Dec 15, 2023
@nodejs-github-bot @RafaelGSS
tools: update doc to [email protected] [email protected]
297cb6f 
And [email protected].

PR-URL: #50459
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Dec 15, 2023
v21.5.0 proposal #51166
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@nodejs-github-bot @richardlau
tools: update doc to [email protected] [email protected]
c7350c2 
And [email protected].

PR-URL: #50459
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@richardlau richardlau mentioned this pull request Mar 25, 2024
v20.12.0 proposal #52212
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@aduh95 aduh95 aduh95 approved these changes
@MoLow MoLow MoLow left review comments
+1 more reviewer
@aymen94 aymen94 aymen94 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@nodejs-github-bot @lpinca @aduh95 @richardlau @jasnell @MoLow @aymen94
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.