GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — lib: use primordials for navigator.userAgent by Uzlopak · Pull Request #50467 · nodejs/node

Conversation

@Uzlopak

@Uzlopak Uzlopak commented Oct 29, 2023

Copy link
Copy Markdown
Contributor

@anonrig
@ljharb

I got the PR comment, that we should use primordials for userAgent by ljharb As that line was not touched by my PR I want to mark it as resolved, but not lose the information. So here I provide the corresponding PR and resolve that remark in my PR ;)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@Uzlopak
lib: use primordials for navigator.userAgent
848e61a
@nodejs-github-bot

nodejs-github-bot commented Oct 29, 2023

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/web-standards
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 29, 2023
@Uzlopak Uzlopak mentioned this pull request Oct 29, 2023
lib: add navigator.deviceMemory #50229
Closed
GeoffreyBooth
GeoffreyBooth approved these changes Oct 29, 2023
View reviewed changes
@GeoffreyBooth GeoffreyBooth added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Oct 29, 2023
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 29, 2023
@nodejs-github-bot

nodejs-github-bot commented Oct 29, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55317/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
H4ad
H4ad approved these changes Oct 29, 2023
View reviewed changes
ljharb
ljharb approved these changes Oct 29, 2023
View reviewed changes
anonrig
anonrig requested changes Oct 29, 2023
View reviewed changes

@anonrig anonrig left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to get answer to my questions before merging this PR

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread lib/internal/navigator.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Oct 29, 2023
View reviewed changes
@anonrig anonrig removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Oct 29, 2023
@github-actions github-actions Bot mentioned this pull request Oct 30, 2023
CI Reliability 2023-10-30 nodejs/reliability#702
Open
25 tasks
tniessen
tniessen approved these changes Oct 30, 2023
View reviewed changes

@tniessen tniessen left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a constant that might as well be constructed before any user code runs, but LGTM either way.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
H4ad
H4ad approved these changes Oct 30, 2023
View reviewed changes
@Uzlopak

Uzlopak commented Oct 30, 2023

Copy link
Copy Markdown
Contributor Author

What is the conclusion? :)
Can somebody please retrigger the failing ci?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonrig

anonrig commented Oct 30, 2023

Copy link
Copy Markdown
Member

What is the conclusion? :) Can somebody please retrigger the failing ci?

I've left a comment: #50467 (comment)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anonrig
anonrig approved these changes Oct 30, 2023
View reviewed changes
@github-actions github-actions Bot mentioned this pull request Oct 31, 2023
CI Reliability 2023-10-31 nodejs/reliability#703
Open
17 tasks
@nodejs-github-bot

nodejs-github-bot commented Oct 31, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55337/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Oct 31, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55335/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Oct 31, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55338/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Ethan-Arrowood
Ethan-Arrowood approved these changes Oct 31, 2023
View reviewed changes
@github-actions github-actions Bot mentioned this pull request Nov 1, 2023
CI Reliability 2023-11-01 nodejs/reliability#704
Open
24 tasks
@Uzlopak Uzlopak mentioned this pull request Nov 1, 2023
lib: add navigator.language and navigator.languages #50303
Merged
@Uzlopak

Uzlopak commented Nov 1, 2023

Copy link
Copy Markdown
Contributor Author

Can somebody please have a look if the CI issues are unrelated and maybe merge?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Uzlopak

Uzlopak commented Nov 2, 2023

Copy link
Copy Markdown
Contributor Author

@GeoffreyBooth
I think the failing tests are unrelated. Should I rebase from main?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Nov 2, 2023
CI Reliability 2023-11-02 nodejs/reliability#705
Open
25 tasks
@nodejs-github-bot

nodejs-github-bot commented Nov 2, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55400/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@GeoffreyBooth

GeoffreyBooth commented Nov 2, 2023

Copy link
Copy Markdown
Member

Don't rebase unless you have to, we won't be able to resume CI once you do that.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Uzlopak

Uzlopak commented Nov 2, 2023

Copy link
Copy Markdown
Contributor Author

Seems that the CI is green.

Can somebody add the author-ready label and/or merge it?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@H4ad H4ad added the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 2, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Nov 2, 2023
@nodejs-github-bot
nodejs-github-bot merged commit 45f5c9b into nodejs:main Nov 2, 2023
@nodejs-github-bot

nodejs-github-bot commented Nov 2, 2023

Copy link
Copy Markdown
Collaborator

Landed in 45f5c9b
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Uzlopak
Uzlopak deleted the primordials-useragent branch November 2, 2023 13:33
@github-actions github-actions Bot mentioned this pull request Nov 3, 2023
CI Reliability 2023-11-03 nodejs/reliability#706
Open
22 tasks
targos pushed a commit that referenced this pull request Nov 11, 2023
@Uzlopak @targos
lib: use primordials for navigator.userAgent
4c02ec6 
PR-URL: #50467
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
@targos targos mentioned this pull request Nov 12, 2023
v21.2.0 release proposal #50681
Merged
targos pushed a commit that referenced this pull request Nov 14, 2023
@Uzlopak @targos
lib: use primordials for navigator.userAgent
c9bd0c5 
PR-URL: #50467
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@Uzlopak @UlisesGascon
lib: use primordials for navigator.userAgent
a114a91 
PR-URL: #50467
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
v20.11.0 proposal #51124
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 13, 2023
@Uzlopak @UlisesGascon
lib: use primordials for navigator.userAgent
b677218 
PR-URL: #50467
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 15, 2023
@Uzlopak @UlisesGascon
lib: use primordials for navigator.userAgent
057e37c 
PR-URL: #50467
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Dec 19, 2023
@Uzlopak @UlisesGascon
lib: use primordials for navigator.userAgent
48dbde7 
PR-URL: #50467
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharb ljharb ljharb approved these changes
@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes
@benjamingr benjamingr benjamingr left review comments
@MoLow MoLow MoLow left review comments
@jasnell jasnell jasnell approved these changes
@anonrig anonrig anonrig approved these changes
@tniessen tniessen tniessen approved these changes
@H4ad H4ad H4ad approved these changes
@Ethan-Arrowood Ethan-Arrowood Ethan-Arrowood approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

11 participants

@Uzlopak @nodejs-github-bot @anonrig @GeoffreyBooth @ljharb @jasnell @benjamingr @tniessen @MoLow @H4ad @Ethan-Arrowood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.